* linux-next: build warning after merge of the dmaengine tree
@ 2020-09-14 4:29 Stephen Rothwell
2020-09-14 5:30 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-09-14 4:29 UTC (permalink / raw)
To: Vinod Koul; +Cc: Brad Kim, Linux Next Mailing List, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
Hi all,
After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
287 | struct sf_pdma_desc *desc = chan->desc;
| ^~~~
Introduced by commit
8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the dmaengine tree
2020-09-14 4:29 linux-next: build warning after merge of the dmaengine tree Stephen Rothwell
@ 2020-09-14 5:30 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-09-14 5:30 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Brad Kim, Linux Next Mailing List, Linux Kernel Mailing List
Hi Stephen,
On 14-09-20, 14:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
> drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
> 287 | struct sf_pdma_desc *desc = chan->desc;
> | ^~~~
>
> Introduced by commit
>
> 8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice")
Thanks for the report. The function directly uses chan->desc, so yes
this can be removed, Sending patch shortly
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: build warning after merge of the dmaengine tree
2023-12-22 3:29 Stephen Rothwell
@ 2023-12-22 9:45 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2023-12-22 9:45 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Jan Kuliga, Linux Kernel Mailing List, Linux Next Mailing List
On 22-12-23, 14:29, Stephen Rothwell wrote:
> Hi all,
>
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes]
> 729 | xdma_prep_interleaved_dma(struct dma_chan *chan,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")
>
> It should probably be static.
Right, fixed and sent the patch
https://lore.kernel.org/all/20231222094001.731889-1-vkoul@kernel.org/
Thanks for the report
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* linux-next: build warning after merge of the dmaengine tree
@ 2023-12-22 3:29 Stephen Rothwell
2023-12-22 9:45 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2023-12-22 3:29 UTC (permalink / raw)
To: Vinod Koul; +Cc: Jan Kuliga, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
Hi all,
After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes]
729 | xdma_prep_interleaved_dma(struct dma_chan *chan,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Introduced by commit
01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")
It should probably be static.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-22 9:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-14 4:29 linux-next: build warning after merge of the dmaengine tree Stephen Rothwell
2020-09-14 5:30 ` Vinod Koul
2023-12-22 3:29 Stephen Rothwell
2023-12-22 9:45 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).