linux-next: build warning after merge of the dmaengine tree

linux-next: build warning after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes]
  729 | xdma_prep_interleaved_dma(struct dma_chan *chan,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")

It should probably be static.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dmaengine tree

[Vinod Koul]

On 22-12-23, 14:29, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/dma/xilinx/xdma.c:729:1: warning: no previous prototype for 'xdma_prep_interleaved_dma' [-Wmissing-prototypes]
>   729 | xdma_prep_interleaved_dma(struct dma_chan *chan,
>       | ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>   01e6d9076561 ("dmaengine: xilinx: xdma: Implement interleaved DMA transfers")
> 
> It should probably be static.

Right, fixed and sent the patch

https://lore.kernel.org/all/20231222094001.731889-1-vkoul@kernel.org/

Thanks for the report

-- 
~Vinod

linux-next: build warning after merge of the dmaengine tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

Hi all,

After merging the dmaengine tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
  287 |  struct sf_pdma_desc *desc = chan->desc;
      |                       ^~~~

Introduced by commit

  8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the dmaengine tree

[Vinod Koul]

Hi Stephen,

On 14-09-20, 14:29, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the dmaengine tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/dma/sf-pdma/sf-pdma.c: In function 'sf_pdma_donebh_tasklet':
> drivers/dma/sf-pdma/sf-pdma.c:287:23: warning: unused variable 'desc' [-Wunused-variable]
>   287 |  struct sf_pdma_desc *desc = chan->desc;
>       |                       ^~~~
> 
> Introduced by commit
> 
>   8f6b6d060602 ("dmaengine: sf-pdma: Fix an error that calls callback twice")

Thanks for the report. The function directly uses chan->desc, so yes
this can be removed, Sending patch shortly

Thanks
-- 
~Vinod