Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build warning after merge of the drivers-x86 tree
@ 2020-02-10 23:35 Stephen Rothwell
  2020-02-10 23:39 ` Kammela, Gayatri
  2020-02-11 21:07 ` Andy Shevchenko
  0 siblings, 2 replies; 30+ messages in thread
From: Stephen Rothwell @ 2020-02-10 23:35 UTC (permalink / raw)
  To: Darren Hart, Andy Shevchenko
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Gayatri Kammela

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-Wint-conversion]
 1329 |   pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
      |                                           ^~~~~~~~
      |                                           |
      |                                           char *
drivers/platform/x86/intel_pmc_core.c:978:30: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'char *'
  978 |      struct seq_file *s, u32 offset,
      |                          ~~~~^~~~~~
drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-Wint-conversion]
 1329 |   pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
      |                                                     ^~~~~~
      |                                                     |
      |                                                     int
drivers/platform/x86/intel_pmc_core.c:979:18: note: expected 'const char *' but argument is of type 'int'
  979 |      const char *str,
      |      ~~~~~~~~~~~~^~~

Introduced by commit

  2cf128fbf321 ("platform/x86: intel_pmc_core: Dump low power status registers on an S0ix.y failure")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* RE: linux-next: build warning after merge of the drivers-x86 tree
  2020-02-10 23:35 linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell
@ 2020-02-10 23:39 ` Kammela, Gayatri
  2020-02-11 21:07 ` Andy Shevchenko
  1 sibling, 0 replies; 30+ messages in thread
From: Kammela, Gayatri @ 2020-02-10 23:39 UTC (permalink / raw)
  To: Stephen Rothwell, Darren Hart, Andy Shevchenko
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Monday, February 10, 2020 3:36 PM
> To: Darren Hart <dvhart@infradead.org>; Andy Shevchenko
> <andy.shevchenko@gmail.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
> Mailing List <linux-kernel@vger.kernel.org>; Kammela, Gayatri
> <gayatri.kammela@intel.com>
> Subject: linux-next: build warning after merge of the drivers-x86 tree
> 
> Hi all,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
> drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument
> 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-
> Wint-conversion]
>  1329 |   pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset,
> maps);
>       |                                           ^~~~~~~~
>       |                                           |
>       |                                           char *
> drivers/platform/x86/intel_pmc_core.c:978:30: note: expected 'u32' {aka
> 'unsigned int'} but argument is of type 'char *'
>   978 |      struct seq_file *s, u32 offset,
>       |                          ~~~~^~~~~~
> drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument
> 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-
> Wint-conversion]
>  1329 |   pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset,
> maps);
>       |                                                     ^~~~~~
>       |                                                     |
>       |                                                     int
> drivers/platform/x86/intel_pmc_core.c:979:18: note: expected 'const char *'
> but argument is of type 'int'
>   979 |      const char *str,
>       |      ~~~~~~~~~~~~^~~
> 
> Introduced by commit
> 
>   2cf128fbf321 ("platform/x86: intel_pmc_core: Dump low power status
> registers on an S0ix.y failure")
> 
Hi Stephen,
Thanks for reporting the warning!. I have already sent a fix up patch earlier this morning.
> --
> Cheers,
> Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2020-02-10 23:35 linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell
  2020-02-10 23:39 ` Kammela, Gayatri
@ 2020-02-11 21:07 ` Andy Shevchenko
  1 sibling, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2020-02-11 21:07 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Darren Hart, Linux Next Mailing List, Linux Kernel Mailing List,
	Gayatri Kammela

On Tue, Feb 11, 2020 at 1:35 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/intel_pmc_core.c: In function 'pmc_core_resume':
> drivers/platform/x86/intel_pmc_core.c:1329:43: warning: passing argument 4 of 'pmc_core_lpm_display' makes integer from pointer without a cast [-Wint-conversion]
>  1329 |   pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
>       |                                           ^~~~~~~~
>       |                                           |
>       |                                           char *
> drivers/platform/x86/intel_pmc_core.c:978:30: note: expected 'u32' {aka 'unsigned int'} but argument is of type 'char *'
>   978 |      struct seq_file *s, u32 offset,
>       |                          ~~~~^~~~~~
> drivers/platform/x86/intel_pmc_core.c:1329:53: warning: passing argument 5 of 'pmc_core_lpm_display' makes pointer from integer without a cast [-Wint-conversion]
>  1329 |   pmc_core_lpm_display(pmcdev, dev, NULL, "STATUS", offset, maps);
>       |                                                     ^~~~~~
>       |                                                     |
>       |                                                     int
> drivers/platform/x86/intel_pmc_core.c:979:18: note: expected 'const char *' but argument is of type 'int'
>   979 |      const char *str,
>       |      ~~~~~~~~~~~~^~~
>
> Introduced by commit
>
>   2cf128fbf321 ("platform/x86: intel_pmc_core: Dump low power status registers on an S0ix.y failure")

Thank you, Stephen,
Fix had been incorporated.


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2020-01-10  3:57 Stephen Rothwell
@ 2020-01-10  9:47 ` Andy Shevchenko
  0 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2020-01-10  9:47 UTC (permalink / raw)
  To: Stephen Rothwell, kbuild test robot
  Cc: Darren Hart, Linux Next Mailing List, Linux Kernel Mailing List

On Fri, Jan 10, 2020 at 5:57 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telemetry_pltdrv_probe':
> drivers/platform/x86/intel_telemetry_pltdrv.c:1121:6: warning: unused variable 'size' [-Wunused-variable]
>  1121 |  int size, ret = -ENOMEM;
>       |      ^~~~
>
> Introduced by commit
>
>   ebc28a8e59ca ("platform/x86: intel_telemetry_pltdrv: use devm_platform_ioremap_resource()")

Thanks for a report. I'll fix soon.
I'm wondering why I didn't get any report from LKP.

>
> --
> Cheers,
> Stephen Rothwell



-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the drivers-x86 tree
@ 2020-01-10  3:57 Stephen Rothwell
  2020-01-10  9:47 ` Andy Shevchenko
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2020-01-10  3:57 UTC (permalink / raw)
  To: Darren Hart, Andy Shevchenko
  Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi all,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/intel_telemetry_pltdrv.c: In function 'telemetry_pltdrv_probe':
drivers/platform/x86/intel_telemetry_pltdrv.c:1121:6: warning: unused variable 'size' [-Wunused-variable]
 1121 |  int size, ret = -ENOMEM;
      |      ^~~~

Introduced by commit

  ebc28a8e59ca ("platform/x86: intel_telemetry_pltdrv: use devm_platform_ioremap_resource()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-06-30  4:00 Stephen Rothwell
  2017-06-30  5:12 ` Arvind Yadav
@ 2017-07-01  3:32 ` Darren Hart
  1 sibling, 0 replies; 30+ messages in thread
From: Darren Hart @ 2017-07-01  3:32 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Arvind Yadav

On Fri, Jun 30, 2017 at 02:00:54PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>   key_dev->keycode = &sony_laptop_input_keycode_map;
>                    ^
> 
> Introduced by commit
> 
>   a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

Apologies, and thanks for the catch. Rolled the fix from Arnd together with this
and the new one from Arvind. for-next had to be rebased to avoid introducing
this error into mainline.

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-06-30  4:00 Stephen Rothwell
@ 2017-06-30  5:12 ` Arvind Yadav
  2017-07-01  3:32 ` Darren Hart
  1 sibling, 0 replies; 30+ messages in thread
From: Arvind Yadav @ 2017-06-30  5:12 UTC (permalink / raw)
  To: Stephen Rothwell, Darren Hart
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List

Hi,
      I have push one more patch which does not have this warning.
please avoid my first patch.

Thanks
~ arvind

On Friday 30 June 2017 09:30 AM, Stephen Rothwell wrote:
> Hi Darren,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>    key_dev->keycode = &sony_laptop_input_keycode_map;
>                     ^
>
> Introduced by commit
>
>    a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")
>

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the drivers-x86 tree
@ 2017-06-30  4:00 Stephen Rothwell
  2017-06-30  5:12 ` Arvind Yadav
  2017-07-01  3:32 ` Darren Hart
  0 siblings, 2 replies; 30+ messages in thread
From: Stephen Rothwell @ 2017-06-30  4:00 UTC (permalink / raw)
  To: Darren Hart
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Arvind Yadav

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
  key_dev->keycode = &sony_laptop_input_keycode_map;
                   ^

Introduced by commit

  a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-26  9:07             ` Stephen Rothwell
@ 2017-05-26  9:52               ` Andy Shevchenko
  0 siblings, 0 replies; 30+ messages in thread
From: Andy Shevchenko @ 2017-05-26  9:52 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Arnd Bergmann, Darren Hart, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

On Fri, May 26, 2017 at 12:07 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andy,
>
> On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>>
>> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>> >>
>> >> Andy wrote that he committed an updated patch on May 23. The git tree
>> >> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> >> appears to currently contain an older state from May 15.
>> >
>> > So just not pushed out yet.  That's fine, I will hopefully notice when
>> > it turns up.  Just checking that it wasn't forgotten.
>>
>> No, it wasn't, it it in testing branch, I 'm about to push to for-next.
>
> Thanks.  No rush.

Pushed.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-26  9:04           ` Andy Shevchenko
@ 2017-05-26  9:07             ` Stephen Rothwell
  2017-05-26  9:52               ` Andy Shevchenko
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2017-05-26  9:07 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: Arnd Bergmann, Darren Hart, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

Hi Andy,

On Fri, 26 May 2017 12:04:47 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:  
> >>
> >> Andy wrote that he committed an updated patch on May 23. The git tree
> >> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> >> appears to currently contain an older state from May 15.  
> >
> > So just not pushed out yet.  That's fine, I will hopefully notice when
> > it turns up.  Just checking that it wasn't forgotten.  
> 
> No, it wasn't, it it in testing branch, I 'm about to push to for-next.

Thanks.  No rush.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-26  8:35         ` Stephen Rothwell
@ 2017-05-26  9:04           ` Andy Shevchenko
  2017-05-26  9:07             ` Stephen Rothwell
  0 siblings, 1 reply; 30+ messages in thread
From: Andy Shevchenko @ 2017-05-26  9:04 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Arnd Bergmann, Darren Hart, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

On Fri, May 26, 2017 at 11:35 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> Andy wrote that he committed an updated patch on May 23. The git tree
>> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
>> appears to currently contain an older state from May 15.
>
> So just not pushed out yet.  That's fine, I will hopefully notice when
> it turns up.  Just checking that it wasn't forgotten.

No, it wasn't, it it in testing branch, I 'm about to push to for-next.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-26  8:25       ` Arnd Bergmann
@ 2017-05-26  8:35         ` Stephen Rothwell
  2017-05-26  9:04           ` Andy Shevchenko
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2017-05-26  8:35 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Darren Hart, Andy Shevchenko, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

Hi Arnd,

On Fri, 26 May 2017 10:25:36 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>
> Andy wrote that he committed an updated patch on May 23. The git tree
> at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
> appears to currently contain an older state from May 15.

So just not pushed out yet.  That's fine, I will hopefully notice when
it turns up.  Just checking that it wasn't forgotten.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-25 23:34     ` Stephen Rothwell
@ 2017-05-26  8:25       ` Arnd Bergmann
  2017-05-26  8:35         ` Stephen Rothwell
  0 siblings, 1 reply; 30+ messages in thread
From: Arnd Bergmann @ 2017-05-26  8:25 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Darren Hart, Andy Shevchenko, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

On Fri, May 26, 2017 at 1:34 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
>> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> >>
>> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> >> allmodconfig) produced this warning:
>> >>
>> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>> >>  static ssize_t touchpad_store(struct device *dev,
>> >>                 ^
>> >>
>> >> Introduced by commit
>> >>
>> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>> >
>> >
>> > Andy, you warned me about this and I had forgotten before I included it in next.
>> >
>> > Would you like to drop this change, or drop the touchpad_store function?
>>
>> I would go with Arnd's patch if he respins one addressing my comment.
>
> Any progress on this?

Andy wrote that he committed an updated patch on May 23. The git tree
at git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git#for-next
appears to currently contain an older state from May 15.

        Arnd

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-22 18:03   ` Andy Shevchenko
@ 2017-05-25 23:34     ` Stephen Rothwell
  2017-05-26  8:25       ` Arnd Bergmann
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2017-05-25 23:34 UTC (permalink / raw)
  To: Darren Hart
  Cc: Andy Shevchenko, Arnd Bergmann, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

Hi Andy,

On Mon, 22 May 2017 21:03:06 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
>
> On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:  
> >>
> >> After merging the drivers-x86 tree, today's linux-next build (x86_64
> >> allmodconfig) produced this warning:
> >>
> >> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
> >>  static ssize_t touchpad_store(struct device *dev,
> >>                 ^
> >>
> >> Introduced by commit
> >>
> >>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")  
> >
> >
> > Andy, you warned me about this and I had forgotten before I included it in next.
> >
> > Would you like to drop this change, or drop the touchpad_store function?  
> 
> I would go with Arnd's patch if he respins one addressing my comment.

Any progress on this?

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-19 22:09 ` Darren Hart
@ 2017-05-22 18:03   ` Andy Shevchenko
  2017-05-25 23:34     ` Stephen Rothwell
  0 siblings, 1 reply; 30+ messages in thread
From: Andy Shevchenko @ 2017-05-22 18:03 UTC (permalink / raw)
  To: Darren Hart, Arnd Bergmann
  Cc: Stephen Rothwell, Linux-Next Mailing List,
	Linux Kernel Mailing List, Ritesh Raj Sarraf, Andy Shevchenko

On Sat, May 20, 2017 at 1:09 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
>> Hi Darren,
>>
>> After merging the drivers-x86 tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>>  static ssize_t touchpad_store(struct device *dev,
>>                 ^
>>
>> Introduced by commit
>>
>>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")
>
> Thank you Stephen,
>
> Andy, you warned me about this and I had forgotten before I included it in next.
>
> Would you like to drop this change, or drop the touchpad_store function?

I would go with Arnd's patch if he respins one addressing my comment.

-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2017-05-19  3:23 Stephen Rothwell
@ 2017-05-19 22:09 ` Darren Hart
  2017-05-22 18:03   ` Andy Shevchenko
  0 siblings, 1 reply; 30+ messages in thread
From: Darren Hart @ 2017-05-19 22:09 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Ritesh Raj Sarraf, Andy Shevchenko

On Fri, May 19, 2017 at 01:23:17PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
>  static ssize_t touchpad_store(struct device *dev,
>                 ^
> 
> Introduced by commit
> 
>   7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")

Thank you Stephen,

Andy, you warned me about this and I had forgotten before I included it in next.

Would you like to drop this change, or drop the touchpad_store function?

-- 
Darren Hart
VMware Open Source Technology Center

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the drivers-x86 tree
@ 2017-05-19  3:23 Stephen Rothwell
  2017-05-19 22:09 ` Darren Hart
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2017-05-19  3:23 UTC (permalink / raw)
  To: Darren Hart
  Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
	Ritesh Raj Sarraf, Andy Shevchenko

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/ideapad-laptop.c:438:16: warning: 'touchpad_store' defined but not used [-Wunused-function]
 static ssize_t touchpad_store(struct device *dev,
                ^

Introduced by commit

  7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO")

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2016-12-15  0:02     ` Stephen Rothwell
@ 2016-12-15  4:07       ` Darren Hart
  0 siblings, 0 replies; 30+ messages in thread
From: Darren Hart @ 2016-12-15  4:07 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Lyude, Henrique de Moraes Holschuh,
	Andy Shevchenko

On Thu, Dec 15, 2016 at 11:02:19AM +1100, Stephen Rothwell wrote:
> Hi Darren,
> 
> On Wed, 14 Dec 2016 14:59:14 -0800 Darren Hart <dvhart@infradead.org> wrote:
> >
> > On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> > > On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:  
> > > > 
> > > > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > > > allmodconfig) produced this warning:
> > > > 
> > > > In file included from include/linux/kernel.h:13:0,
> > > >                  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > > > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > >   ^
> > > > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
> > > >   char *type;
> > > >         ^
> > > > In file included from include/linux/kernel.h:13:0,
> > > >                  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > > >   ^
> > > > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was declared here
> > > >   int in_tablet_mode, res;
> > > >       ^
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")
> > > > 
> > > > I can't tell if this is a false positive or not.  
> > > 
> > > That's an uninitialized local variable. Not sure how I missed that. I'll
> > > fix it up today. Thank you for the report.  
> > 
> > OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
> > both places where in_tablet_mode is assigned, and if the former is 0 (global
> > scope), the function returns without calling pr_info.
> 
> How about "type".

Ooops, indeed. Same exact issue. I'll update the patch.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2016-12-14 22:59   ` Darren Hart
@ 2016-12-15  0:02     ` Stephen Rothwell
  2016-12-15  4:07       ` Darren Hart
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2016-12-15  0:02 UTC (permalink / raw)
  To: Darren Hart
  Cc: linux-next, linux-kernel, Lyude, Henrique de Moraes Holschuh,
	Andy Shevchenko

Hi Darren,

On Wed, 14 Dec 2016 14:59:14 -0800 Darren Hart <dvhart@infradead.org> wrote:
>
> On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> > On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:  
> > > 
> > > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > > allmodconfig) produced this warning:
> > > 
> > > In file included from include/linux/kernel.h:13:0,
> > >                  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > >   ^
> > > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
> > >   char *type;
> > >         ^
> > > In file included from include/linux/kernel.h:13:0,
> > >                  from drivers/platform/x86/thinkpad_acpi.c:52:
> > > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> > >   ^
> > > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was declared here
> > >   int in_tablet_mode, res;
> > >       ^
> > > 
> > > Introduced by commit
> > > 
> > >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")
> > > 
> > > I can't tell if this is a false positive or not.  
> > 
> > That's an uninitialized local variable. Not sure how I missed that. I'll
> > fix it up today. Thank you for the report.  
> 
> OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
> both places where in_tablet_mode is assigned, and if the former is 0 (global
> scope), the function returns without calling pr_info.

How about "type".

> Lyude, Henrique, please confirm.
> 
> Regardless, I'll add a patch to init in_tablet_mode to 0 so it is explicit - but
> will not rebase as it isn't technically an error.

No problem, it is only a warning after all.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2016-12-14 22:21 ` Darren Hart
@ 2016-12-14 22:59   ` Darren Hart
  2016-12-15  0:02     ` Stephen Rothwell
  0 siblings, 1 reply; 30+ messages in thread
From: Darren Hart @ 2016-12-14 22:59 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Lyude, Henrique de Moraes Holschuh,
	Andy Shevchenko

On Wed, Dec 14, 2016 at 02:21:38PM -0800, Darren Hart wrote:
> On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:
> > Hi Darren,
> > 
> > After merging the drivers-x86 tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> > 
> > In file included from include/linux/kernel.h:13:0,
> >                  from drivers/platform/x86/thinkpad_acpi.c:52:
> > drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> > include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >   ^
> > drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
> >   char *type;
> >         ^
> > In file included from include/linux/kernel.h:13:0,
> >                  from drivers/platform/x86/thinkpad_acpi.c:52:
> > include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> >   ^
> > drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was declared here
> >   int in_tablet_mode, res;
> >       ^
> > 
> > Introduced by commit
> > 
> >   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")
> > 
> > I can't tell if this is a false positive or not.
> 
> That's an uninitialized local variable. Not sure how I missed that. I'll
> fix it up today. Thank you for the report.

OK, no, it's a false positive because tp_features.hotkey_tablet is assigned in
both places where in_tablet_mode is assigned, and if the former is 0 (global
scope), the function returns without calling pr_info.

Lyude, Henrique, please confirm.

Regardless, I'll add a patch to init in_tablet_mode to 0 so it is explicit - but
will not rebase as it isn't technically an error.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2016-12-14  2:50 Stephen Rothwell
@ 2016-12-14 22:21 ` Darren Hart
  2016-12-14 22:59   ` Darren Hart
  0 siblings, 1 reply; 30+ messages in thread
From: Darren Hart @ 2016-12-14 22:21 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: linux-next, linux-kernel, Lyude, Henrique de Moraes Holschuh,
	Andy Shevchenko

On Wed, Dec 14, 2016 at 01:50:44PM +1100, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from include/linux/kernel.h:13:0,
>                  from drivers/platform/x86/thinkpad_acpi.c:52:
> drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
> include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>   ^
> drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
>   char *type;
>         ^
> In file included from include/linux/kernel.h:13:0,
>                  from drivers/platform/x86/thinkpad_acpi.c:52:
> include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
>   ^
> drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was declared here
>   int in_tablet_mode, res;
>       ^
> 
> Introduced by commit
> 
>   b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")
> 
> I can't tell if this is a false positive or not.

That's an uninitialized local variable. Not sure how I missed that. I'll
fix it up today. Thank you for the report.

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the drivers-x86 tree
@ 2016-12-14  2:50 Stephen Rothwell
  2016-12-14 22:21 ` Darren Hart
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2016-12-14  2:50 UTC (permalink / raw)
  To: Darren Hart; +Cc: linux-next, linux-kernel, Lyude, Henrique de Moraes Holschuh

Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/kernel.h:13:0,
                 from drivers/platform/x86/thinkpad_acpi.c:52:
drivers/platform/x86/thinkpad_acpi.c: In function 'hotkey_init':
include/linux/printk.h:299:2: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
  ^
drivers/platform/x86/thinkpad_acpi.c:3147:8: note: 'type' was declared here
  char *type;
        ^
In file included from include/linux/kernel.h:13:0,
                 from drivers/platform/x86/thinkpad_acpi.c:52:
include/linux/printk.h:299:2: warning: 'in_tablet_mode' may be used uninitialized in this function [-Wmaybe-uninitialized]
  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
  ^
drivers/platform/x86/thinkpad_acpi.c:3146:6: note: 'in_tablet_mode' was declared here
  int in_tablet_mode, res;
      ^

Introduced by commit

  b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into separate function")

I can't tell if this is a false positive or not.

-- 
Cheers,
Stephen Rothwell

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2010-08-27  7:40   ` Dmitry Torokhov
@ 2010-08-30  2:51     ` Stephen Rothwell
  0 siblings, 0 replies; 30+ messages in thread
From: Stephen Rothwell @ 2010-08-30  2:51 UTC (permalink / raw)
  To: Matthew Garrett, Dmitry Torokhov; +Cc: linux-next, linux-kernel

Hi all,

On Fri, 27 Aug 2010 00:40:48 -0700 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
>
> On Fri, Aug 27, 2010 at 03:51:48AM +0100, Matthew Garrett wrote:
> > On Fri, Aug 27, 2010 at 11:59:50AM +1000, Stephen Rothwell wrote:
> > 
> > > After merging the drivers-x86 tree, today's linux-next build (powerpc
> > > ppc64_defconfig and x86_64 allmodconfig) produced this warning:
> > 
> > Oh Lordy. I should stop merging anything that contains "select". I'll 
> > take a look at this tomorrow, but I'm about to head away for a week - if 
> > anyone has a fix, feel free to find a way to get it merged.
> > 
> > (Dmitry, there was a Kconfig issue when I merged your patch, so it's 
> > entirely plausible that you're a completely innocent bystander here)
> 
> Yeah, I think I am innocent here. My patch was adding "select
> INPUT_SPARCEKMAP" which is a library module and which I ensure to be
> selectable as long as INPUT is enabled. I do not want to switch it
> around into "depends on" since it is implementation detail and user
> should not care.

I applied this patch for today ...

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 30 Aug 2010 12:47:51 +1000
Subject: [PATCH] Fix Kconfig mistaken update

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/platform/x86/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index b96db80..55579f1 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -497,7 +497,6 @@ config ACPI_TOSHIBA
 	depends on RFKILL || RFKILL = n
 	select INPUT_POLLDEV
 	select INPUT_SPARSEKMAP
-	select BACKLIGHT_CLASS_DEVICE
 	---help---
 	  This driver adds support for access to certain system settings
 	  on "legacy free" Toshiba laptops.  These laptops can be recognized by
-- 
1.7.1


-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2010-08-27  2:51 ` Matthew Garrett
@ 2010-08-27  7:40   ` Dmitry Torokhov
  2010-08-30  2:51     ` Stephen Rothwell
  0 siblings, 1 reply; 30+ messages in thread
From: Dmitry Torokhov @ 2010-08-27  7:40 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: Stephen Rothwell, linux-next, linux-kernel

On Fri, Aug 27, 2010 at 03:51:48AM +0100, Matthew Garrett wrote:
> On Fri, Aug 27, 2010 at 11:59:50AM +1000, Stephen Rothwell wrote:
> 
> > After merging the drivers-x86 tree, today's linux-next build (powerpc
> > ppc64_defconfig and x86_64 allmodconfig) produced this warning:
> 
> Oh Lordy. I should stop merging anything that contains "select". I'll 
> take a look at this tomorrow, but I'm about to head away for a week - if 
> anyone has a fix, feel free to find a way to get it merged.
> 
> (Dmitry, there was a Kconfig issue when I merged your patch, so it's 
> entirely plausible that you're a completely innocent bystander here)

Yeah, I think I am innocent here. My patch was adding "select
INPUT_SPARCEKMAP" which is a library module and which I ensure to be
selectable as long as INPUT is enabled. I do not want to switch it
around into "depends on" since it is implementation detail and user
should not care.

Thanks.

-- 
Dmitry

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2010-08-27  1:59 Stephen Rothwell
@ 2010-08-27  2:51 ` Matthew Garrett
  2010-08-27  7:40   ` Dmitry Torokhov
  0 siblings, 1 reply; 30+ messages in thread
From: Matthew Garrett @ 2010-08-27  2:51 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Dmitry Torokhov

On Fri, Aug 27, 2010 at 11:59:50AM +1000, Stephen Rothwell wrote:

> After merging the drivers-x86 tree, today's linux-next build (powerpc
> ppc64_defconfig and x86_64 allmodconfig) produced this warning:

Oh Lordy. I should stop merging anything that contains "select". I'll 
take a look at this tomorrow, but I'm about to head away for a week - if 
anyone has a fix, feel free to find a way to get it merged.

(Dmitry, there was a Kconfig issue when I merged your patch, so it's 
entirely plausible that you're a completely innocent bystander here)

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the drivers-x86 tree
@ 2010-08-27  1:59 Stephen Rothwell
  2010-08-27  2:51 ` Matthew Garrett
  0 siblings, 1 reply; 30+ messages in thread
From: Stephen Rothwell @ 2010-08-27  1:59 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-next, linux-kernel, Dmitry Torokhov

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (powerpc
ppc64_defconfig and x86_64 allmodconfig) produced this warning:

drivers/video/backlight/Kconfig:117:error: recursive dependency detected!
drivers/video/backlight/Kconfig:117:	symbol BACKLIGHT_CLASS_DEVICE is selected by ACPI_TOSHIBA
drivers/platform/x86/Kconfig:490:	symbol ACPI_TOSHIBA depends on LEDS_CLASS
drivers/leds/Kconfig:12:	symbol LEDS_CLASS is selected by BACKLIGHT_ADP8860
drivers/video/backlight/Kconfig:285:	symbol BACKLIGHT_ADP8860 depends on BACKLIGHT_CLASS_DEVICE

Introduced by commit af7ad65329f59cdfdd564ec26148160ed42a8b70
("toshiba-acpi - switch to using sparse keymap")
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2010-06-25  3:41 ` Matthew Garrett
@ 2010-06-25  4:16   ` Stephen Rothwell
  0 siblings, 0 replies; 30+ messages in thread
From: Stephen Rothwell @ 2010-06-25  4:16 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-next, linux-kernel, Alan Cox, Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

Hi Matthew,

On Fri, 25 Jun 2010 04:41:41 +0100 Matthew Garrett <mjg59@srcf.ucam.org> wrote:
>
> On Fri, Jun 25, 2010 at 01:25:45PM +1000, Stephen Rothwell wrote:
> 
> > RAR_REGISTER is also still defined in
> > drivers/staging/rar_register/Kconfig ...  Also, that commit did not move
> > intel_rar_register.c from staging ...
> 
> Sorry, I managed to utterly novice git. Fixed tree pushed.

Thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2010-06-25  3:25 Stephen Rothwell
  2010-06-25  3:31 ` Matthew Garrett
@ 2010-06-25  3:41 ` Matthew Garrett
  2010-06-25  4:16   ` Stephen Rothwell
  1 sibling, 1 reply; 30+ messages in thread
From: Matthew Garrett @ 2010-06-25  3:41 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Alan Cox, Greg Kroah-Hartman

On Fri, Jun 25, 2010 at 01:25:45PM +1000, Stephen Rothwell wrote:

> RAR_REGISTER is also still defined in
> drivers/staging/rar_register/Kconfig ...  Also, that commit did not move
> intel_rar_register.c from staging ...

Sorry, I managed to utterly novice git. Fixed tree pushed.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 30+ messages in thread

* Re: linux-next: build warning after merge of the drivers-x86 tree
  2010-06-25  3:25 Stephen Rothwell
@ 2010-06-25  3:31 ` Matthew Garrett
  2010-06-25  3:41 ` Matthew Garrett
  1 sibling, 0 replies; 30+ messages in thread
From: Matthew Garrett @ 2010-06-25  3:31 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Alan Cox, Greg Kroah-Hartman

On Fri, Jun 25, 2010 at 01:25:45PM +1000, Stephen Rothwell wrote:

> RAR_REGISTER is also still defined in
> drivers/staging/rar_register/Kconfig ...  Also, that commit did not move
> intel_rar_register.c from staging ...

Bother. I'll fix that up.

Thanks,
-- 
Matthew Garrett | mjg59@srcf.ucam.org

^ permalink raw reply	[flat|nested] 30+ messages in thread

* linux-next: build warning after merge of the drivers-x86 tree
@ 2010-06-25  3:25 Stephen Rothwell
  2010-06-25  3:31 ` Matthew Garrett
  2010-06-25  3:41 ` Matthew Garrett
  0 siblings, 2 replies; 30+ messages in thread
From: Stephen Rothwell @ 2010-06-25  3:25 UTC (permalink / raw)
  To: Matthew Garrett; +Cc: linux-next, linux-kernel, Alan Cox, Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

Hi Matthew,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/Kconfig:542:warning: type of 'RAR_REGISTER' redefined from 'tristate' to 'boolean'

Caused by commit b8fd1646cc932c911c4d836f7fd9624c05722a2d ("rar: Move the
RAR driver into the right place as its now clean").

RAR_REGISTER is also still defined in
drivers/staging/rar_register/Kconfig ...  Also, that commit did not move
intel_rar_register.c from staging ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, back to index

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 23:35 linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell
2020-02-10 23:39 ` Kammela, Gayatri
2020-02-11 21:07 ` Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2020-01-10  3:57 Stephen Rothwell
2020-01-10  9:47 ` Andy Shevchenko
2017-06-30  4:00 Stephen Rothwell
2017-06-30  5:12 ` Arvind Yadav
2017-07-01  3:32 ` Darren Hart
2017-05-19  3:23 Stephen Rothwell
2017-05-19 22:09 ` Darren Hart
2017-05-22 18:03   ` Andy Shevchenko
2017-05-25 23:34     ` Stephen Rothwell
2017-05-26  8:25       ` Arnd Bergmann
2017-05-26  8:35         ` Stephen Rothwell
2017-05-26  9:04           ` Andy Shevchenko
2017-05-26  9:07             ` Stephen Rothwell
2017-05-26  9:52               ` Andy Shevchenko
2016-12-14  2:50 Stephen Rothwell
2016-12-14 22:21 ` Darren Hart
2016-12-14 22:59   ` Darren Hart
2016-12-15  0:02     ` Stephen Rothwell
2016-12-15  4:07       ` Darren Hart
2010-08-27  1:59 Stephen Rothwell
2010-08-27  2:51 ` Matthew Garrett
2010-08-27  7:40   ` Dmitry Torokhov
2010-08-30  2:51     ` Stephen Rothwell
2010-06-25  3:25 Stephen Rothwell
2010-06-25  3:31 ` Matthew Garrett
2010-06-25  3:41 ` Matthew Garrett
2010-06-25  4:16   ` Stephen Rothwell

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git