Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: build failure after merge of the compiler-attributes tree
@ 2019-08-29 22:52 Stephen Rothwell
  2019-08-29 22:53 ` Nick Desaulniers
  2019-08-29 22:54 ` Miguel Ojeda
  0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2019-08-29 22:52 UTC (permalink / raw)
  To: Miguel Ojeda
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Nick Desaulniers, Josh Poimboeuf, Sedat Dilek

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

Hi all,

After merging the compiler-attributes tree, today's linux-next build
(powerpc ppc64_defconfig) failed like this:

arch/powerpc/boot/main.c:153:45: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__section'
  153 | static char cmdline[BOOT_COMMAND_LINE_SIZE] __section(__builtin_cmdline);
      |                                             ^~~~~~~~~
arch/powerpc/boot/main.c: In function 'prep_cmdline':
arch/powerpc/boot/main.c:166:6: error: 'cmdline' undeclared (first use in this function)
  166 |  if (cmdline[0] == '\0')
      |      ^~~~~~~
arch/powerpc/boot/main.c:166:6: note: each undeclared identifier is reported only once for each function it appears in
arch/powerpc/boot/main.c: In function 'start':
arch/powerpc/boot/main.c:196:40: error: 'cmdline' undeclared (first use in this function)
  196 |  if ((loader_info.cmdline_len > 0) && (cmdline[0] == '\0'))
      |                                        ^~~~~~~

Caused by commit

  e81c903fb9e2 ("powerpc: prefer __section and __printf from compiler_attributes.h")

I have reverted that commit for today.

gcc v9.2.1 (in case that matters)

The above error is from the PowerPC boot wrapper that is built without
the kernel headers (mainly, I think).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the compiler-attributes tree
  2019-08-29 22:52 linux-next: build failure after merge of the compiler-attributes tree Stephen Rothwell
@ 2019-08-29 22:53 ` Nick Desaulniers
  2019-08-29 22:54 ` Miguel Ojeda
  1 sibling, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2019-08-29 22:53 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Miguel Ojeda, Linux Next Mailing List, Linux Kernel Mailing List,
	Josh Poimboeuf, Sedat Dilek

Thanks for the report, Miguel and I decided to drop the patch.

On Thu, Aug 29, 2019 at 3:52 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the compiler-attributes tree, today's linux-next build
> (powerpc ppc64_defconfig) failed like this:
>
> arch/powerpc/boot/main.c:153:45: error: expected '=', ',', ';', 'asm' or '__attribute__' before '__section'
>   153 | static char cmdline[BOOT_COMMAND_LINE_SIZE] __section(__builtin_cmdline);
>       |                                             ^~~~~~~~~
> arch/powerpc/boot/main.c: In function 'prep_cmdline':
> arch/powerpc/boot/main.c:166:6: error: 'cmdline' undeclared (first use in this function)
>   166 |  if (cmdline[0] == '\0')
>       |      ^~~~~~~
> arch/powerpc/boot/main.c:166:6: note: each undeclared identifier is reported only once for each function it appears in
> arch/powerpc/boot/main.c: In function 'start':
> arch/powerpc/boot/main.c:196:40: error: 'cmdline' undeclared (first use in this function)
>   196 |  if ((loader_info.cmdline_len > 0) && (cmdline[0] == '\0'))
>       |                                        ^~~~~~~
>
> Caused by commit
>
>   e81c903fb9e2 ("powerpc: prefer __section and __printf from compiler_attributes.h")
>
> I have reverted that commit for today.
>
> gcc v9.2.1 (in case that matters)
>
> The above error is from the PowerPC boot wrapper that is built without
> the kernel headers (mainly, I think).
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the compiler-attributes tree
  2019-08-29 22:52 linux-next: build failure after merge of the compiler-attributes tree Stephen Rothwell
  2019-08-29 22:53 ` Nick Desaulniers
@ 2019-08-29 22:54 ` Miguel Ojeda
  2019-08-29 22:58   ` Miguel Ojeda
  1 sibling, 1 reply; 6+ messages in thread
From: Miguel Ojeda @ 2019-08-29 22:54 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Nick Desaulniers, Josh Poimboeuf, Sedat Dilek

On Fri, Aug 30, 2019 at 12:52 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Caused by commit
>
>   e81c903fb9e2 ("powerpc: prefer __section and __printf from compiler_attributes.h")
>
> I have reverted that commit for today.
>
> gcc v9.2.1 (in case that matters)
>
> The above error is from the PowerPC boot wrapper that is built without
> the kernel headers (mainly, I think).

Yeah, we just saw it, I was about to drop it from the queue. It is
indeed because we don't have those __* defines within the compilation
environment of the kernel.

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the compiler-attributes tree
  2019-08-29 22:54 ` Miguel Ojeda
@ 2019-08-29 22:58   ` Miguel Ojeda
  0 siblings, 0 replies; 6+ messages in thread
From: Miguel Ojeda @ 2019-08-29 22:58 UTC (permalink / raw)
  To: Stephen Rothwell
  Cc: Linux Next Mailing List, Linux Kernel Mailing List,
	Nick Desaulniers, Josh Poimboeuf, Sedat Dilek

On Fri, Aug 30, 2019 at 12:54 AM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> Yeah, we just saw it, I was about to drop it from the queue. It is
> indeed because we don't have those __* defines within the compilation
> environment of the kernel.

Dropped!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the compiler-attributes tree
  2019-02-06 21:30 Stephen Rothwell
@ 2019-02-06 21:48 ` Miguel Ojeda
  0 siblings, 0 replies; 6+ messages in thread
From: Miguel Ojeda @ 2019-02-06 21:48 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

Hi Stephen,

On Wed, Feb 6, 2019 at 10:31 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Miguel,
>
> After merging the compiler-attributes tree, today's linux-next build
> (arm multi_v7_defconfig) failed like this:
>
> In file included from arch/arm/crypto/aes-neonbs-glue.c:17:
> include/linux/module.h:138:7: error: section of alias 'cleanup_module' must match section of its target
>   void cleanup_module(void) __exit __attribute__((alias(#exitfn)));
>        ^~~~~~~~~~~~~~
> arch/arm/crypto/aes-neonbs-glue.c:433:1: note: in expansion of macro 'module_exit'
>  module_exit(aes_exit);
>  ^~~~~~~~~~~
>
> Caused by commit
>
>   b31ca3fcca36 ("include/linux/module.h: mark init/cleanup_module aliases as __init/exit")
>
> I have used the compiler-attributes tree from next-20190206 for today.

Yeah, sorry about that! I saw it an hour ago from the build bot and
already took out the branch from -next.

I tested the change on a subset of modules before pushing, but it
turns out there are some modules that do not mark their functions with
__init/__exit and that, in turns, makes GCC complain.

I sent a message about it a few minutes ago:
https://lore.kernel.org/lkml/CANiq72=gS7=G6WbZ4jqybMBh44FeF7UeVEfeb1hN8uMAMt_2bw@mail.gmail.com/

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: build failure after merge of the compiler-attributes tree
@ 2019-02-06 21:30 Stephen Rothwell
  2019-02-06 21:48 ` Miguel Ojeda
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2019-02-06 21:30 UTC (permalink / raw)
  To: Miguel Ojeda; +Cc: Linux Next Mailing List, Linux Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

Hi Miguel,

After merging the compiler-attributes tree, today's linux-next build
(arm multi_v7_defconfig) failed like this:

In file included from arch/arm/crypto/aes-neonbs-glue.c:17:
include/linux/module.h:138:7: error: section of alias 'cleanup_module' must match section of its target
  void cleanup_module(void) __exit __attribute__((alias(#exitfn)));
       ^~~~~~~~~~~~~~
arch/arm/crypto/aes-neonbs-glue.c:433:1: note: in expansion of macro 'module_exit'
 module_exit(aes_exit);
 ^~~~~~~~~~~

Caused by commit

  b31ca3fcca36 ("include/linux/module.h: mark init/cleanup_module aliases as __init/exit")

I have used the compiler-attributes tree from next-20190206 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-29 22:52 linux-next: build failure after merge of the compiler-attributes tree Stephen Rothwell
2019-08-29 22:53 ` Nick Desaulniers
2019-08-29 22:54 ` Miguel Ojeda
2019-08-29 22:58   ` Miguel Ojeda
  -- strict thread matches above, loose matches on Subject: below --
2019-02-06 21:30 Stephen Rothwell
2019-02-06 21:48 ` Miguel Ojeda

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org linux-next@archiver.kernel.org
	public-inbox-index linux-next


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/ public-inbox