From: Chao Yu <yuchao0@huawei.com> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Jens Axboe <axboe@kernel.dk>, Linux Next Mailing List <linux-next@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Christoph Hellwig <hch@lst.de> Subject: Re: linux-next: build warning after merge of the block tree Date: Fri, 19 Apr 2019 09:14:06 +0800 Message-ID: <b2bc71fb-c11e-8939-daea-facbb5980742@huawei.com> (raw) In-Reply-To: <20190418140104.GA52314@jaegeuk-macbookpro.roam.corp.google.com> On 2019/4/18 22:01, Jaegeuk Kim wrote: > On 04/18, Chao Yu wrote: >> On 2019/4/17 22:03, Jaegeuk Kim wrote: >>> On 04/17, Chao Yu wrote: >>>> Hi Jaegeuk, >>>> >>>> On 2019/4/17 10:31, Stephen Rothwell wrote: >>>>> Hi all, >>>>> >>>>> After merging the block tree, today's linux-next build (x86_64 >>>>> allmodconfig) produced this warning: >>>>> >>>>> fs/f2fs/node.c: In function 'f2fs_remove_inode_page': >>>>> fs/f2fs/node.c:1193:47: warning: format '%zu' expects argument of type 'size_t', but argument 5 has type 'blkcnt_t' {aka 'long long unsigned int'} [-Wformat=] >>>>> "Inconsistent i_blocks, ino:%lu, iblocks:%zu", >>>>> ~~^ >>>>> %llu >>>>> inode->i_ino, inode->i_blocks); >>>>> ~~~~~~~~~~~~~~~ >>>> >>>> Could you please help to fix that as below in your dev branch directly? >>>> >>>> "Inconsistent i_blocks, ino:%lu, iblocks:%llu", >>> >>> We can just use "%lu"? >> >> We'd better follow sample in Documentation/core-api/printk-formats.rst: >> >> If <type> is dependent on a config option for its size (e.g., sector_t, >> blkcnt_t) or is architecture-dependent for its size (e.g., tcflag_t), use a >> format specifier of its largest possible type and explicitly cast to it. > > Great, done. :) Thanks, :) > > Thanks, > >> >> Example:: >> >> printk("test: sector number/total blocks: %llu/%llu\n", >> (unsigned long long)sector, (unsigned long long)blockcount); >> >> Thanks, >> >>> >>>> inode->i_ino, (unsigned long long)inode->i_blocks) >>>> >>>> >>>> It looks that we need to fix below commits as well: >>>> >>>> f2fs: fix to avoid panic in dec_valid_block_count() >>>> f2fs: fix to avoid panic in dec_valid_node_count() >>>> >>>> Thanks, >>>> >>>>> >>>>> Introduced by commit >>>>> >>>>> 90ae238d9dac ("f2fs: fix to avoid panic in f2fs_remove_inode_page()") >>>>> >>>>> from the f2fs tree interacting with commit >>>>> >>>>> 72deb455b5ec ("block: remove CONFIG_LBDAF") >>>>> >>> . >>> > . >
next prev parent reply index Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-17 2:31 Stephen Rothwell 2019-04-17 10:05 ` Chao Yu 2019-04-17 14:03 ` Jaegeuk Kim 2019-04-18 0:57 ` Chao Yu 2019-04-18 14:01 ` Jaegeuk Kim 2019-04-19 1:14 ` Chao Yu [this message] -- strict thread matches above, loose matches on Subject: below -- 2020-12-22 23:47 Stephen Rothwell 2020-12-23 0:13 ` Jens Axboe 2020-12-07 7:48 Stephen Rothwell 2020-12-03 7:39 Stephen Rothwell 2020-12-14 20:14 ` Stephen Rothwell 2020-12-21 1:30 ` Stephen Rothwell 2020-12-03 7:37 Stephen Rothwell 2020-12-14 20:13 ` Stephen Rothwell 2020-12-21 1:29 ` Stephen Rothwell 2020-11-12 4:32 Stephen Rothwell 2020-10-22 23:48 Stephen Rothwell 2020-10-23 0:30 ` Jens Axboe 2020-07-02 1:21 Stephen Rothwell 2020-07-02 4:07 ` Jens Axboe 2020-03-04 2:17 Stephen Rothwell 2020-03-04 3:01 ` Jens Axboe 2020-03-04 12:50 ` Pavel Begunkov 2020-01-31 0:16 Stephen Rothwell 2020-01-31 0:25 ` Jens Axboe 2020-01-16 0:54 Stephen Rothwell 2020-01-16 4:50 ` Jens Axboe 2019-10-18 0:51 Stephen Rothwell 2019-10-18 0:56 ` Jens Axboe 2019-10-18 0:59 ` Jens Axboe 2019-10-18 3:58 ` Stephen Rothwell 2019-08-29 3:51 Stephen Rothwell 2019-08-29 4:08 ` Stephen Rothwell 2019-08-29 15:41 ` Tejun Heo 2019-08-29 15:44 ` Jens Axboe 2019-08-09 4:00 Stephen Rothwell 2019-08-09 4:13 ` Jens Axboe 2019-08-09 6:15 ` Yuehaibing 2018-11-08 3:31 Stephen Rothwell 2018-11-08 4:19 ` Jens Axboe 2018-09-28 1:11 Stephen Rothwell 2018-09-28 6:43 ` Omar Sandoval 2018-09-28 14:26 ` Jens Axboe 2018-05-31 3:49 Stephen Rothwell 2018-05-14 2:51 Stephen Rothwell 2018-05-14 8:29 ` Christoph Hellwig 2018-05-14 14:31 ` Jens Axboe 2017-05-10 1:24 Stephen Rothwell 2017-05-10 2:20 ` Markus Trippelsdorf 2017-05-10 3:00 ` Jens Axboe 2017-05-10 6:19 ` Markus Trippelsdorf 2017-05-10 3:26 ` Stephen Rothwell 2014-10-23 1:28 Stephen Rothwell 2014-10-23 2:14 ` Jens Axboe 2013-09-23 4:29 Stephen Rothwell 2011-05-09 3:49 Stephen Rothwell 2011-05-09 5:55 ` Tao Ma 2011-05-09 6:34 ` Jens Axboe 2010-12-20 4:31 Stephen Rothwell 2010-12-20 4:42 ` Stephen Rothwell 2010-12-20 8:12 ` Jens Axboe 2010-09-16 3:30 Stephen Rothwell 2010-04-29 6:14 Stephen Rothwell 2010-04-29 7:28 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b2bc71fb-c11e-8939-daea-facbb5980742@huawei.com \ --to=yuchao0@huawei.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=jaegeuk@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Next Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \ linux-next@vger.kernel.org public-inbox-index linux-next Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next AGPL code for this site: git clone https://public-inbox.org/public-inbox.git