Linux-Next Archive on lore.kernel.org
 help / color / Atom feed
* linux-next: Fixes tag needs some work in the kvm tree
@ 2021-04-16 12:27 Stephen Rothwell
  2021-04-16 12:38 ` Christian Borntraeger
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-04-16 12:27 UTC (permalink / raw)
  To: Paolo Bonzini, KVM
  Cc: Claudio Imbrenda, Christian Borntraeger,
	Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

Hi all,

In commit

  c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and MSO")

Fixes tag

  Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in VSIE")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: Fixes tag needs some work in the kvm tree
  2021-04-16 12:27 linux-next: Fixes tag needs some work in the kvm tree Stephen Rothwell
@ 2021-04-16 12:38 ` Christian Borntraeger
  2021-04-16 14:02   ` Paolo Bonzini
  0 siblings, 1 reply; 11+ messages in thread
From: Christian Borntraeger @ 2021-04-16 12:38 UTC (permalink / raw)
  To: Stephen Rothwell, Paolo Bonzini, KVM
  Cc: Claudio Imbrenda, Linux Kernel Mailing List, Linux Next Mailing List

On 16.04.21 14:27, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and MSO")
> 
> Fixes tag
> 
>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in VSIE")
> 
> has these problem(s):
> 
>    - Subject does not match target commit subject
>      Just use
> 	git log -1 --format='Fixes: %h ("%s")'

Hmm, this has been sitting in kvms390/next for some time now. Is this a new check?

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: Fixes tag needs some work in the kvm tree
  2021-04-16 12:38 ` Christian Borntraeger
@ 2021-04-16 14:02   ` Paolo Bonzini
  2021-04-16 14:58     ` Stephen Rothwell
  0 siblings, 1 reply; 11+ messages in thread
From: Paolo Bonzini @ 2021-04-16 14:02 UTC (permalink / raw)
  To: Christian Borntraeger, Stephen Rothwell, KVM
  Cc: Claudio Imbrenda, Linux Kernel Mailing List, Linux Next Mailing List

On 16/04/21 14:38, Christian Borntraeger wrote:
> On 16.04.21 14:27, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and 
>> MSO")
>>
>> Fixes tag
>>
>>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in 
>> VSIE")
>>
>> has these problem(s):
>>
>>    - Subject does not match target commit subject
>>      Just use
>>     git log -1 --format='Fixes: %h ("%s")'
> 
> Hmm, this has been sitting in kvms390/next for some time now. Is this a 
> new check?
> 

Maybe you just missed it when it was reported for kvms390?

https://www.spinics.net/lists/linux-next/msg59652.html

The SHA1 is stable now so it's too late.  It's not a big deal I guess.

Paolo


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: Fixes tag needs some work in the kvm tree
  2021-04-16 14:02   ` Paolo Bonzini
@ 2021-04-16 14:58     ` Stephen Rothwell
  2021-04-16 15:02       ` Christian Borntraeger
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2021-04-16 14:58 UTC (permalink / raw)
  To: Paolo Bonzini
  Cc: Christian Borntraeger, KVM, Claudio Imbrenda,
	Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

Hi all,

On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 16/04/21 14:38, Christian Borntraeger wrote:
> > On 16.04.21 14:27, Stephen Rothwell wrote:  
> >> Hi all,
> >>
> >> In commit
> >>
> >>    c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and >> MSO")
> >>
> >> Fixes tag
> >>
> >>    Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in >> VSIE")
> >>
> >> has these problem(s):
> >>
> >>    - Subject does not match target commit subject
> >>      Just use
> >>     git log -1 --format='Fixes: %h ("%s")'  
> > 
> > Hmm, this has been sitting in kvms390/next for some time now. Is this a > new check?
> >   
> 
> Maybe you just missed it when it was reported for kvms390?
> 
> https://www.spinics.net/lists/linux-next/msg59652.html

It was a different commit SHA then and was reported because the Fixes
SHA did not exist.  It was fixed the next day, so I guess either I
missed reporting this different problem, or I thought at least it had
been fixed to use the correct SHA.  I am not completely consistent,
sometimes :-)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: Fixes tag needs some work in the kvm tree
  2021-04-16 14:58     ` Stephen Rothwell
@ 2021-04-16 15:02       ` Christian Borntraeger
  0 siblings, 0 replies; 11+ messages in thread
From: Christian Borntraeger @ 2021-04-16 15:02 UTC (permalink / raw)
  To: Stephen Rothwell, Paolo Bonzini
  Cc: KVM, Claudio Imbrenda, Linux Kernel Mailing List,
	Linux Next Mailing List



On 16.04.21 16:58, Stephen Rothwell wrote:
> Hi all,
> 
> On Fri, 16 Apr 2021 16:02:01 +0200 Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 16/04/21 14:38, Christian Borntraeger wrote:
>>> On 16.04.21 14:27, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> In commit
>>>>
>>>>     c3171e94cc1c ("KVM: s390: VSIE: fix MVPG handling for prefixing and >> MSO")
>>>>
>>>> Fixes tag
>>>>
>>>>     Fixes: bdf7509bbefa ("s390/kvm: VSIE: correctly handle MVPG when in >> VSIE")
>>>>
>>>> has these problem(s):
>>>>
>>>>     - Subject does not match target commit subject
>>>>       Just use
>>>>      git log -1 --format='Fixes: %h ("%s")'
>>>
>>> Hmm, this has been sitting in kvms390/next for some time now. Is this a > new check?
>>>    
>>
>> Maybe you just missed it when it was reported for kvms390?
>>
>> https://www.spinics.net/lists/linux-next/msg59652.html
> 
> It was a different commit SHA then and was reported because the Fixes
> SHA did not exist.  It was fixed the next day, so I guess either I
> missed reporting this different problem, or I thought at least it had
> been fixed to use the correct SHA.  I am not completely consistent,
> sometimes :-)

Yeah, seems that my fix was only half-way correct then but it managed to get past your review.

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: Fixes tag needs some work in the kvm tree
@ 2021-02-04 20:16 Stephen Rothwell
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2021-02-04 20:16 UTC (permalink / raw)
  To: Paolo Bonzini, KVM
  Cc: Ben Gardon, Linux Kernel Mailing List, Linux Next Mailing List


[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

Hi all,

In commit

  f1b3b06a058b ("KVM: x86/mmu: Clear dirtied pages mask bit before early break")

Fixes tag

  Fixes: a6a0b05da9f3 ("kvm: x86/mmu: Support dirty logging for the TDP

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Also, keep all
the commit message tags together at the end of the message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: Fixes tag needs some work in the kvm tree
@ 2020-03-16 20:36 Stephen Rothwell
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2020-03-16 20:36 UTC (permalink / raw)
  To: Paolo Bonzini, Radim Krčmář, KVM
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sean Christopherson


[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi all,

In commit

  abbed4fa94f6 ("KVM: x86: Fix warning due to implicit truncation on 32-bit KVM")

Fixes tag

  Fixes: a3e967c0b87d3 ("KVM: Terminate memslot walks via used_slots"

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 0577d1abe704 ("KVM: Terminate memslot walks via used_slots")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: Fixes tag needs some work in the kvm tree
@ 2020-01-24  3:13 Stephen Rothwell
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2020-01-24  3:13 UTC (permalink / raw)
  To: Paolo Bonzini, Radim Krčmář, KVM
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Sean Christopherson


[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

Hi all,

In commit

  90bbff59a2fb ("KVM: x86/mmu: Enforce max_level on HugeTLB mappings")

Fixes tag

  Fixes: ad163aa8903d ("KVM: x86/mmu: Persist gfn_lpage_is_disallowed() to max_level")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 2f57b7051fe8 ("KVM: x86/mmu: Persist gfn_lpage_is_disallowed() to max_level")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: Fixes tag needs some work in the kvm tree
@ 2019-12-04 12:50 Stephen Rothwell
  0 siblings, 0 replies; 11+ messages in thread
From: Stephen Rothwell @ 2019-12-04 12:50 UTC (permalink / raw)
  To: Paolo Bonzini, Radim Krčmář, KVM
  Cc: Linux Next Mailing List, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

Hi all,

In commit

  433f4ba19041 ("KVM: x86: fix out-of-bounds write in KVM_GET_EMULATED_CPUID (CVE-2019-19332)")

Fixes tag

  Fixes: 84cffe499b94 ("kvm: Emulate MOVBE", 2013-10-29)

has these problem(s):

  - Unexpected trailing date
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: linux-next: Fixes tag needs some work in the kvm tree
  2019-02-16  7:34 Stephen Rothwell
@ 2019-02-20  7:02 ` Yu Zhang
  0 siblings, 0 replies; 11+ messages in thread
From: Yu Zhang @ 2019-02-20  7:02 UTC (permalink / raw)
  To: Stephen Rothwell, Paolo Bonzini
  Cc: Radim Krčmář,
	KVM, Linux Next Mailing List, Linux Kernel Mailing List,
	Sean Christopherson

Thanks for the notification, Stephen.
@Paolo, should I resubmit the patch to correct?

On Sat, Feb 16, 2019 at 06:34:33PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   aa8359972cfc ("KVM: x86/mmu: Differentiate between nr zapped and list unstable")
> 
> Fixes tag
> 
>   Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return
> 
> has these problem(s):
> 
>   - Subject has leading but no trailing quotes
>     Please do not split Fixes tags over more than one line
> 
> In commit
> 
>   4d3f8e4ff75e ("kvm: vmx: Fix typos in vmentry/vmexit control setting")
> 
> Fixes tag
> 
>   Fixes: 'commit f99e3daf94ff ("KVM: x86: Add Intel PT virtualization work mode")'
> 
> has these problem(s):
> 
>   - No SHA1 recognised
>     The leading word 'commit' is unexpected and the surrounding single
>     quotes likewise.
>     Please just use
> 	git log -1 --format='Fixes: %h ("%s")' <SHA>
> 
> -- 
> Cheers,
> Stephen Rothwell

B.R.
Yu

^ permalink raw reply	[flat|nested] 11+ messages in thread

* linux-next: Fixes tag needs some work in the kvm tree
@ 2019-02-16  7:34 Stephen Rothwell
  2019-02-20  7:02 ` Yu Zhang
  0 siblings, 1 reply; 11+ messages in thread
From: Stephen Rothwell @ 2019-02-16  7:34 UTC (permalink / raw)
  To: Paolo Bonzini, Radim Krčmář, KVM
  Cc: Linux Next Mailing List, Linux Kernel Mailing List, Yu Zhang,
	Sean Christopherson


[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

Hi all,

In commit

  aa8359972cfc ("KVM: x86/mmu: Differentiate between nr zapped and list unstable")

Fixes tag

  Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return

has these problem(s):

  - Subject has leading but no trailing quotes
    Please do not split Fixes tags over more than one line

In commit

  4d3f8e4ff75e ("kvm: vmx: Fix typos in vmentry/vmexit control setting")

Fixes tag

  Fixes: 'commit f99e3daf94ff ("KVM: x86: Add Intel PT virtualization work mode")'

has these problem(s):

  - No SHA1 recognised
    The leading word 'commit' is unexpected and the surrounding single
    quotes likewise.
    Please just use
	git log -1 --format='Fixes: %h ("%s")' <SHA>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, back to index

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16 12:27 linux-next: Fixes tag needs some work in the kvm tree Stephen Rothwell
2021-04-16 12:38 ` Christian Borntraeger
2021-04-16 14:02   ` Paolo Bonzini
2021-04-16 14:58     ` Stephen Rothwell
2021-04-16 15:02       ` Christian Borntraeger
  -- strict thread matches above, loose matches on Subject: below --
2021-02-04 20:16 Stephen Rothwell
2020-03-16 20:36 Stephen Rothwell
2020-01-24  3:13 Stephen Rothwell
2019-12-04 12:50 Stephen Rothwell
2019-02-16  7:34 Stephen Rothwell
2019-02-20  7:02 ` Yu Zhang

Linux-Next Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-next/0 linux-next/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-next linux-next/ https://lore.kernel.org/linux-next \
		linux-next@vger.kernel.org
	public-inbox-index linux-next

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-next


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git