From: Bruce Fields <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Benjamin Coddington <bcodding@redhat.com>,
Olga Kornievskaia <aglo@umich.edu>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: unsharing tcp connections from different NFS mounts
Date: Wed, 7 Oct 2020 12:05:56 -0400 [thread overview]
Message-ID: <20201007160556.GE23452@fieldses.org> (raw)
In-Reply-To: <85F496CD-9AAC-451C-A224-FCD138BDC591@oracle.com>
On Wed, Oct 07, 2020 at 10:15:39AM -0400, Chuck Lever wrote:
>
>
> > On Oct 7, 2020, at 10:05 AM, Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Wed, Oct 07, 2020 at 09:45:50AM -0400, Chuck Lever wrote:
> >>
> >>
> >>> On Oct 7, 2020, at 8:55 AM, Benjamin Coddington <bcodding@redhat.com> wrote:
> >>>
> >>> On 7 Oct 2020, at 7:27, Benjamin Coddington wrote:
> >>>
> >>>> On 6 Oct 2020, at 20:18, J. Bruce Fields wrote:
> >>>>
> >>>>> On Tue, Oct 06, 2020 at 05:46:11PM -0400, Olga Kornievskaia wrote:
> >>>>>> On Tue, Oct 6, 2020 at 3:38 PM Benjamin Coddington <bcodding@redhat.com> wrote:
> >>>>>>>
> >>>>>>> On 6 Oct 2020, at 11:13, J. Bruce Fields wrote:
> >>>
> >>>>> Looks like nfs4_init_{non}uniform_client_string() stores it in
> >>>>> cl_owner_id, and I was thinking that meant cl_owner_id would be used
> >>>>> from then on....
> >>>>>
> >>>>> But actually, I think it may run that again on recovery, yes, so I bet
> >>>>> changing the nfs4_unique_id parameter midway like this could cause bugs
> >>>>> on recovery.
> >>>>
> >>>> Ah, that's what I thought as well. Thanks for looking closer Olga!
> >>>
> >>> Well, no -- it does indeed continue to use the original cl_owner_id. We
> >>> only jump through nfs4_init_uniquifier_client_string() if cl_owner_id is
> >>> NULL:
> >>>
> >>> 6087 static int
> >>> 6088 nfs4_init_uniform_client_string(struct nfs_client *clp)
> >>> 6089 {
> >>> 6090 size_t len;
> >>> 6091 char *str;
> >>> 6092
> >>> 6093 if (clp->cl_owner_id != NULL)
> >>> 6094 return 0;
> >>> 6095
> >>> 6096 if (nfs4_client_id_uniquifier[0] != '\0')
> >>> 6097 return nfs4_init_uniquifier_client_string(clp);
> >>> 6098
> >>>
> >>>
> >>> Testing proves this out as well for both EXCHANGE_ID and SETCLIENTID.
> >>>
> >>> Is there any precedent for stabilizing module parameters as part of a
> >>> supported interface? Maybe this ought to be a mount option, so client can
> >>> set a uniquifier per-mount.
> >>
> >> The protocol is designed as one client-ID per client. FreeBSD is
> >> the only client I know of that uses one client-ID per mount, fwiw.
> >>
> >> You are suggesting each mount point would have its own lease. There
> >> would likely be deeper implementation changes needed than just
> >> specifying a unique client-ID for each mount point.
> >
> > Huh, I thought that should do it.
> >
> > Do you have something specific in mind?
>
> The relationship between nfs_client and nfs_server structs comes to
> mind.
I'm not following. Do you have a specific problem in mind?
--b.
>
> Trunking discovery has been around for several years. This is the
> first report I've heard of a performance regression.
>
> We do know that nconnect helps relieve head-of-line blocking on TCP.
> I think adding a second socket would be a very easy thing to try and
> wouldn't have any NFSv4 state recovery ramifications.
>
>
> --
> Chuck Lever
>
>
next prev parent reply other threads:[~2020-10-07 16:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 15:13 unsharing tcp connections from different NFS mounts J. Bruce Fields
2020-10-06 15:20 ` Chuck Lever
2020-10-06 15:22 ` Bruce Fields
2020-10-06 17:07 ` Tom Talpey
2020-10-06 19:30 ` Bruce Fields
[not found] ` <CAGrwUG5_KeRVR8chcA8=3FSeii2+4c8FbuE=CSGAtYVYqV4kLg@mail.gmail.com>
2020-10-07 14:08 ` Tom Talpey
2020-10-06 19:36 ` Benjamin Coddington
2020-10-06 21:46 ` Olga Kornievskaia
2020-10-07 0:18 ` J. Bruce Fields
2020-10-07 11:27 ` Benjamin Coddington
2020-10-07 12:55 ` Benjamin Coddington
2020-10-07 13:45 ` Chuck Lever
2020-10-07 14:05 ` Bruce Fields
2020-10-07 14:15 ` Chuck Lever
2020-10-07 16:05 ` Bruce Fields [this message]
2020-10-07 16:44 ` Trond Myklebust
2020-10-07 17:15 ` Bruce Fields
2020-10-07 17:29 ` Trond Myklebust
2020-10-07 18:05 ` bfields
2020-10-07 19:11 ` Trond Myklebust
2020-10-07 20:29 ` bfields
2020-10-07 18:04 ` Benjamin Coddington
2020-10-07 18:19 ` Trond Myklebust
2020-10-07 16:50 ` Trond Myklebust
2021-01-19 22:22 ` bfields
2021-01-19 23:09 ` Trond Myklebust
2021-01-20 15:07 ` bfields
2021-05-03 20:09 ` bfields
2021-05-04 2:08 ` NeilBrown
2021-05-04 13:27 ` Tom Talpey
2021-05-04 14:27 ` Trond Myklebust
2021-05-04 16:51 ` bfields
2021-05-04 21:32 ` Daire Byrne
2021-05-04 21:48 ` Trond Myklebust
2021-05-05 12:53 ` Daire Byrne
2021-01-20 15:58 ` Chuck Lever
2020-10-07 13:56 ` Patrick Goetz
2020-10-07 16:28 ` Igor Ostrovsky
2020-10-07 16:30 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007160556.GE23452@fieldses.org \
--to=bfields@fieldses.org \
--cc=aglo@umich.edu \
--cc=bcodding@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).