linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "bfields@fieldses.org" <bfields@fieldses.org>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"aglo@umich.edu" <aglo@umich.edu>,
	"bcodding@redhat.com" <bcodding@redhat.com>,
	"chuck.lever@oracle.com" <chuck.lever@oracle.com>
Subject: Re: unsharing tcp connections from different NFS mounts
Date: Wed, 7 Oct 2020 16:29:20 -0400	[thread overview]
Message-ID: <20201007202920.GH23452@fieldses.org> (raw)
In-Reply-To: <a761cb67ba5704ee95a95b863af5a283d554bd20.camel@hammerspace.com>

On Wed, Oct 07, 2020 at 07:11:49PM +0000, Trond Myklebust wrote:
> On Wed, 2020-10-07 at 14:05 -0400, bfields@fieldses.org wrote:
> > On Wed, Oct 07, 2020 at 05:29:26PM +0000, Trond Myklebust wrote:
> > > On Wed, 2020-10-07 at 13:15 -0400, Bruce Fields wrote:
> > > > Yeah, honestly I don't understand the details of that case
> > > > either.
> > > > 
> > > > (There is one related thing I'm curious about, which is how close
> > > > we
> > > > are
> > > > to keeping clients in different containers completely separate
> > > > (which
> > > > we'd need, for example, if we were to ever permit unprivileged
> > > > nfs
> > > > mounts).  It looks to me like as long as two network namespaces
> > > > use
> > > > different client identifiers, the client should keep different
> > > > state
> > > > for
> > > > them already?  Or is there more to do there?)
> > > 
> > > The containerised use case should already work. The containers have
> > > their own private uniquifiers, which can be changed
> > > via /sys/fs/nfs/net/nfs_client/identifier.
> > 
> > I was just looking at that commit (bf11fbd20b3 "NFS: Add sysfs
> > support
> > for per-container identifier"), and I'm confused by it: it adds code
> > to
> > nfs/sysfs to get and set "identifier", but nothing anywhere that
> > actually uses the value.  I can't figure out what I'm missing.
> > 
> 
> No, you're right. Something slipped under the radar there. The
> intention was that when it is set, the container-specific 'identifier'
> should replace the regular system-wide uniquifier. I thought I had
> merged patches for that, but apparently something got screwed up. Let
> me fix that up for 5.10...

Great, thanks.

--b.

  reply	other threads:[~2020-10-07 20:29 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 15:13 unsharing tcp connections from different NFS mounts J. Bruce Fields
2020-10-06 15:20 ` Chuck Lever
2020-10-06 15:22   ` Bruce Fields
2020-10-06 17:07     ` Tom Talpey
2020-10-06 19:30       ` Bruce Fields
     [not found]         ` <CAGrwUG5_KeRVR8chcA8=3FSeii2+4c8FbuE=CSGAtYVYqV4kLg@mail.gmail.com>
2020-10-07 14:08           ` Tom Talpey
2020-10-06 19:36 ` Benjamin Coddington
2020-10-06 21:46   ` Olga Kornievskaia
2020-10-07  0:18     ` J. Bruce Fields
2020-10-07 11:27       ` Benjamin Coddington
2020-10-07 12:55         ` Benjamin Coddington
2020-10-07 13:45           ` Chuck Lever
2020-10-07 14:05             ` Bruce Fields
2020-10-07 14:15               ` Chuck Lever
2020-10-07 16:05                 ` Bruce Fields
2020-10-07 16:44                   ` Trond Myklebust
2020-10-07 17:15                     ` Bruce Fields
2020-10-07 17:29                       ` Trond Myklebust
2020-10-07 18:05                         ` bfields
2020-10-07 19:11                           ` Trond Myklebust
2020-10-07 20:29                             ` bfields [this message]
2020-10-07 18:04                     ` Benjamin Coddington
2020-10-07 18:19                       ` Trond Myklebust
2020-10-07 16:50                   ` Trond Myklebust
2021-01-19 22:22                     ` bfields
2021-01-19 23:09                       ` Trond Myklebust
2021-01-20 15:07                         ` bfields
2021-05-03 20:09                           ` bfields
2021-05-04  2:08                             ` NeilBrown
2021-05-04 13:27                               ` Tom Talpey
2021-05-04 14:27                               ` Trond Myklebust
2021-05-04 16:51                                 ` bfields
2021-05-04 21:32                                   ` Daire Byrne
2021-05-04 21:48                                     ` Trond Myklebust
2021-05-05 12:53                                       ` Daire Byrne
2021-01-20 15:58                       ` Chuck Lever
2020-10-07 13:56 ` Patrick Goetz
2020-10-07 16:28   ` Igor Ostrovsky
2020-10-07 16:30   ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201007202920.GH23452@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=aglo@umich.edu \
    --cc=bcodding@redhat.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).