From: "Kelley, Sean V" <sean.v.kelley@intel.com>
To: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Jin, Wen" <wen.jin@intel.com>,
Linux PCI <linux-pci@vger.kernel.org>,
"Linux List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices
Date: Wed, 10 Feb 2021 04:33:28 +0000 [thread overview]
Message-ID: <131C9BC0-87C6-48EF-A07F-1B4537BD2671@intel.com> (raw)
In-Reply-To: <20210210020516.95292-1-qiuxu.zhuo@intel.com>
> On Feb 9, 2021, at 6:05 PM, Qiuxu Zhuo <qiuxu.zhuo@intel.com> wrote:
>
> On a Sapphire Rapids server, it failed to inject correctable errors
> to the RCiEP device e8:02.0 which was associated with the RCEC device
> e8:00.4. See the following error log before applying the patch:
>
> aer-inject -s e8:02.0 examples/correctable
> Error: Failed to write, No such device
>
> This was because rcec_assoc_rciep() mistakenly used "rciep->devfn" as
> device number to check whether the corresponding bit was set in
> the RCiEPBitmap of the RCEC. So that the RCiEP device e8:02.0 wasn't
> linked to the RCEC and resulted in the above error.
>
> Fix it by using PCI_SLOT() to convert rciep->devfn to device number.
> Ensure that the RCiEP devices associated with the RCEC are linked to
> the RCEC as the RCEC is enumerated. After applying the patch, correctable
> errors can be injected to the RCiEP successfully.
>
> Reported-and-tested-by: Wen Jin <wen.jin@intel.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Reviewed-by: Sean V Kelley <sean.v.kelley@intel.com>
Thanks,
Sean
> ---
> drivers/pci/pcie/rcec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/rcec.c b/drivers/pci/pcie/rcec.c
> index 2c5c552994e4..d0bcd141ac9c 100644
> --- a/drivers/pci/pcie/rcec.c
> +++ b/drivers/pci/pcie/rcec.c
> @@ -32,7 +32,7 @@ static bool rcec_assoc_rciep(struct pci_dev *rcec, struct pci_dev *rciep)
>
> /* Same bus, so check bitmap */
> for_each_set_bit(devn, &bitmap, 32)
> - if (devn == rciep->devfn)
> + if (devn == PCI_SLOT(rciep->devfn))
> return true;
>
> return false;
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-02-10 4:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 2:05 [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Qiuxu Zhuo
2021-02-10 4:33 ` Kelley, Sean V [this message]
2021-02-10 17:12 ` Krzysztof Wilczyński
2021-02-18 3:00 ` Zhuo, Qiuxu
2021-02-18 22:07 ` 'Krzysztof Wilczyński'
2021-02-18 22:11 ` 'Krzysztof Wilczyński'
2021-02-19 1:52 ` Zhuo, Qiuxu
2021-02-19 2:23 ` [PATCH v2 1/1] PCI/RCEC: Fix RCiEP capable devices RCEC association Qiuxu Zhuo
2021-02-22 0:56 ` Krzysztof Wilczyński
2021-02-22 1:04 ` Zhuo, Qiuxu
2021-02-22 1:17 ` [PATCH v3 " Qiuxu Zhuo
2021-03-05 6:12 ` Zhuo, Qiuxu
2021-03-10 22:00 ` Bjorn Helgaas
2021-03-11 3:13 ` Zhuo, Qiuxu
2021-02-19 1:51 ` [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Zhuo, Qiuxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=131C9BC0-87C6-48EF-A07F-1B4537BD2671@intel.com \
--to=sean.v.kelley@intel.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
--cc=wen.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).