From: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
To: "'Krzysztof Wilczyński'" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"Kelley, Sean V" <sean.v.kelley@intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Jin, Wen" <wen.jin@intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices
Date: Thu, 18 Feb 2021 03:00:20 +0000 [thread overview]
Message-ID: <a5b1aa8ef91a4c71982ad77234932349@intel.com> (raw)
In-Reply-To: <YCQT90mK1kacZ7ZA@rocinante>
Hi Krzysztof,
Sorry, just back from Chinese New Year holiday.
> From: Krzysztof Wilczyński <kw@linux.com>
> ...
> ...
> Would this only affect error injection or would this be also a generic problem
> with the driver itself causing issues regardless of whether it was an error
> injection or not for this particular device? I am asking, as there is a lot going on
> in the commit message.
This is also a generic problem.
> I wonder if simplifying this commit message so that it clearly explains what was
> broken, why, and how this patch is fixing it, would perhaps be an option? The
> backstory of how you found the issue while doing some testing and error
> injection is nice, but not sure if needed.
>
> What do you think?
Agree to simplify the commit message. How about the following subject and commit message?
Subject:
Use device number to check RCiEPBitmap of RCEC
Commit message:
rcec_assoc_rciep() used the combination of device number and function number 'devfn' to check whether the corresponding bit in the RCiEPBimap of RCEC was set. According to [1], it only needs to use the device number to check the corresponding bit in the RCiEPBitmap was set. So fix it by using PCI_SLOT() to convert 'devfn' to device number for rcec_assoc_rciep().
[1] PCIe r5.0, sec "7.9.10.2 Association Bitmap for RCiEPs"
Thanks!
-Qiuxu
next prev parent reply other threads:[~2021-02-18 3:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 2:05 [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Qiuxu Zhuo
2021-02-10 4:33 ` Kelley, Sean V
2021-02-10 17:12 ` Krzysztof Wilczyński
2021-02-18 3:00 ` Zhuo, Qiuxu [this message]
2021-02-18 22:07 ` 'Krzysztof Wilczyński'
2021-02-18 22:11 ` 'Krzysztof Wilczyński'
2021-02-19 1:52 ` Zhuo, Qiuxu
2021-02-19 2:23 ` [PATCH v2 1/1] PCI/RCEC: Fix RCiEP capable devices RCEC association Qiuxu Zhuo
2021-02-22 0:56 ` Krzysztof Wilczyński
2021-02-22 1:04 ` Zhuo, Qiuxu
2021-02-22 1:17 ` [PATCH v3 " Qiuxu Zhuo
2021-03-05 6:12 ` Zhuo, Qiuxu
2021-03-10 22:00 ` Bjorn Helgaas
2021-03-11 3:13 ` Zhuo, Qiuxu
2021-02-19 1:51 ` [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices Zhuo, Qiuxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5b1aa8ef91a4c71982ad77234932349@intel.com \
--to=qiuxu.zhuo@intel.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sean.v.kelley@intel.com \
--cc=tony.luck@intel.com \
--cc=wen.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).