From: Felipe Balbi <balbi@ti.com>
To: Huang Rui <ray.huang@amd.com>
Cc: Felipe Balbi <balbi@ti.com>,
Alan Stern <stern@rowland.harvard.edu>,
Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Paul Zimmerman <Paul.Zimmerman@synopsys.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Jason Chang <jason.chang@amd.com>,
Vincent Wan <vincent.wan@amd.com>, Tony Li <tony.li@amd.com>,
<linux-usb@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC
Date: Tue, 28 Oct 2014 09:41:56 -0500 [thread overview]
Message-ID: <20141028144156.GC8123@saruman> (raw)
In-Reply-To: <1414497280-3126-1-git-send-email-ray.huang@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]
Hi,
On Tue, Oct 28, 2014 at 07:54:21PM +0800, Huang Rui wrote:
> Hi,
>
> The series of patches add AMD Nolan (NL) SoC support for DesignWare USB3
> OTG IP with PCI bus glue layer. This controller supported hibernation, LPM
> erratum and used the 2.80a IP version and amd own phy. Current
> implementation support both simulation and SoC platform. And already tested
> with gadget zero and msc tool. It works well on file storage gadget.
>
>
> These patches are generated on balbi/testing/next
>
> Changes from v2 -> v3
> - Confirmed these quirks will be needed in product level
> - Move AMD configuration patch to the last one with all quirk flags
> - Make all quirks as 1-bit field instead of single-bits on a 32-bit
> variable
> - Add all quirks DeviceTree counterparts
> - Make LPM erratum configurable
> - Add PCI ID into pci_ids.h because it will be used both on PCI and DWC3
> device driver.
>
> Changes from v1 -> v2
> - Remove dual role function temporarily
> - Add pci quirk to avoid to bind with xhci driver
> - Distinguish between simulation board and soc
> - Break down all the special quirks
In all patches touching DeviceTree, you should add the matching binding
documentation under Documentation/devicetree/bindings/usb/dwc3.txt
There are still a few cases where you're clipping words too harshly, for
example tx_deemph doesn't look very intuitive, if you spell it out as
tx_deemphasis, it's easier to read. Remember that humans will be the
ones fiddling with those quirks.
A few of your patches I have fixed myself and they now sit on
testing/next, please rebase your remaining changes there and make sure
to add DeviceTree documentation.
When resending, please resend the entire series (even the ones I have
already taken) because you also didn't Cc devicetree mailing list.
cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-10-28 14:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 11:54 [PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC Huang Rui
2014-10-28 11:54 ` [PATCH v3 01/19] usb: dwc3: enable hibernation if to be supported Huang Rui
2014-10-28 18:47 ` Paul Zimmerman
2014-10-28 18:50 ` Felipe Balbi
2014-10-28 18:55 ` Paul Zimmerman
2014-10-28 19:01 ` Felipe Balbi
2014-10-28 19:15 ` Paul Zimmerman
2014-10-28 19:18 ` Felipe Balbi
2014-10-29 6:53 ` Huang Rui
2014-10-28 11:54 ` [PATCH v3 02/19] usb: dwc3: add a flag to check if it is fpga board Huang Rui
2014-10-28 11:54 ` [PATCH v3 03/19] usb: dwc3: initialize platform data at pci glue layer Huang Rui
2014-10-28 11:54 ` [PATCH v3 04/19] usb: dwc3: add disscramble quirk Huang Rui
2014-10-28 16:39 ` Bjorn Helgaas
2014-10-28 18:42 ` Felipe Balbi
2014-10-29 6:50 ` Huang Rui
2014-10-28 11:54 ` [PATCH v3 05/19] usb: dwc3: add lpm erratum support Huang Rui
2014-10-28 16:30 ` Bjorn Helgaas
2014-10-29 7:44 ` Huang Rui
2014-10-28 11:54 ` [PATCH v3 06/19] usb: dwc3: add u2exit lfps quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 07/19] usb: dwc3: add P3 in U2 SS inactive quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 08/19] usb: dwc3: add request p1p2p3 quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 09/19] usb: dwc3: add delay " Huang Rui
2014-10-28 11:54 ` [PATCH v3 10/19] usb: dwc3: add delay phy power change quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 11/19] usb: dwc3: add lfps filter quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 12/19] usb: dwc3: add rx_detect to polling lfps quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 13/19] usb: dwc3: add tx demphasis quirk Huang Rui
2014-10-28 16:27 ` Bjorn Helgaas
2014-10-28 18:43 ` Felipe Balbi
2014-10-29 8:08 ` Huang Rui
2014-10-28 11:54 ` [PATCH v3 14/19] usb: dwc3: set SUSPHY bit for all cores Huang Rui
2014-10-28 11:54 ` [PATCH v3 15/19] usb: dwc3: add disable usb3 suspend phy quirk Huang Rui
2014-10-28 11:54 ` [PATCH v3 16/19] usb: dwc3: add disable usb2 " Huang Rui
2014-10-28 11:54 ` [PATCH v3 17/19] PCI: Add support for AMD Nolan USB3 DRD Huang Rui
2014-10-28 13:30 ` Bjorn Helgaas
2014-10-28 11:54 ` [PATCH v3 18/19] PCI: Add quirk to prevent AMD NL USB3 DRD to bind with xHCI driver Huang Rui
2014-10-28 12:06 ` Sergei Shtylyov
2014-10-28 12:15 ` Huang Rui
2014-10-28 13:29 ` Bjorn Helgaas
2014-10-28 11:54 ` [PATCH v3 19/19] usb: dwc3: add support for AMD NL platform Huang Rui
2014-10-28 13:38 ` Felipe Balbi
2014-10-28 14:35 ` Huang Rui
2014-10-29 9:13 ` Huang Rui
2014-10-29 14:11 ` Felipe Balbi
2014-10-29 14:33 ` Huang Rui
2014-10-29 14:48 ` Felipe Balbi
2014-10-28 14:41 ` Felipe Balbi [this message]
2014-10-28 15:17 ` [PATCH v3 00/19] usb: dwc3: add support for AMD Nolan SoC Huang Rui
2014-10-28 15:23 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028144156.GC8123@saruman \
--to=balbi@ti.com \
--cc=Paul.Zimmerman@synopsys.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jason.chang@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ray.huang@amd.com \
--cc=stern@rowland.harvard.edu \
--cc=tony.li@amd.com \
--cc=vincent.wan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).