From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Rob Herring <robh@kernel.org> Cc: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>, bhelgaas@google.com, lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, mgross@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com Subject: Re: [PATCH 2/2] PCI: keembay: Add support for Intel Keem Bay Date: Wed, 28 Oct 2020 17:34:54 +0200 Message-ID: <20201028153454.GV4077@smile.fi.intel.com> (raw) In-Reply-To: <20201028142247.GC3932108@bogus> On Wed, Oct 28, 2020 at 09:22:47AM -0500, Rob Herring wrote: > On Tue, Oct 27, 2020 at 02:00:11PM +0800, Wan Ahmad Zainie wrote: ... > > +config PCIE_KEEMBAY_HOST > > + bool "Intel Keem Bay PCIe controller - Host mode" > > + depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST) > > Why only ARM64 for compile test? It's just for consistency with other Keem Bay drivers which may or may not use ARM64 specific call. Since DWC3 core PCI driver is used on many platforms and is being tested on other architectures, I think it's fine. This glue driver is for certain platform. But what I'm wondering now is if the existing glue code for some other platform can be reused here. > > + depends on PCI && PCI_MSI_IRQ_DOMAIN > > + select PCIE_DW_HOST > > + select PCIE_KEEMBAY -- With Best Regards, Andy Shevchenko
next prev parent reply index Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-27 6:00 [PATCH 0/2] " Wan Ahmad Zainie 2020-10-27 6:00 ` [PATCH 1/2] dt-bindings: PCI: Add Intel Keem Bay PCIe controller Wan Ahmad Zainie 2020-10-28 13:57 ` Rob Herring 2020-10-28 14:42 ` Rob Herring 2020-10-30 13:04 ` Wan Mohamad, Wan Ahmad Zainie 2020-10-30 14:55 ` Rob Herring 2020-11-03 6:01 ` Wan Mohamad, Wan Ahmad Zainie 2020-10-27 6:00 ` [PATCH 2/2] PCI: keembay: Add support for Intel Keem Bay Wan Ahmad Zainie 2020-10-28 14:22 ` Rob Herring 2020-10-28 15:34 ` Andy Shevchenko [this message] 2020-11-03 4:58 ` Wan Mohamad, Wan Ahmad Zainie 2020-11-03 22:22 ` Bjorn Helgaas 2020-11-04 9:36 ` Andy Shevchenko 2020-11-04 12:03 ` Wan Mohamad, Wan Ahmad Zainie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201028153454.GV4077@smile.fi.intel.com \ --to=andriy.shevchenko@linux.intel.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=lakshmi.bai.raja.subramanian@intel.com \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mgross@linux.intel.com \ --cc=robh@kernel.org \ --cc=wan.ahmad.zainie.wan.mohamad@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-PCI Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-pci/0 linux-pci/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-pci linux-pci/ https://lore.kernel.org/linux-pci \ linux-pci@vger.kernel.org public-inbox-index linux-pci Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-pci AGPL code for this site: git clone https://public-inbox.org/public-inbox.git