linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Daire.McNamara@microchip.com
Cc: bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	david.abdurachmanov@gmail.com, Cyril.Jean@microchip.com
Subject: Re: [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe controller
Date: Thu, 4 Feb 2021 10:20:53 +0000	[thread overview]
Message-ID: <20210204102052.GA28134@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <MN2PR11MB42691AE1B54DEAB5C1BAA11D96B59@MN2PR11MB4269.namprd11.prod.outlook.com>

On Tue, Feb 02, 2021 at 09:06:31AM +0000, Daire.McNamara@microchip.com wrote:
> 
> 
> ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
> From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Sent: Monday 1 February 2021 19:05
> To: Daire McNamara - X61553 <Daire.McNamara@microchip.com>
> Cc: bhelgaas@google.com <bhelgaas@google.com>; robh@kernel.org
> <robh@kernel.org>; linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>;
> robh+dt@kernel.org <robh+dt@kernel.org>; devicetree@vger.kernel.org
> <devicetree@vger.kernel.org>; david.abdurachmanov@gmail.com
> <david.abdurachmanov@gmail.com>; Cyril Jean - M31571 <Cyril.Jean@microchip.com>
> Subject: Re: [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe
> controller
>  
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Mon, Jan 25, 2021 at 04:29:33PM +0000, daire.mcnamara@microchip.com wrote:
> > From: Daire McNamara <daire.mcnamara@microchip.com>
> >
> > Add support for the Microchip PolarFire PCIe controller when
> > configured in host (Root Complex) mode.
> >
> > Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/pci/controller/Kconfig               |   10 +
> >  drivers/pci/controller/Makefile              |    1 +
> >  drivers/pci/controller/pcie-microchip-host.c | 1114 ++++++++++++++++++
> >  3 files changed, 1125 insertions(+)
> >  create mode 100644 drivers/pci/controller/pcie-microchip-host.c
> >
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index 64e2f5e379aa..bca2f8949510 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -298,6 +298,16 @@ config PCI_LOONGSON
> >         Say Y here if you want to enable PCI controller support on
> >         Loongson systems.
> >
> > +config PCIE_MICROCHIP_HOST
> > +     bool "Microchip AXI PCIe host bridge support"
> > +     depends on PCI_MSI && OF
> > +     select PCI_MSI_IRQ_DOMAIN
> > +     select GENERIC_MSI_IRQ_DOMAIN
> > +     select PCI_HOST_COMMON
> > +     help
> > +       Say Y here if you want kernel to support the Microchip AXI PCIe
> > +       Host Bridge driver.
> > +
> >  config PCIE_HISI_ERR
> >       depends on ACPI_APEI_GHES && (ARM64 || COMPILE_TEST)
> >       bool "HiSilicon HIP PCIe controller error handling driver"
> > diff --git a/drivers/pci/controller/Makefile b/drivers/pci/controller/
> Makefile
> > index 04c6edc285c5..b85fcd574ff6 100644
> > --- a/drivers/pci/controller/Makefile
> > +++ b/drivers/pci/controller/Makefile
> > @@ -28,6 +28,7 @@ obj-$(CONFIG_PCIE_ROCKCHIP_EP) += pcie-rockchip-ep.o
> >  obj-$(CONFIG_PCIE_ROCKCHIP_HOST) += pcie-rockchip-host.o
> >  obj-$(CONFIG_PCIE_MEDIATEK) += pcie-mediatek.o
> >  obj-$(CONFIG_PCIE_TANGO_SMP8759) += pcie-tango.o
> > +obj-$(CONFIG_PCIE_MICROCHIP_HOST) += pcie-microchip-host.o
> >  obj-$(CONFIG_VMD) += vmd.o
> >  obj-$(CONFIG_PCIE_BRCMSTB) += pcie-brcmstb.o
> >  obj-$(CONFIG_PCI_LOONGSON) += pci-loongson.o
> > diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/
> controller/pcie-microchip-host.c
> > new file mode 100644
> > index 000000000000..0ef2beab185b
> > --- /dev/null
> > +++ b/drivers/pci/controller/pcie-microchip-host.c
> > @@ -0,0 +1,1114 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Microchip AXI PCIe Bridge host controller driver
> > + *
> > + * Copyright (c) 2018 - 2020 Microchip Corporation. All rights reserved.
> 2021 - I will update it for you if that's OK.
> 
> Yes, please, that would be great.
> 
> > + * Author: Daire McNamara <daire.mcnamara@microchip.com>
> > + *
> > + * Based on:
> > + *   pcie-rcar.c
> > + *   pcie-xilinx.c
> > + *   pcie-altera.c
> 
> Can I remove these references please ? I said that before, let me know
> please, do not respost another version.
> 
> Yes, please.  Sorry I must have missed the question before.

Replies must be quoted and you must not send HTML format on ML,
(this was rejected by the ML and all the related tools) and that's
not the first time I mentioned that.

You must NOT do it and that's the last time I am saying that.

Please read:

https://kernelnewbies.org/PatchCulture

It is your maintainer responsibility to follow the ML and act
responsibly following the email etiquette, I don't have this HW and you
are the one that from now onwards is in charge of maintaining this code
which implies reviewing patches and actively following mailing lists.

Having said that, let's proceed with upstreaming the code, keep this
in mind please.

Thanks,
Lorenzo

  parent reply	other threads:[~2021-02-04 10:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 16:29 [PATCH v21 0/4] " daire.mcnamara
2021-01-25 16:29 ` [PATCH v21 1/4] PCI: Call platform_set_drvdata earlier in devm_pci_alloc_host_bridge daire.mcnamara
2021-01-25 16:29 ` [PATCH v21 2/4] dt-bindings: PCI: microchip: Add Microchip PolarFire host binding daire.mcnamara
2021-01-25 16:29 ` [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe controller daire.mcnamara
2021-02-01 19:05   ` Lorenzo Pieralisi
     [not found]     ` <MN2PR11MB42691AE1B54DEAB5C1BAA11D96B59@MN2PR11MB4269.namprd11.prod.outlook.com>
2021-02-04 10:20       ` Lorenzo Pieralisi [this message]
2021-02-10 13:07   ` Geert Uytterhoeven
2021-02-11 13:03     ` Ben Dooks
2021-02-11 13:07       ` Geert Uytterhoeven
2021-02-16  9:54         ` Daire.McNamara
2022-01-27 20:20   ` Bjorn Helgaas
2022-01-28  9:55     ` Marc Zyngier
2022-01-28 13:16       ` Bjorn Helgaas
2021-01-25 16:29 ` [PATCH v21 4/4] MAINTAINERS: Add Daire McNamara as maintainer for the Microchip PCIe driver daire.mcnamara
2021-02-04 11:42 ` [PATCH v21 0/4] PCI: microchip: Add host driver for Microchip PCIe controller Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204102052.GA28134@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Cyril.Jean@microchip.com \
    --cc=Daire.McNamara@microchip.com \
    --cc=bhelgaas@google.com \
    --cc=david.abdurachmanov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --subject='Re: [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe controller' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).