From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: daire.mcnamara@microchip.com,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh@kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
david.abdurachmanov@gmail.com, cyril.jean@microchip.com
Subject: Re: [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe controller
Date: Thu, 11 Feb 2021 14:07:25 +0100 [thread overview]
Message-ID: <CAMuHMdWZj5=vjno05F4hX6TGx0bvugBu53dhJ5L5wge2ezZuPQ@mail.gmail.com> (raw)
In-Reply-To: <d47ee0a2-7d9c-5c53-2977-09fa054e856b@codethink.co.uk>
Hi Ben,
On Thu, Feb 11, 2021 at 2:03 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> On 10/02/2021 13:07, Geert Uytterhoeven wrote:
> > On Mon, Jan 25, 2021 at 5:33 PM <daire.mcnamara@microchip.com> wrote:
> >> From: Daire McNamara <daire.mcnamara@microchip.com>
> >>
> >> Add support for the Microchip PolarFire PCIe controller when
> >> configured in host (Root Complex) mode.
> >>
> >> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
> >> Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your patch!
> >
> >> --- a/drivers/pci/controller/Kconfig
> >> +++ b/drivers/pci/controller/Kconfig
> >> @@ -298,6 +298,16 @@ config PCI_LOONGSON
> >> Say Y here if you want to enable PCI controller support on
> >> Loongson systems.
> >>
> >> +config PCIE_MICROCHIP_HOST
> >> + bool "Microchip AXI PCIe host bridge support"
> >> + depends on PCI_MSI && OF
> >> + select PCI_MSI_IRQ_DOMAIN
> >> + select GENERIC_MSI_IRQ_DOMAIN
> >> + select PCI_HOST_COMMON
> >> + help
> >> + Say Y here if you want kernel to support the Microchip AXI PCIe
> >> + Host Bridge driver.
> >
> > Is this PCIe host bridge accessible only from the PolarFire RISC-V
> > CPU cores, or also from softcores implemented in the PolarFire FPGA?
> >
> > In case of the former, we want to add a
> >
> > depends on CONFIG_SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
>
>
> I'd say having it on COMPILE_TEST if there's no polarfire includes
> would be useful to allow compile testing of the driver by the build
> robots.
As currently there is no platform dependency at all, it will be
compile-tested by allmodconfig on every config that has PCI_MSI && OF.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-02-11 13:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 16:29 [PATCH v21 0/4] PCI: microchip: Add host driver for Microchip PCIe controller daire.mcnamara
2021-01-25 16:29 ` [PATCH v21 1/4] PCI: Call platform_set_drvdata earlier in devm_pci_alloc_host_bridge daire.mcnamara
2021-01-25 16:29 ` [PATCH v21 2/4] dt-bindings: PCI: microchip: Add Microchip PolarFire host binding daire.mcnamara
2021-01-25 16:29 ` [PATCH v21 3/4] PCI: microchip: Add host driver for Microchip PCIe controller daire.mcnamara
2021-02-01 19:05 ` Lorenzo Pieralisi
[not found] ` <MN2PR11MB42691AE1B54DEAB5C1BAA11D96B59@MN2PR11MB4269.namprd11.prod.outlook.com>
2021-02-04 10:20 ` Lorenzo Pieralisi
2021-02-10 13:07 ` Geert Uytterhoeven
2021-02-11 13:03 ` Ben Dooks
2021-02-11 13:07 ` Geert Uytterhoeven [this message]
2021-02-16 9:54 ` Daire.McNamara
2022-01-27 20:20 ` Bjorn Helgaas
2022-01-28 9:55 ` Marc Zyngier
2022-01-28 13:16 ` Bjorn Helgaas
2021-01-25 16:29 ` [PATCH v21 4/4] MAINTAINERS: Add Daire McNamara as maintainer for the Microchip PCIe driver daire.mcnamara
2021-02-04 11:42 ` [PATCH v21 0/4] PCI: microchip: Add host driver for Microchip PCIe controller Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWZj5=vjno05F4hX6TGx0bvugBu53dhJ5L5wge2ezZuPQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=cyril.jean@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=david.abdurachmanov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).