linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: "Marek Behún" <kabel@kernel.org>,
	linux-pci@vger.kernel.org,
	Rötti <espressobinboardarmbiantempmailaddress@posteo.de>,
	"Krzysztof Wilczyński" <kw@linux.com>
Subject: Re: [PATCH] PCI: Add Max Payload Size quirk for ASMedia ASM1062 SATA controller
Date: Tue, 1 Jun 2021 16:15:30 -0500	[thread overview]
Message-ID: <20210601211530.GA1972509@bjorn-Precision-5520> (raw)
In-Reply-To: <20210601170907.GA1949035@bjorn-Precision-5520>

On Tue, Jun 01, 2021 at 12:09:09PM -0500, Bjorn Helgaas wrote:
> On Fri, May 28, 2021 at 02:12:08AM +0200, Pali Rohár wrote:
> > On Tuesday 11 May 2021 18:16:12 Marek Behún wrote:
> > > Ping? :)
> > > 
> > > Marek
> > 
> > Bjorn: Gentle reminder :)
> 
> The current patch [1] doesn't look mergeable as-is.
> 
>   - "ASM1062 SATA controller causes an External Abort on controllers
>     which support Max Payload Size >= 512" doesn't sound like a
>     correct description.
> 
>     That description suggests the problem is with the *PCI
>     controller*, not with the ASM1062.  I think that's incorrect; I
>     think the problem is with the ASM1062.
> 
>     I would expect something like "ASM1062 advertises Max_Payload_Size
>     Supported of 512, but in fact it cannot handle TLPs with payload
>     size of 512."

MPS is somewhat complicated, and I don't think we have good
documentation in the Linux source.  FWIW, this paper has a really good
explanation of the MPS (Max Payload Size) and MRRS (Max Read Request
Size) concepts:

https://www.xilinx.com/support/documentation/white_papers/wp350.pdf

  reply	other threads:[~2021-06-01 21:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 11:59 [PATCH] PCI: Add Max Payload Size quirk for ASMedia ASM1062 SATA controller Marek Behún
2021-03-17 18:46 ` Pali Rohár
2021-03-17 22:45 ` Bjorn Helgaas
2021-03-17 22:55   ` Pali Rohár
2021-03-17 23:03     ` Bjorn Helgaas
2021-03-19 19:02       ` Pali Rohár
2021-03-21 15:09         ` Rötti
2021-05-30 10:21           ` Pali Rohár
2021-08-26 11:00           ` Rötti
2021-03-17 23:09   ` Marek Behún
2021-04-16 13:54   ` Marek Behún
2021-04-25 15:29     ` Pali Rohár
2021-05-11 16:16 ` Marek Behún
2021-05-28  0:12   ` Pali Rohár
2021-06-01 17:09     ` Bjorn Helgaas
2021-06-01 21:15       ` Bjorn Helgaas [this message]
2021-06-01 11:36 ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210601211530.GA1972509@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=espressobinboardarmbiantempmailaddress@posteo.de \
    --cc=kabel@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=pali@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).