From: Sinan Kaya <firstname.lastname@example.org> To: Bjorn Helgaas <email@example.com> Cc: Paul Menzel <firstname.lastname@example.org>, Dave Young <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Lukas Wunner <email@example.com>, Eric Biederman <firstname.lastname@example.org>, Bjorn Helgaas <email@example.com>, Vivek Goyal <firstname.lastname@example.org> Subject: Re: pciehp 0000:00:1c.0:pcie004: Timeout on hotplug command 0x1038 (issued 65284 msec ago) Date: Mon, 30 Apr 2018 17:27:32 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <20180430211740.GG95643@bhelgaas-glaptop.roam.corp.google.com> On 4/30/2018 5:17 PM, Bjorn Helgaas wrote: >> What should we do about this? >> >> Since there is an actual HW errata involved, should we quirk this >> root port and not wait as if remove/shutdown doesn't exist? > I was hoping to avoid a quirk because AFAIK all Intel parts have this > issue so it will be an ongoing maintenance issue. I tried to avoid > the timeout delays, e.g., with 40b960831cfa ("PCI: pciehp: Compute > timeout from hotplug command start time"). > > But we still see the alarming messages, so we should probably add a > quirk to get rid of those. > > But I haven't given up on the idea of getting rid of the > pciehp_remove() path. I'm not convinced yet that we actually need to > do anything to shut this device down. I don't like the assumption > that kexec requires this. The kexec is fundamentally just a branch, > and anything we do before the branch (i.e., in the old kernel), we > should also be able to do after the branch (i.e., in the kexec-ed > kernel). > In my experience with kexec, MSI type edge interrupts are harmless. You might just see a few unhandled interrupt messages during boot if something is pending from the first kernel. It is the level interrupts that are more concerning. It remains pending until the interrupt source is cleared. CPU never returns from the interrupt handler to actually continue booting the second kernel. Execution doesn't reach to PCIe hp driver initialization for acknowledging the interrupt. How about remove() only if MSI is disabled? Most root port interrupts are MSI based anyhow. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-04-30 21:27 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-26 10:17 Paul Menzel 2018-04-27 19:22 ` Bjorn Helgaas 2018-04-27 19:34 ` Sinan Kaya 2018-04-27 21:12 ` Bjorn Helgaas 2018-04-28 0:56 ` Dave Young 2018-04-28 1:18 ` Dave Young 2018-04-28 13:03 ` okaya 2018-04-30 20:48 ` Sinan Kaya 2018-04-30 21:17 ` Bjorn Helgaas 2018-04-30 21:27 ` Sinan Kaya [this message] 2018-04-30 21:38 ` Lukas Wunner 2018-05-01 12:38 ` Sinan Kaya 2018-05-01 12:59 ` Marc Zyngier 2018-05-01 13:25 ` Bjorn Helgaas 2018-05-01 16:31 ` Marc Zyngier 2018-05-01 22:32 ` Eric W. Biederman 2018-05-03 8:49 ` Paul Menzel 2018-05-04 2:45 ` Bjorn Helgaas 2018-05-04 6:37 ` okaya 2018-05-04 13:33 ` Bjorn Helgaas 2018-05-04 14:24 ` okaya 2018-05-06 9:35 ` Paul Menzel 2018-05-07 21:33 ` Bjorn Helgaas 2018-05-08 6:59 ` Paul Menzel 2018-05-08 12:34 ` Bjorn Helgaas 2018-05-08 13:22 ` Paul Menzel 2018-05-09 11:41 ` Lukas Wunner 2018-05-09 12:57 ` Bjorn Helgaas 2018-05-09 13:16 ` Lukas Wunner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: pciehp 0000:00:1c.0:pcie004: Timeout on hotplug command 0x1038 (issued 65284 msec ago)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).