* [PATCH -next] thermal: power_allocator: Fix Kconfig warning
@ 2019-11-12 14:51 YueHaibing
2019-11-12 15:13 ` Quentin Perret
0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2019-11-12 14:51 UTC (permalink / raw)
To: rui.zhang, edubezval, daniel.lezcano, amit.kucheria, qperret,
viresh.kumar
Cc: linux-pm, linux-kernel, YueHaibing
When do randbuiding, we got this:
WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
Selected by [y]:
- THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR also depends on ENERGY_MODEL.
Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/thermal/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 59b79fc..5e9e038 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -108,6 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
bool "power_allocator"
+ depends on ENERGY_MODEL
select THERMAL_GOV_POWER_ALLOCATOR
help
Select this if you want to control temperature based on
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] thermal: power_allocator: Fix Kconfig warning
2019-11-12 14:51 [PATCH -next] thermal: power_allocator: Fix Kconfig warning YueHaibing
@ 2019-11-12 15:13 ` Quentin Perret
2019-11-12 15:28 ` Quentin Perret
0 siblings, 1 reply; 5+ messages in thread
From: Quentin Perret @ 2019-11-12 15:13 UTC (permalink / raw)
To: YueHaibing
Cc: rui.zhang, edubezval, daniel.lezcano, amit.kucheria,
viresh.kumar, linux-pm, linux-kernel
On Tuesday 12 Nov 2019 at 22:51:14 (+0800), YueHaibing wrote:
> When do randbuiding, we got this:
>
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
> Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> Selected by [y]:
> - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
This will not cause run-time problems, but I guess the warning is
annoying so ...
> Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR also depends on ENERGY_MODEL.
>
> Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
Daniel: can we rely on this sha1 ? Or is this branch force-pushed ?
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/thermal/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 59b79fc..5e9e038 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -108,6 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
>
> config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> bool "power_allocator"
> + depends on ENERGY_MODEL
> select THERMAL_GOV_POWER_ALLOCATOR
> help
> Select this if you want to control temperature based on
> --
> 2.7.4
Thanks,
Quentin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] thermal: power_allocator: Fix Kconfig warning
2019-11-12 15:13 ` Quentin Perret
@ 2019-11-12 15:28 ` Quentin Perret
2019-11-13 10:53 ` [PATCH v2 " YueHaibing
0 siblings, 1 reply; 5+ messages in thread
From: Quentin Perret @ 2019-11-12 15:28 UTC (permalink / raw)
To: YueHaibing
Cc: rui.zhang, edubezval, daniel.lezcano, amit.kucheria,
viresh.kumar, linux-pm, linux-kernel
On Tuesday 12 Nov 2019 at 15:13:19 (+0000), Quentin Perret wrote:
> On Tuesday 12 Nov 2019 at 22:51:14 (+0800), YueHaibing wrote:
> > When do randbuiding, we got this:
> >
> > WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
> > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> > Selected by [y]:
> > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
>
> This will not cause run-time problems, but I guess the warning is
> annoying so ...
>
> > Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR also depends on ENERGY_MODEL.
> >
> > Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
>
> Daniel: can we rely on this sha1 ? Or is this branch force-pushed ?
>
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/thermal/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 59b79fc..5e9e038 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -108,6 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
> >
> > config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> > bool "power_allocator"
> > + depends on ENERGY_MODEL
> > select THERMAL_GOV_POWER_ALLOCATOR
And actually, instead of doing this, we probably should change this
'select THERMAL_GOV_POWER_ALLOCATOR' by a 'depends on'.
> > help
> > Select this if you want to control temperature based on
> > --
> > 2.7.4
>
> Thanks,
> Quentin
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 -next] thermal: power_allocator: Fix Kconfig warning
2019-11-12 15:28 ` Quentin Perret
@ 2019-11-13 10:53 ` YueHaibing
2019-12-04 15:49 ` Daniel Lezcano
0 siblings, 1 reply; 5+ messages in thread
From: YueHaibing @ 2019-11-13 10:53 UTC (permalink / raw)
To: rui.zhang, edubezval, daniel.lezcano, amit.kucheria, qperret,
viresh.kumar
Cc: linux-pm, linux-kernel, YueHaibing
When do randbuiding, we got this:
WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
Selected by [y]:
- THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depend on
THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to fix this warning.
Suggested-by: Quentin Perret <qperret@google.com>
Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/thermal/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
index 59b79fc..79b2786 100644
--- a/drivers/thermal/Kconfig
+++ b/drivers/thermal/Kconfig
@@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
bool "power_allocator"
- select THERMAL_GOV_POWER_ALLOCATOR
+ depends on THERMAL_GOV_POWER_ALLOCATOR
help
Select this if you want to control temperature based on
system and device power allocation. This governor can only
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 -next] thermal: power_allocator: Fix Kconfig warning
2019-11-13 10:53 ` [PATCH v2 " YueHaibing
@ 2019-12-04 15:49 ` Daniel Lezcano
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2019-12-04 15:49 UTC (permalink / raw)
To: YueHaibing, rui.zhang, edubezval, amit.kucheria, qperret, viresh.kumar
Cc: linux-pm, linux-kernel
On 13/11/2019 11:53, YueHaibing wrote:
> When do randbuiding, we got this:
>
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
> Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> Selected by [y]:
> - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
>
> Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depend on
> THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to fix this warning.
>
> Suggested-by: Quentin Perret <qperret@google.com>
> Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied with a slight message clarification.
Thanks for the fix.
> ---
> drivers/thermal/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 59b79fc..79b2786 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
>
> config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> bool "power_allocator"
> - select THERMAL_GOV_POWER_ALLOCATOR
> + depends on THERMAL_GOV_POWER_ALLOCATOR
> help
> Select this if you want to control temperature based on
> system and device power allocation. This governor can only
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-04 15:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 14:51 [PATCH -next] thermal: power_allocator: Fix Kconfig warning YueHaibing
2019-11-12 15:13 ` Quentin Perret
2019-11-12 15:28 ` Quentin Perret
2019-11-13 10:53 ` [PATCH v2 " YueHaibing
2019-12-04 15:49 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).