Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/6] More CAN support for RZ/G2 devices
@ 2019-06-14 11:53 Fabrizio Castro
  2019-06-14 11:53 ` [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support Fabrizio Castro
                   ` (5 more replies)
  0 siblings, 6 replies; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Wolfgang Grandegger,
	Marc Kleine-Budde, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, David S. Miller, Magnus Damm, linux-can, netdev,
	devicetree, linux-renesas-soc, Chris Paterson, Biju Das,
	xu_shunji

Dear All,

This series adds CAN and CANFD support to the HiHope RZ/G2M, and also
improves SoC support for the RZ/G2E.
Please note that I wasn't able to test CAN-FD mode but only classical
CAN mode with the CANFD IP, my unit unfortunately comes with CAN-FD
mode disabled in HW, but the CANFD IP is working and responding
correctly while in classical mode.

Please note that this work depends on:
https://patchwork.kernel.org/cover/10986911/
https://patchwork.kernel.org/cover/10990113/

Thanks,
Fab

Fabrizio Castro (6):
  dt-bindings: can: rcar_canfd: document r8a774a1 support
  dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM]
  arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01]
  arm64: dts: renesas: r8a774a1: Add missing assigned-clocks for CAN[01]
  arm64: dts: renesas: r8a774a1: Add CANFD support
  arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces

 .../devicetree/bindings/net/can/rcar_can.txt       |  2 +-
 .../devicetree/bindings/net/can/rcar_canfd.txt     |  9 ++++---
 arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi    | 22 ++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi          | 29 ++++++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi          |  4 +++
 5 files changed, 61 insertions(+), 5 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support
  2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
@ 2019-06-14 11:53 ` Fabrizio Castro
  2019-06-17  9:30   ` Simon Horman
  2019-06-14 11:53 ` [PATCH 2/6] dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM] Fabrizio Castro
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Wolfgang Grandegger,
	Marc Kleine-Budde, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, David S. Miller, linux-can, netdev, devicetree,
	Chris Paterson, Biju Das, linux-renesas-soc

Document the support for rcar_canfd on R8A774A1 SoC devices.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
Hello Simon,

I think it would make more sense if this patch went through you as it
sits on series:
https://lkml.org/lkml/2019/5/9/941

Do you think that's doable?

Thanks,
Fab

 Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
index 32f051f..00afaff 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
@@ -4,6 +4,7 @@ Renesas R-Car CAN FD controller Device Tree Bindings
 Required properties:
 - compatible: Must contain one or more of the following:
   - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
+  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
   - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
   - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
   - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
@@ -32,10 +33,10 @@ enable/disable the respective channel.
 Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
 "renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
 compatible:
-In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
-div6 clock and can be used by both CAN and CAN FD controller at the same time.
-It needs to be scaled to maximum frequency if any of these controllers use it.
-This is done using the below properties:
+In R8A774A1, R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd
+clock is a div6 clock and can be used by both CAN and CAN FD controller at the
+same time. It needs to be scaled to maximum frequency if any of these
+controllers use it. This is done using the below properties:
 
 - assigned-clocks: phandle of canfd clock.
 - assigned-clock-rates: maximum frequency of this clock.
-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 2/6] dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM]
  2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
  2019-06-14 11:53 ` [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support Fabrizio Castro
@ 2019-06-14 11:53 ` Fabrizio Castro
  2019-07-08 12:56   ` Geert Uytterhoeven
  2019-06-14 11:53 ` [PATCH 3/6] arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01] Fabrizio Castro
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Wolfgang Grandegger,
	Marc Kleine-Budde, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, David S. Miller, linux-can, netdev, devicetree,
	Chris Paterson, Biju Das, linux-renesas-soc

Add missing RZ/G2[EM] CANFD clock specific documentation.

Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support")
Fixes: 0c11e7d0f51c ("dt-bindings: can: rcar_can: Add r8a774c0 support")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
Hello Simon,

I think it would make more sense if this patch went through you as it
sits on series:
https://lkml.org/lkml/2019/5/9/941

Do you think that's doable?

Thanks,
Fab

 Documentation/devicetree/bindings/net/can/rcar_can.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
index b463e12..e1f315a 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
@@ -33,7 +33,7 @@ Required properties:
 - pinctrl-0: pin control group to be used for this controller.
 - pinctrl-names: must be "default".
 
-Required properties for R8A7795, R8A7796 and R8A77965:
+Required properties for R8A774A1, R8A774C0, R8A7795, R8A7796 and R8A77965:
 For the denoted SoCs, "clkp2" can be CANFD clock. This is a div6 clock and can
 be used by both CAN and CAN FD controller at the same time. It needs to be
 scaled to maximum frequency if any of these controllers use it. This is done
-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 3/6] arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01]
  2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
  2019-06-14 11:53 ` [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support Fabrizio Castro
  2019-06-14 11:53 ` [PATCH 2/6] dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM] Fabrizio Castro
@ 2019-06-14 11:53 ` Fabrizio Castro
  2019-07-08 12:57   ` Geert Uytterhoeven
  2019-06-14 11:53 ` [PATCH 4/6] arm64: dts: renesas: r8a774a1: " Fabrizio Castro
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das

Define "assigned-clocks" and "assigned-clock-rates" properties
for CAN[01] DT nodes, as required by the dt-bindings.

Fixes: 036bc85c1d06 ("arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index e7b5bf2..bdf555f 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -973,6 +973,8 @@
 				 <&cpg CPG_CORE R8A774C0_CLK_CANFD>,
 				 <&can_clk>;
 			clock-names = "clkp1", "clkp2", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A774C0_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
 			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
 			resets = <&cpg 916>;
 			status = "disabled";
@@ -987,6 +989,8 @@
 				 <&cpg CPG_CORE R8A774C0_CLK_CANFD>,
 				 <&can_clk>;
 			clock-names = "clkp1", "clkp2", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A774C0_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
 			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
 			resets = <&cpg 915>;
 			status = "disabled";
-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 4/6] arm64: dts: renesas: r8a774a1: Add missing assigned-clocks for CAN[01]
  2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
                   ` (2 preceding siblings ...)
  2019-06-14 11:53 ` [PATCH 3/6] arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01] Fabrizio Castro
@ 2019-06-14 11:53 ` " Fabrizio Castro
  2019-07-08 12:57   ` Geert Uytterhoeven
  2019-06-14 11:53 ` [PATCH 5/6] arm64: dts: renesas: r8a774a1: Add CANFD support Fabrizio Castro
  2019-06-14 11:53 ` [PATCH 6/6] arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces Fabrizio Castro
  5 siblings, 1 reply; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das

Define "assigned-clocks" and "assigned-clock-rates" properties
for CAN[01] DT nodes, as required by the dt-bindings.

Fixes: eccc40002972 ("arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index b437edc..99c5452 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -1128,6 +1128,8 @@
 				 <&cpg CPG_CORE R8A774A1_CLK_CANFD>,
 				 <&can_clk>;
 			clock-names = "clkp1", "clkp2", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A774A1_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
 			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
 			resets = <&cpg 916>;
 			status = "disabled";
@@ -1142,6 +1144,8 @@
 				 <&cpg CPG_CORE R8A774A1_CLK_CANFD>,
 				 <&can_clk>;
 			clock-names = "clkp1", "clkp2", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A774A1_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
 			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
 			resets = <&cpg 915>;
 			status = "disabled";
-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 5/6] arm64: dts: renesas: r8a774a1: Add CANFD support
  2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
                   ` (3 preceding siblings ...)
  2019-06-14 11:53 ` [PATCH 4/6] arm64: dts: renesas: r8a774a1: " Fabrizio Castro
@ 2019-06-14 11:53 ` Fabrizio Castro
  2019-07-08 13:01   ` Geert Uytterhoeven
  2019-06-14 11:53 ` [PATCH 6/6] arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces Fabrizio Castro
  5 siblings, 1 reply; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das

Add CANFD support to the SoC specific dtsi.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 99c5452..d6dd4b6 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -1151,6 +1151,31 @@
 			status = "disabled";
 		};
 
+		canfd: can@e66c0000 {
+			compatible = "renesas,r8a774a1-canfd",
+				     "renesas,rcar-gen3-canfd";
+			reg = <0 0xe66c0000 0 0x8000>;
+			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 914>,
+				 <&cpg CPG_CORE R8A774A1_CLK_CANFD>,
+				 <&can_clk>;
+			clock-names = "fck", "canfd", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A774A1_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
+			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
+			resets = <&cpg 914>;
+			status = "disabled";
+
+			channel0 {
+				status = "disabled";
+			};
+
+			channel1 {
+				status = "disabled";
+			};
+		};
+
 		pwm0: pwm@e6e30000 {
 			compatible = "renesas,pwm-r8a774a1", "renesas,pwm-rcar";
 			reg = <0 0xe6e30000 0 0x8>;
-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH 6/6] arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces
  2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
                   ` (4 preceding siblings ...)
  2019-06-14 11:53 ` [PATCH 5/6] arm64: dts: renesas: r8a774a1: Add CANFD support Fabrizio Castro
@ 2019-06-14 11:53 ` Fabrizio Castro
  2019-07-08 13:08   ` Geert Uytterhoeven
  5 siblings, 1 reply; 14+ messages in thread
From: Fabrizio Castro @ 2019-06-14 11:53 UTC (permalink / raw)
  To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
  Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
	Chris Paterson, Biju Das, xu_shunji

This patch enables both CAN0 and CAN1, both exposed via
connectors found on the expansion board.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
 arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
index 07a6eea..4280b19 100644
--- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi
@@ -31,6 +31,18 @@
 	};
 };
 
+&can0 {
+	pinctrl-0 = <&can0_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
+&can1 {
+	pinctrl-0 = <&can1_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+};
+
 &pciec0 {
 	status = "okay";
 };
@@ -60,4 +72,14 @@
 			drive-strength = <12>;
 		};
 	};
+
+	can0_pins: can0 {
+		groups = "can0_data_a";
+		function = "can0";
+	};
+
+	can1_pins: can1 {
+		groups = "can1_data";
+		function = "can1";
+	};
 };
-- 
2.7.4


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support
  2019-06-14 11:53 ` [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support Fabrizio Castro
@ 2019-06-17  9:30   ` Simon Horman
  2019-07-08 12:55     ` Geert Uytterhoeven
  0 siblings, 1 reply; 14+ messages in thread
From: Simon Horman @ 2019-06-17  9:30 UTC (permalink / raw)
  To: Fabrizio Castro, David S. Miller
  Cc: Geert Uytterhoeven, Wolfgang Grandegger, Marc Kleine-Budde,
	Rob Herring, Mark Rutland, linux-can, netdev, devicetree,
	Chris Paterson, Biju Das, linux-renesas-soc

On Fri, Jun 14, 2019 at 12:53:29PM +0100, Fabrizio Castro wrote:
> Document the support for rcar_canfd on R8A774A1 SoC devices.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> ---
> Hello Simon,
> 
> I think it would make more sense if this patch went through you as it
> sits on series:
> https://lkml.org/lkml/2019/5/9/941
> 
> Do you think that's doable?

That seems reasonable to me.

Dave are you happy with me taking this, and 2/6, through
the renesas tree?

> 
> Thanks,
> Fab
> 
>  Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> index 32f051f..00afaff 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> @@ -4,6 +4,7 @@ Renesas R-Car CAN FD controller Device Tree Bindings
>  Required properties:
>  - compatible: Must contain one or more of the following:
>    - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
> +  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
>    - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
>    - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
>    - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> @@ -32,10 +33,10 @@ enable/disable the respective channel.
>  Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
>  "renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
>  compatible:
> -In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
> -div6 clock and can be used by both CAN and CAN FD controller at the same time.
> -It needs to be scaled to maximum frequency if any of these controllers use it.
> -This is done using the below properties:
> +In R8A774A1, R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd
> +clock is a div6 clock and can be used by both CAN and CAN FD controller at the
> +same time. It needs to be scaled to maximum frequency if any of these
> +controllers use it. This is done using the below properties:
>  
>  - assigned-clocks: phandle of canfd clock.
>  - assigned-clock-rates: maximum frequency of this clock.
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support
  2019-06-17  9:30   ` Simon Horman
@ 2019-07-08 12:55     ` Geert Uytterhoeven
  0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 12:55 UTC (permalink / raw)
  To: Simon Horman
  Cc: Fabrizio Castro, David S. Miller, Geert Uytterhoeven,
	Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring,
	Mark Rutland, linux-can, netdev,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Linux-Renesas

On Mon, Jun 17, 2019 at 11:30 AM Simon Horman <horms@verge.net.au> wrote:
> On Fri, Jun 14, 2019 at 12:53:29PM +0100, Fabrizio Castro wrote:
> > Document the support for rcar_canfd on R8A774A1 SoC devices.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> > ---
> > Hello Simon,
> >
> > I think it would make more sense if this patch went through you as it
> > sits on series:
> > https://lkml.org/lkml/2019/5/9/941
> >
> > Do you think that's doable?
>
> That seems reasonable to me.
>
> Dave are you happy with me taking this, and 2/6, through
> the renesas tree?

As the previous change to this file was acked by Dave, and went in through
the Renesas tree, have I applied this patch and patch 2/6, and queued
it for v5.4.

Thanks!

> >  Documentation/devicetree/bindings/net/can/rcar_canfd.txt | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> > index 32f051f..00afaff 100644
> > --- a/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> > +++ b/Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> > @@ -4,6 +4,7 @@ Renesas R-Car CAN FD controller Device Tree Bindings
> >  Required properties:
> >  - compatible: Must contain one or more of the following:
> >    - "renesas,rcar-gen3-canfd" for R-Car Gen3 and RZ/G2 compatible controllers.
> > +  - "renesas,r8a774a1-canfd" for R8A774A1 (RZ/G2M) compatible controller.
> >    - "renesas,r8a774c0-canfd" for R8A774C0 (RZ/G2E) compatible controller.
> >    - "renesas,r8a7795-canfd" for R8A7795 (R-Car H3) compatible controller.
> >    - "renesas,r8a7796-canfd" for R8A7796 (R-Car M3-W) compatible controller.
> > @@ -32,10 +33,10 @@ enable/disable the respective channel.
> >  Required properties for "renesas,r8a774c0-canfd", "renesas,r8a7795-canfd",
> >  "renesas,r8a7796-canfd", "renesas,r8a77965-canfd", and "renesas,r8a77990-canfd"
> >  compatible:
> > -In R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd clock is a
> > -div6 clock and can be used by both CAN and CAN FD controller at the same time.
> > -It needs to be scaled to maximum frequency if any of these controllers use it.
> > -This is done using the below properties:
> > +In R8A774A1, R8A774C0, R8A7795, R8A7796, R8A77965, and R8A77990 SoCs, canfd
> > +clock is a div6 clock and can be used by both CAN and CAN FD controller at the
> > +same time. It needs to be scaled to maximum frequency if any of these
> > +controllers use it. This is done using the below properties:
> >
> >  - assigned-clocks: phandle of canfd clock.
> >  - assigned-clock-rates: maximum frequency of this clock.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 2/6] dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM]
  2019-06-14 11:53 ` [PATCH 2/6] dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM] Fabrizio Castro
@ 2019-07-08 12:56   ` Geert Uytterhoeven
  0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 12:56 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Simon Horman, Geert Uytterhoeven, Wolfgang Grandegger,
	Marc Kleine-Budde, Rob Herring, Mark Rutland, David S. Miller,
	linux-can, netdev,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, Linux-Renesas

On Fri, Jun 14, 2019 at 1:53 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Add missing RZ/G2[EM] CANFD clock specific documentation.
>
> Fixes: 868b7c0f43e6 ("dt-bindings: can: rcar_can: Add r8a774a1 support")
> Fixes: 0c11e7d0f51c ("dt-bindings: can: rcar_can: Add r8a774c0 support")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. applied and queued for v5.4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 3/6] arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01]
  2019-06-14 11:53 ` [PATCH 3/6] arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01] Fabrizio Castro
@ 2019-07-08 12:57   ` Geert Uytterhoeven
  0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 12:57 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland,
	Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das

On Fri, Jun 14, 2019 at 1:54 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Define "assigned-clocks" and "assigned-clock-rates" properties
> for CAN[01] DT nodes, as required by the dt-bindings.
>
> Fixes: 036bc85c1d06 ("arm64: dts: renesas: r8a774c0: Add clkp2 clock to CAN nodes")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. applied and queued for v5.4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 4/6] arm64: dts: renesas: r8a774a1: Add missing assigned-clocks for CAN[01]
  2019-06-14 11:53 ` [PATCH 4/6] arm64: dts: renesas: r8a774a1: " Fabrizio Castro
@ 2019-07-08 12:57   ` Geert Uytterhoeven
  0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 12:57 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland,
	Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das

On Fri, Jun 14, 2019 at 1:54 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Define "assigned-clocks" and "assigned-clock-rates" properties
> for CAN[01] DT nodes, as required by the dt-bindings.
>
> Fixes: eccc40002972 ("arm64: dts: renesas: r8a774a1: Add clkp2 clock to CAN nodes")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. applied and queued for v5.4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 5/6] arm64: dts: renesas: r8a774a1: Add CANFD support
  2019-06-14 11:53 ` [PATCH 5/6] arm64: dts: renesas: r8a774a1: Add CANFD support Fabrizio Castro
@ 2019-07-08 13:01   ` Geert Uytterhoeven
  0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 13:01 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland,
	Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das

On Fri, Jun 14, 2019 at 1:54 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Add CANFD support to the SoC specific dtsi.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. applied and queued for v5.4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH 6/6] arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces
  2019-06-14 11:53 ` [PATCH 6/6] arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces Fabrizio Castro
@ 2019-07-08 13:08   ` Geert Uytterhoeven
  0 siblings, 0 replies; 14+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 13:08 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland,
	Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Biju Das, xu_shunji

On Fri, Jun 14, 2019 at 1:54 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch enables both CAN0 and CAN1, both exposed via
> connectors found on the expansion board.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
I.e. applied and queued for v5.4.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-14 11:53 [PATCH 0/6] More CAN support for RZ/G2 devices Fabrizio Castro
2019-06-14 11:53 ` [PATCH 1/6] dt-bindings: can: rcar_canfd: document r8a774a1 support Fabrizio Castro
2019-06-17  9:30   ` Simon Horman
2019-07-08 12:55     ` Geert Uytterhoeven
2019-06-14 11:53 ` [PATCH 2/6] dt-bindings: can: rcar_can: Complete documentation for RZ/G2[EM] Fabrizio Castro
2019-07-08 12:56   ` Geert Uytterhoeven
2019-06-14 11:53 ` [PATCH 3/6] arm64: dts: renesas: r8a774c0: Add missing assigned-clocks for CAN[01] Fabrizio Castro
2019-07-08 12:57   ` Geert Uytterhoeven
2019-06-14 11:53 ` [PATCH 4/6] arm64: dts: renesas: r8a774a1: " Fabrizio Castro
2019-07-08 12:57   ` Geert Uytterhoeven
2019-06-14 11:53 ` [PATCH 5/6] arm64: dts: renesas: r8a774a1: Add CANFD support Fabrizio Castro
2019-07-08 13:01   ` Geert Uytterhoeven
2019-06-14 11:53 ` [PATCH 6/6] arm64: dts: renesas: hihope-rzg2-ex: Enable CAN interfaces Fabrizio Castro
2019-07-08 13:08   ` Geert Uytterhoeven

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox