Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
@ 2019-09-05 15:05 Andrew Murray
  2019-09-06  9:34 ` Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Andrew Murray @ 2019-09-05 15:05 UTC (permalink / raw)
  To: Simon Horman, Lorenzo Pieralisi
  Cc: Bjorn Helgaas, linux-pci, linux-renesas-soc

Remove unnecessary header include (../pci.h) since it doesn't
provide any needed symbols.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 drivers/pci/controller/pcie-rcar.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
index f6a669a9af41..ee1c38c2fac9 100644
--- a/drivers/pci/controller/pcie-rcar.c
+++ b/drivers/pci/controller/pcie-rcar.c
@@ -30,8 +30,6 @@
 #include <linux/pm_runtime.h>
 #include <linux/slab.h>
 
-#include "../pci.h"
-
 #define PCIECAR			0x000010
 #define PCIECCTLR		0x000018
 #define  CONFIG_SEND_ENABLE	BIT(31)
-- 
2.21.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
  2019-09-05 15:05 [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h) Andrew Murray
@ 2019-09-06  9:34 ` Simon Horman
  2019-09-11 22:33 ` Kieran Bingham
  2019-09-12  8:38 ` Geert Uytterhoeven
  2 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2019-09-06  9:34 UTC (permalink / raw)
  To: Andrew Murray
  Cc: Lorenzo Pieralisi, Bjorn Helgaas, linux-pci, linux-renesas-soc

On Thu, Sep 05, 2019 at 04:05:28PM +0100, Andrew Murray wrote:
> Remove unnecessary header include (../pci.h) since it doesn't
> provide any needed symbols.
> 
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/pci/controller/pcie-rcar.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> index f6a669a9af41..ee1c38c2fac9 100644
> --- a/drivers/pci/controller/pcie-rcar.c
> +++ b/drivers/pci/controller/pcie-rcar.c
> @@ -30,8 +30,6 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/slab.h>
>  
> -#include "../pci.h"
> -
>  #define PCIECAR			0x000010
>  #define PCIECCTLR		0x000018
>  #define  CONFIG_SEND_ENABLE	BIT(31)
> -- 
> 2.21.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
  2019-09-05 15:05 [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h) Andrew Murray
  2019-09-06  9:34 ` Simon Horman
@ 2019-09-11 22:33 ` Kieran Bingham
  2019-09-12  8:19   ` Andrew Murray
  2019-09-12  8:38 ` Geert Uytterhoeven
  2 siblings, 1 reply; 5+ messages in thread
From: Kieran Bingham @ 2019-09-11 22:33 UTC (permalink / raw)
  To: Andrew Murray, Simon Horman, Lorenzo Pieralisi
  Cc: Bjorn Helgaas, linux-pci, linux-renesas-soc

Hi Andy!

On 05/09/2019 16:05, Andrew Murray wrote:
> Remove unnecessary header include (../pci.h) since it doesn't
> provide any needed symbols.

This appears to have been added in 9e2aee80c78d ("PCI: Move private DT
related functions into private header")

Several other drivers were touched in that commit too.

Have you checked to see if any others can also be cleaned up?

 (I only ask, because I only see this single patch on linux-renesas-soc,
my apologies if others are on different lists.)

Regardless of that, this looks fine to me, and passes a cursory compile
check.

And I've just tried with pcie-xilinx, and pcie-altera, but both still
need this header - so perhaps pcie-rcar was just the odd one out.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>


> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
>  drivers/pci/controller/pcie-rcar.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> index f6a669a9af41..ee1c38c2fac9 100644
> --- a/drivers/pci/controller/pcie-rcar.c
> +++ b/drivers/pci/controller/pcie-rcar.c
> @@ -30,8 +30,6 @@
>  #include <linux/pm_runtime.h>
>  #include <linux/slab.h>
>  
> -#include "../pci.h"
> -
>  #define PCIECAR			0x000010
>  #define PCIECCTLR		0x000018
>  #define  CONFIG_SEND_ENABLE	BIT(31)
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
  2019-09-11 22:33 ` Kieran Bingham
@ 2019-09-12  8:19   ` Andrew Murray
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Murray @ 2019-09-12  8:19 UTC (permalink / raw)
  To: Kieran Bingham
  Cc: Simon Horman, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci,
	linux-renesas-soc

On Wed, Sep 11, 2019 at 11:33:03PM +0100, Kieran Bingham wrote:
> Hi Andy!
> 
> On 05/09/2019 16:05, Andrew Murray wrote:
> > Remove unnecessary header include (../pci.h) since it doesn't
> > provide any needed symbols.
> 
> This appears to have been added in 9e2aee80c78d ("PCI: Move private DT
> related functions into private header")

Thanks, I never looked back at the history of this.

> 
> Several other drivers were touched in that commit too.
> 
> Have you checked to see if any others can also be cleaned up?

Yes I went through all the current drivers/pci/host/ files, I believe this
was the only one.

> 
>  (I only ask, because I only see this single patch on linux-renesas-soc,
> my apologies if others are on different lists.)
> 
> Regardless of that, this looks fine to me, and passes a cursory compile
> check.
> 
> And I've just tried with pcie-xilinx, and pcie-altera, but both still
> need this header - so perhaps pcie-rcar was just the odd one out.
> 
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Thanks,

Andrew Murray

> 
> 
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> >  drivers/pci/controller/pcie-rcar.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> > index f6a669a9af41..ee1c38c2fac9 100644
> > --- a/drivers/pci/controller/pcie-rcar.c
> > +++ b/drivers/pci/controller/pcie-rcar.c
> > @@ -30,8 +30,6 @@
> >  #include <linux/pm_runtime.h>
> >  #include <linux/slab.h>
> >  
> > -#include "../pci.h"
> > -
> >  #define PCIECAR			0x000010
> >  #define PCIECCTLR		0x000018
> >  #define  CONFIG_SEND_ENABLE	BIT(31)
> > 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h)
  2019-09-05 15:05 [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h) Andrew Murray
  2019-09-06  9:34 ` Simon Horman
  2019-09-11 22:33 ` Kieran Bingham
@ 2019-09-12  8:38 ` Geert Uytterhoeven
  2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2019-09-12  8:38 UTC (permalink / raw)
  To: Andrew Murray
  Cc: Simon Horman, Lorenzo Pieralisi, Bjorn Helgaas, linux-pci, Linux-Renesas

On Thu, Sep 5, 2019 at 8:33 PM Andrew Murray <andrew.murray@arm.com> wrote:
> Remove unnecessary header include (../pci.h) since it doesn't
> provide any needed symbols.
>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05 15:05 [PATCH] PCI: rcar: Remove unnecessary header include (../pci.h) Andrew Murray
2019-09-06  9:34 ` Simon Horman
2019-09-11 22:33 ` Kieran Bingham
2019-09-12  8:19   ` Andrew Murray
2019-09-12  8:38 ` Geert Uytterhoeven

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox