From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH 5/6] clk: renesas: r9a07g043: Add OSTM clock and reset entries
Date: Thu, 28 Apr 2022 12:23:38 +0000 [thread overview]
Message-ID: <OS0PR01MB59228ED721115FAA3BFB3F5C86FD9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUtQTGvO7vxHFnJ6uStHmoAx_sdhxRJgjYQTpq4H_gyPA@mail.gmail.com>
Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH 5/6] clk: renesas: r9a07g043: Add OSTM clock and reset
> entries
>
> Hi Biju,
>
> On Mon, Apr 25, 2022 at 11:53 AM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Add OSTM{0,1,2} clock and reset entries to CPG driver.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> Thanks for your patch!
>
> > --- a/drivers/clk/renesas/r9a07g043-cpg.c
> > +++ b/drivers/clk/renesas/r9a07g043-cpg.c
> > @@ -129,6 +129,12 @@ static struct rzg2l_mod_clk r9a07g043_mod_clks[] =
> {
> > 0x52c, 0),
> > DEF_MOD("dmac_pclk", R9A07G043_DMAC_PCLK, CLK_P1_DIV2,
> > 0x52c, 1),
> > + DEF_MOD("ostm0", R9A07G043_OSTM0_PCLK, R9A07G043_CLK_P0,
> > + 0x534, 0),
> > + DEF_MOD("ostm1", R9A07G043_OSTM1_PCLK, R9A07G043_CLK_P0,
> > + 0x534, 1),
> > + DEF_MOD("ostm2", R9A07G043_OSTM2_PCLK, R9A07G043_CLK_P0,
> > + 0x534, 2),
>
> Do you mind if I change the clock names to "ostm[012_pclk"
> while applying, for consistency with r9a07g044-cpg.c.
Thanks, Ok for me.
Cheers,
Biju
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue
> in renesas-clk-for-v5.19.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2022-04-28 12:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 9:52 [PATCH 0/6] Add RZ/G2UL CLK and Reset entries for I2C,SSI,USB,CANFD,OSTM and WDT Biju Das
2022-04-25 9:52 ` [PATCH 1/6] clk: renesas: r9a07g043: Add I2C clocks/resets Biju Das
2022-04-28 12:21 ` Geert Uytterhoeven
2022-04-25 9:52 ` [PATCH 2/6] clk: renesas: r9a07g043: Add SSIF-2 clock and reset entries Biju Das
2022-04-28 12:21 ` Geert Uytterhoeven
2022-04-25 9:52 ` [PATCH 3/6] clk: renesas: r9a07g043: Add USB clocks/resets Biju Das
2022-04-28 12:21 ` Geert Uytterhoeven
2022-04-25 9:52 ` [PATCH 4/6] clk: renesas: r9a07g043: Add clock and reset entries for CANFD Biju Das
2022-04-28 12:20 ` Geert Uytterhoeven
2022-04-25 9:52 ` [PATCH 5/6] clk: renesas: r9a07g043: Add OSTM clock and reset entries Biju Das
2022-04-28 12:19 ` Geert Uytterhoeven
2022-04-28 12:23 ` Biju Das [this message]
2022-04-25 9:52 ` [PATCH 6/6] clk: renesas: r9a07g043: Add WDT " Biju Das
2022-04-28 12:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59228ED721115FAA3BFB3F5C86FD9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).