From: Chris Brandt <Chris.Brandt@renesas.com> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Geert Uytterhoeven <geert+renesas@glider.be>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-spi <linux-spi@vger.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, Mason Yang <masonccyang@mxic.com.tw>, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Subject: RE: [PATCH 3/6] clk: renesas: r7s9210: Add SPIBSC clock Date: Tue, 3 Dec 2019 19:09:05 +0000 Message-ID: <TY1PR01MB1562D198A463C18B1D810DF48A420@TY1PR01MB1562.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAMuHMdUxCdJXyY15f6sr+QFNpg9FLsa5pL3171bm_meJcBNR2g@mail.gmail.com> Hi Geert, On Tue, Dec 3, 2019, Geert Uytterhoeven wrote: > > +static const unsigned int r7s9210_crit_mod_clks[] __initconst = { > > + MOD_CLK_ID_10(83), /* SPIBSC */ > > This is only a critical clock if XIP is in use, right? Correct. > Can we do better, and only mark it critical if we detect the FLASH is used in > XIP mode? > E.g. by using for_each_compatible_node(..., "mtd-rom"), and checking if any > of the corresponding register blocks matches the SPIBSC FLASH memory window? Well...technically...you don't need the "mtd-rom" partition when using the AXFS file system. But, we can make a rule that you have to use it regardless. Instead, I think it would be better if we could flag the clock as critical in a board-specific .dts like we're going to do with the RZ/A1 MSTP driver. Can we add something like "clock-critical = <83>;" to the cpg-mssr driver? What do you think? Chris
next prev parent reply index Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-03 3:45 [PATCH 0/6] spi: Add Renesas SPIBSC controller Chris Brandt 2019-12-03 3:45 ` [PATCH 1/6] clk: renesas: mstp: Add critical clock from device tree support Chris Brandt 2019-12-03 18:32 ` Geert Uytterhoeven 2019-12-03 18:46 ` Chris Brandt 2019-12-03 18:51 ` Geert Uytterhoeven 2019-12-03 3:45 ` [PATCH 2/6] ARM: dts: r7s72100: Add SPIBSC clocks Chris Brandt 2019-12-03 18:42 ` Geert Uytterhoeven 2019-12-03 18:57 ` Chris Brandt 2019-12-03 19:12 ` Geert Uytterhoeven 2019-12-04 8:38 ` Lee Jones 2019-12-04 9:03 ` Geert Uytterhoeven 2019-12-04 9:47 ` Lee Jones 2019-12-04 11:00 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 3/6] clk: renesas: r7s9210: Add SPIBSC clock Chris Brandt 2019-12-03 18:49 ` Geert Uytterhoeven 2019-12-03 19:09 ` Chris Brandt [this message] 2019-12-03 20:40 ` Geert Uytterhoeven 2019-12-04 3:09 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 4/6] spi: Add SPIBSC driver Chris Brandt 2019-12-03 14:19 ` Mark Brown 2019-12-03 15:00 ` Chris Brandt 2019-12-03 18:29 ` Geert Uytterhoeven 2019-12-04 11:25 ` Mark Brown 2019-12-04 12:14 ` Geert Uytterhoeven 2019-12-04 15:51 ` Chris Brandt 2019-12-04 16:49 ` Mark Brown 2019-12-03 18:28 ` Geert Uytterhoeven 2019-12-04 11:18 ` Mark Brown 2019-12-04 22:12 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 5/6] ARM: dts: r7s9210: Add SPIBSC Device support Chris Brandt 2019-12-03 18:59 ` Geert Uytterhoeven 2019-12-03 22:38 ` Chris Brandt 2019-12-04 7:57 ` Geert Uytterhoeven 2019-12-04 11:04 ` Chris Brandt 2019-12-03 3:45 ` [PATCH 6/6] dt-bindings: spi: Document Renesas SPIBSC bindings Chris Brandt 2019-12-03 9:14 ` Sergei Shtylyov 2019-12-03 13:27 ` Chris Brandt 2019-12-03 16:04 ` Sergei Shtylyov 2019-12-03 16:35 ` Chris Brandt 2019-12-03 18:57 ` Geert Uytterhoeven 2019-12-03 20:39 ` Geert Uytterhoeven 2019-12-04 2:54 ` Chris Brandt 2019-12-04 8:56 ` Geert Uytterhoeven 2019-12-04 13:31 ` Chris Brandt 2019-12-05 15:48 ` Geert Uytterhoeven 2019-12-05 16:00 ` Chris Brandt 2019-12-04 8:40 ` Geert Uytterhoeven 2019-12-03 22:33 ` Chris Brandt 2019-12-04 8:43 ` Geert Uytterhoeven 2019-12-04 11:19 ` Chris Brandt
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TY1PR01MB1562D198A463C18B1D810DF48A420@TY1PR01MB1562.jpnprd01.prod.outlook.com \ --to=chris.brandt@renesas.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=geert@linux-m68k.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=masonccyang@mxic.com.tw \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sergei.shtylyov@cogentembedded.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Renesas-SoC Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \ linux-renesas-soc@vger.kernel.org public-inbox-index linux-renesas-soc Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc AGPL code for this site: git clone https://public-inbox.org/public-inbox.git