From: Sagar Kadam <sagar.kadam@sifive.com>
To: Atish Patra <atish.patra@wdc.com>
Cc: "Björn Töpel" <bjorn.topel@gmail.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"Palmer Dabbelt" <palmer@sifive.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>
Subject: Re: 5.2-rc1 boot on Unleashed
Date: Wed, 22 May 2019 10:12:30 +0530 [thread overview]
Message-ID: <CAARK3HmewOZzv-p4JxTb-Cb2PT4qqJoxFO8mhHtz=qDq8XGS9Q@mail.gmail.com> (raw)
In-Reply-To: <5c1ffb76-b18a-dbae-d3ad-f3d2cd41ee44@wdc.com>
Hi Atish,
On Tue, May 21, 2019 at 5:03 AM Atish Patra <atish.patra@wdc.com> wrote:
>
> Hi,
>
> 5.2-rc1 still requires some out-of-tree driver patches.
>
> Here is my tree (successfully tested on Unleashed.)
> https://github.com/atishp04/linux/tree/5.2-rc1_unleashed
>
> Issues:
>
> 1. Thanks to Paul, uart & clock drivers are merged. However,
> a. upstream clock drivers require DT changes
> b. Those DT changes are still being reviewed.
> c. FSBL need to be rebuild & updated for these DT changes.
>
> That's why I am still using the old out-of-tree clock drivers for now.
>
> @Paul, @Palmer: Can SiFive share the updated FSBL binary so that
> everybody can use the upstream clock drivers without having to rebuild
> FSBL by hand?
>
>
> 2. We still need the following networking hack. I had to rebase the
> patch on top of 5.2-rc1.
> -----------------------------------------------------------------
> commit 1cae94e4f38f (HEAD -> 5.2-rc1_unleashed, atishp04/5.2-rc1_unleashed)
> Author: Atish Patra <atish.patra@wdc.com>
> Date: Fri Sep 7 10:22:27 2018 -0700
>
> RISC-V: Networking fix Hack
>
> It looks like that kernel driver now supports reseting the
> signal one additional time. As it had been already reset
> twice in FSBL, PHY gets into incorrect state causing below error.
>
> ----------------------------------------------------------------------
> macb 10090000.ethernet (unnamed net_device) (uninitialized): Could
> not attach to PHY
> macb: probe of 10090000.ethernet failed with error -110
> ----------------------------------------------------------------------
>
> This patch is just a temporary fix until we have a fix a FSBL.
> It is just a **HACK** and **NOT TO BE MERGED** into mainline.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
>
> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index bd04fe762056..4b99b226c885 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -94,9 +94,6 @@ int mdiobus_register_device(struct mdio_device *mdiodev)
> err = mdiobus_register_reset(mdiodev);
> if (err)
> return err;
> -
> - /* Assert the reset signal */
> - mdio_device_reset(mdiodev, 1);
> }
>
> mdiodev->bus->mdio_map[mdiodev->addr] = mdiodev;
> -----------------------------------------------------------------
>
> Can somebody please look into this so that we can avoid this ugly hack ?
>
Yes, I will look into this and submit a patch for the same.
Thanks & BR,
Sagar Kadam
> --
> Regards,
> Atish
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-05-22 4:42 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 23:31 5.2-rc1 boot on Unleashed Atish Patra
2019-05-21 9:40 ` Andreas Schwab
2019-05-21 18:14 ` Atish Patra
2019-05-22 7:31 ` Andreas Schwab
2019-05-22 8:40 ` Andreas Schwab
2019-05-22 9:58 ` Andreas Schwab
2019-05-22 21:13 ` Paul Walmsley
2019-05-21 17:47 ` Kevin Hilman
2019-05-21 18:18 ` Atish Patra
2019-05-23 9:42 ` Andreas Schwab
2019-05-22 4:42 ` Sagar Kadam [this message]
2019-05-22 9:51 ` Atish Patra
2019-05-22 16:42 ` Paul Walmsley
2019-05-22 17:38 ` Atish Patra
2019-05-22 20:43 ` Paul Walmsley
2019-05-22 22:14 ` Troy Benjegerdes
2019-05-25 8:06 ` Anup Patel
2019-05-25 14:16 ` Troy Benjegerdes
2019-05-29 5:00 ` Anup Patel
2019-05-29 8:31 ` Andreas Schwab
2019-05-29 17:38 ` Troy Benjegerdes
2019-05-29 18:59 ` Karsten Merker
2019-05-30 17:00 ` Palmer Dabbelt
2019-06-03 10:49 ` Andreas Schwab
2019-06-03 14:44 ` Distro bootcmd: " Troy Benjegerdes
2019-06-03 17:02 ` [U-Boot] " Tom Rini
2019-06-03 19:17 ` Palmer Dabbelt
2019-06-03 19:32 ` Tom Rini
2019-06-03 19:47 ` Troy Benjegerdes
2019-05-24 0:23 ` Troy Benjegerdes
2019-05-24 3:59 ` Atish Patra
2019-05-24 14:46 ` Troy Benjegerdes
2019-05-24 15:35 ` Auer, Lukas
2019-05-24 16:01 ` Troy Benjegerdes
2019-05-24 17:40 ` Atish Patra
[not found] ` <CAF5mof3_PSwpsSMnjMALpfvmOPdeAgDLa2p6jp4y+Hmas83mbw@mail.gmail.com>
2019-05-24 21:34 ` Auer, Lukas
2019-05-25 3:49 ` Anup Patel
2019-05-25 16:23 ` Troy Benjegerdes
2019-05-25 18:09 ` Paul Walmsley
2019-05-25 18:40 ` Troy Benjegerdes
2019-05-27 12:21 ` Andreas Schwab
2019-05-27 16:51 ` Troy Benjegerdes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAARK3HmewOZzv-p4JxTb-Cb2PT4qqJoxFO8mhHtz=qDq8XGS9Q@mail.gmail.com' \
--to=sagar.kadam@sifive.com \
--cc=atish.patra@wdc.com \
--cc=bjorn.topel@gmail.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).