Re: 5.2-rc1 boot on Unleashed

From: Atish Patra <atish.patra@wdc.com>
To: Sagar Kadam <sagar.kadam@sifive.com>
Cc: "Björn Töpel" <bjorn.topel@gmail.com>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>
Subject: Re: 5.2-rc1 boot on Unleashed
Date: Wed, 22 May 2019 02:51:27 -0700	[thread overview]
Message-ID: <bd86729a-8993-4021-99a3-b0a50e9efdc5@wdc.com> (raw)
In-Reply-To: <CAARK3HmewOZzv-p4JxTb-Cb2PT4qqJoxFO8mhHtz=qDq8XGS9Q@mail.gmail.com>

On 5/21/19 9:42 PM, Sagar Kadam wrote:
> Hi Atish,
> 
> 
> On Tue, May 21, 2019 at 5:03 AM Atish Patra <atish.patra@wdc.com> wrote:
>>
>> Hi,
>>
>> 5.2-rc1 still requires some out-of-tree driver patches.
>>
>> Here is my tree (successfully tested on Unleashed.)
>> https://github.com/atishp04/linux/tree/5.2-rc1_unleashed
>>
>> Issues:
>>
>> 1. Thanks to Paul, uart & clock drivers are merged. However,
>>          a. upstream clock drivers require DT changes
>>          b. Those DT changes are still being reviewed.
>>          c. FSBL need to be rebuild & updated for these DT changes.
>>
>> That's why I am still using the old out-of-tree clock drivers for now.
>>
>> @Paul, @Palmer: Can SiFive share the updated FSBL binary so that
>> everybody can use the upstream clock drivers without having to rebuild
>> FSBL by hand?
>>
>>
>> 2. We still need the following networking hack. I had to rebase the
>> patch on top of 5.2-rc1.
>> -----------------------------------------------------------------
>> commit 1cae94e4f38f (HEAD -> 5.2-rc1_unleashed, atishp04/5.2-rc1_unleashed)
>> Author: Atish Patra <atish.patra@wdc.com>
>> Date:   Fri Sep 7 10:22:27 2018 -0700
>>
>>       RISC-V: Networking fix Hack
>>
>>       It looks like that kernel driver now supports reseting the
>>       signal one additional time. As it had been  already reset
>>       twice in FSBL, PHY gets into incorrect state causing below error.
>>
>>       ----------------------------------------------------------------------
>>       macb 10090000.ethernet (unnamed net_device) (uninitialized): Could
>> not attach to PHY
>>       macb: probe of 10090000.ethernet failed with error -110
>>       ----------------------------------------------------------------------
>>
>>       This patch is just a temporary fix until we have a fix a FSBL.
>>       It is just a **HACK** and **NOT TO BE MERGED** into mainline.
>>
>>       Signed-off-by: Atish Patra <atish.patra@wdc.com>
>>
>> diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
>> index bd04fe762056..4b99b226c885 100644
>> --- a/drivers/net/phy/mdio_bus.c
>> +++ b/drivers/net/phy/mdio_bus.c
>> @@ -94,9 +94,6 @@ int mdiobus_register_device(struct mdio_device *mdiodev)
>>                   err = mdiobus_register_reset(mdiodev);
>>                   if (err)
>>                           return err;
>> -
>> -               /* Assert the reset signal */
>> -               mdio_device_reset(mdiodev, 1);
>>           }
>>
>>           mdiodev->bus->mdio_map[mdiodev->addr] = mdiodev;
>> -----------------------------------------------------------------
>>
>> Can somebody please look into this so that we can avoid this ugly hack ?
>>
> Yes, I will look into this and submit a patch for the same.
> 

Thanks. Are you or anybody else form SiFive looking to upstream the GPIO 
driver?

I think that's the only driver remaining.

> Thanks & BR,
> Sagar Kadam
> 
>> --
>> Regards,
>> Atish
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
> 

-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv