From: Conor Dooley <conor.dooley@microchip.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Conor Dooley <conor@kernel.org>,
<linux-riscv@lists.infradead.org>, <palmer@dabbelt.com>,
<damien.lemoal@opensource.wdc.com>, <geert@linux-mk68.org>,
<heiko@sntech.de>, <kernel@esmil.dk>, <arnd@arndb.de>
Subject: Re: [RFC 01/27] clk: microchip: replace SOC_MICROCHIP_POLARFIRE with ARCH_MICROCHIP
Date: Wed, 28 Sep 2022 13:51:12 +0100 [thread overview]
Message-ID: <YzRDQKV2oaifqM6Q@wendy> (raw)
In-Reply-To: <YzQ7FSEVQCFIIEZa@infradead.org>
On Wed, Sep 28, 2022 at 05:16:21AM -0700, Christoph Hellwig wrote:
> On Fri, Sep 23, 2022 at 07:55:40PM +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> >
> > At LPC, we decided that for the sake of consistency the SOC_FOO symbols
> > in arch/riscv should be replaced with ARCH_FOO so that we could have a
> > consistent policy regardless of whether a vendor had ARM legacy or was
> > a RISC-V "incumbent".
>
> Umm, that's just stupid. The ARCH_ naming in arm is incorrect and a
> bad idea. So please move in the correct direction instead even if that
> is more work and more churn.
It's more work for me to change them to ARCH_ than leave them as SOC_.
I don't think _consistency_ is stupid, but given my OCD I am quite
biased there. What is your suggestion for moving incoming ARM vendors
"in the correct direction"?
I would be perfectly happy to change SOC_MICROCHIP_POLARFIRE to
something like SOC_MICROCHIP or SOC_MICROCHIP_FPGA and leave it there
as far as renames go, as long as beyond that there is no ARCH_ARM_VENDOR
+ SOC_ARM_VENDOR muck in the file. Would make the series considerably
smaller as all I would be doing is unifiying how the SOC_ symbols are
being used :)
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-09-28 12:52 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 18:55 [RFC 00/27] RISC-V: Convert SOC_FOO symbols to ARCH_FOO Conor Dooley
2022-09-23 18:55 ` [RFC 01/27] clk: microchip: replace SOC_MICROCHIP_POLARFIRE with ARCH_MICROCHIP Conor Dooley
2022-09-28 12:16 ` Christoph Hellwig
2022-09-28 12:51 ` Conor Dooley [this message]
2022-09-23 18:55 ` [RFC 02/27] i2c: microchip-corei2c: " Conor Dooley
2022-09-23 18:55 ` [RFC 03/27] mailbox: mpfs: " Conor Dooley
2022-09-23 18:55 ` [RFC 04/27] usb: musb: " Conor Dooley
2022-09-23 18:55 ` [RFC 05/27] rtc: " Conor Dooley
2022-09-23 18:55 ` [RFC 06/27] riscv: stop selecting the PolarFire SoC clock driver Conor Dooley
2022-09-23 18:55 ` [RFC 07/27] riscv: replace SOC_STARFIVE with ARCH_STARFIVE Conor Dooley
2022-09-23 19:09 ` Heiko Stuebner
2022-09-23 19:14 ` Conor Dooley
2022-09-23 19:20 ` Heiko Stuebner
2022-09-23 19:22 ` Conor Dooley
2022-09-23 18:55 ` [RFC 08/27] clk: starfive: " Conor Dooley
2022-09-23 18:55 ` [RFC 09/27] pinctrl: " Conor Dooley
2022-09-23 18:55 ` [RFC 10/27] reset: " Conor Dooley
2022-09-23 18:55 ` [RFC 11/27] riscv: replace SOC_SIFIVE with ARCH_SIFIVE Conor Dooley
2022-09-23 18:55 ` [RFC 12/27] soc: sifive: convert SOC_SIFIVE to ARCH_SIFIVE Conor Dooley
2022-09-23 18:55 ` [RFC 13/27] clk: " Conor Dooley
2022-09-23 18:55 ` [RFC 14/27] clk: sifive: select by default if ARCH_SIFIVE Conor Dooley
2022-09-23 18:55 ` [RFC 15/27] serial: " Conor Dooley
2022-09-23 18:55 ` [RFC 16/27] PCI: dwc: fu740: convert SOC_SIFIVE to ARCH_SIFIVE Conor Dooley
2022-09-23 18:55 ` [RFC 17/27] riscv: stop selecting SiFive clock and serial drivers directly Conor Dooley
2022-09-23 18:55 ` [RFC 18/27] riscv: convert SOC_VIRT to ARCH_VIRT Conor Dooley
2022-09-23 18:55 ` [RFC 19/27] kunit: tool: rename SOC_VIRT to ARCH_VIRT in riscv's QEMU config Conor Dooley
2022-09-23 18:55 ` [RFC 20/27] wireguard: selftests: swap SOC_VIRT for ARCH_VIRT on riscv Conor Dooley
2022-09-24 10:03 ` Jason A. Donenfeld
2022-09-23 18:56 ` [RFC 21/27] riscv: convert SOC_CANAAN to ARCH_CANAAN Conor Dooley
2022-09-23 18:56 ` [RFC 22/27] clk: k210: " Conor Dooley
2022-09-23 18:56 ` [RFC 23/27] pinctrl: " Conor Dooley
2022-09-23 18:56 ` [RFC 24/27] soc: " Conor Dooley
2022-09-23 18:56 ` [RFC 25/27] reset: " Conor Dooley
2022-09-23 18:56 ` [RFC 26/27] serial: sifive: select by default if ARCH_CANAAN Conor Dooley
2022-09-23 18:56 ` [RFC 27/27] riscv: stop directly selecting drivers for ARCH_CANAAN Conor Dooley
2022-09-23 18:59 ` [RFC 00/27] RISC-V: Convert SOC_FOO symbols to ARCH_FOO Conor Dooley
2022-09-26 1:50 ` Damien Le Moal
2022-09-26 8:02 ` Conor Dooley
2022-09-26 9:04 ` Geert Uytterhoeven
2022-09-27 6:34 ` Conor Dooley
2022-09-27 6:48 ` Arnd Bergmann
2022-09-27 6:57 ` Conor Dooley
2022-09-27 7:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzRDQKV2oaifqM6Q@wendy \
--to=conor.dooley@microchip.com \
--cc=arnd@arndb.de \
--cc=conor@kernel.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=geert@linux-mk68.org \
--cc=hch@infradead.org \
--cc=heiko@sntech.de \
--cc=kernel@esmil.dk \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).