* [PATCH v2 1/4] spi: fspi: enable fspi driver for on imx8mp
2021-03-09 5:31 [PATCH v2 0/4] enable flexspi support on imx8mp Heiko Schocher
@ 2021-03-09 5:31 ` Heiko Schocher
2021-03-09 5:31 ` [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller Heiko Schocher
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Heiko Schocher @ 2021-03-09 5:31 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Heiko Schocher, Ashish Kumar, Mark Brown, Yogesh Gaur,
linux-kernel, linux-spi
add compatible entry in nxp_fspi driver for imx8mp.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
Changes in v2:
- work in comments from Marco
add own compatible entry for imx8mp
drivers/spi/spi-nxp-fspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index ab9035662717a..19ce4a854cc97 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1151,6 +1151,7 @@ static int nxp_fspi_resume(struct device *dev)
static const struct of_device_id nxp_fspi_dt_ids[] = {
{ .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, },
{ .compatible = "nxp,imx8mm-fspi", .data = (void *)&imx8mm_data, },
+ { .compatible = "nxp,imx8mp-fspi", .data = (void *)&imx8mm_data, },
{ .compatible = "nxp,imx8qxp-fspi", .data = (void *)&imx8qxp_data, },
{ /* sentinel */ }
};
--
2.29.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
2021-03-09 5:31 [PATCH v2 0/4] enable flexspi support on imx8mp Heiko Schocher
2021-03-09 5:31 ` [PATCH v2 1/4] spi: fspi: enable fspi driver for " Heiko Schocher
@ 2021-03-09 5:31 ` Heiko Schocher
2021-03-09 5:56 ` [EXT] " Kuldeep Singh
2021-03-09 8:19 ` [PATCH v2 0/4] enable flexspi support on imx8mp Marco Felsch
2021-03-15 6:47 ` Shawn Guo
3 siblings, 1 reply; 12+ messages in thread
From: Heiko Schocher @ 2021-03-09 5:31 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Heiko Schocher, Ashish Kumar, Mark Brown, Rob Herring,
Yogesh Gaur, devicetree, linux-kernel, linux-spi
add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
Signed-off-by: Heiko Schocher <hs@denx.de>
---
(no changes since v1)
Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
index 7ac60d9fe3571..fd5f081f6d91b 100644
--- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
+++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
@@ -4,6 +4,7 @@ Required properties:
- compatible : Should be "nxp,lx2160a-fspi"
"nxp,imx8qxp-fspi"
"nxp,imx8mm-fspi"
+ "nxp,imx8mp-fspi"
- reg : First contains the register location and length,
Second contains the memory mapping address and length
--
2.29.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* RE: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
2021-03-09 5:31 ` [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller Heiko Schocher
@ 2021-03-09 5:56 ` Kuldeep Singh
2021-03-09 6:06 ` Heiko Schocher
0 siblings, 1 reply; 12+ messages in thread
From: Kuldeep Singh @ 2021-03-09 5:56 UTC (permalink / raw)
To: Heiko Schocher, linux-arm-kernel
Cc: Ashish Kumar, Mark Brown, Rob Herring, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
Hi Heiko,
> -----Original Message-----
> From: Heiko Schocher <hs@denx.de>
> Sent: Tuesday, March 9, 2021 11:01 AM
> To: linux-arm-kernel@lists.infradead.org
> Cc: Heiko Schocher <hs@denx.de>; Ashish Kumar <ashish.kumar@nxp.com>;
> Mark Brown <broonie@kernel.org>; Rob Herring <robh+dt@kernel.org>; Yogesh
> Gaur <yogeshgaur.83@gmail.com>; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-spi@vger.kernel.org
> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in
> FlexSPI controller
>
> Caution: EXT Email
>
> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>
> (no changes since v1)
>
> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> index 7ac60d9fe3571..fd5f081f6d91b 100644
> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible : Should be "nxp,lx2160a-fspi"
> "nxp,imx8qxp-fspi"
> "nxp,imx8mm-fspi"
> + "nxp,imx8mp-fspi"
It seems the changes are not on top of tree. Please see[1] for latest changes including imx8dxl entry.
Snippet below:
Required properties:
- compatible : Should be "nxp,lx2160a-fspi"
"nxp,imx8qxp-fspi"
"nxp,imx8mm-fspi"
"nxp,imx8dxl-fspi"
Thanks
Kuldeep
[1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/tree/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
2021-03-09 5:56 ` [EXT] " Kuldeep Singh
@ 2021-03-09 6:06 ` Heiko Schocher
2021-03-09 6:29 ` Kuldeep Singh
0 siblings, 1 reply; 12+ messages in thread
From: Heiko Schocher @ 2021-03-09 6:06 UTC (permalink / raw)
To: Kuldeep Singh, linux-arm-kernel
Cc: Ashish Kumar, Mark Brown, Rob Herring, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
Hi!
On 09.03.21 06:56, Kuldeep Singh wrote:
> Hi Heiko,
>
>> -----Original Message-----
>> From: Heiko Schocher <hs@denx.de>
>> Sent: Tuesday, March 9, 2021 11:01 AM
>> To: linux-arm-kernel@lists.infradead.org
>> Cc: Heiko Schocher <hs@denx.de>; Ashish Kumar <ashish.kumar@nxp.com>;
>> Mark Brown <broonie@kernel.org>; Rob Herring <robh+dt@kernel.org>; Yogesh
>> Gaur <yogeshgaur.83@gmail.com>; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-spi@vger.kernel.org
>> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in
>> FlexSPI controller
>>
>> Caution: EXT Email
>>
>> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>> ---
>>
>> (no changes since v1)
>>
>> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> index 7ac60d9fe3571..fd5f081f6d91b 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> @@ -4,6 +4,7 @@ Required properties:
>> - compatible : Should be "nxp,lx2160a-fspi"
>> "nxp,imx8qxp-fspi"
>> "nxp,imx8mm-fspi"
>> + "nxp,imx8mp-fspi"
>
> It seems the changes are not on top of tree. Please see[1] for latest changes including imx8dxl entry.
> Snippet below:
>
> Required properties:
> - compatible : Should be "nxp,lx2160a-fspi"
> "nxp,imx8qxp-fspi"
> "nxp,imx8mm-fspi"
> "nxp,imx8dxl-fspi"
My patches are based on mainline..
* 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-v5.12-2020-03-07'
of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden) <Linus Torvalds>
Should I post this patch rebased on [1] or may all patches
rebased on [1] ?
Thanks!
bye,
Heiko
>
> Thanks
> Kuldeep
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/tree/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
2021-03-09 6:06 ` Heiko Schocher
@ 2021-03-09 6:29 ` Kuldeep Singh
2021-03-09 6:44 ` Heiko Schocher
0 siblings, 1 reply; 12+ messages in thread
From: Kuldeep Singh @ 2021-03-09 6:29 UTC (permalink / raw)
To: hs, linux-arm-kernel, Mark Brown
Cc: Ashish Kumar, Rob Herring, Yogesh Gaur, devicetree, linux-kernel,
linux-spi
> Hi!
>
> On 09.03.21 06:56, Kuldeep Singh wrote:
> > Hi Heiko,
> >
> >> -----Original Message-----
> >> From: Heiko Schocher <hs@denx.de>
> >> Sent: Tuesday, March 9, 2021 11:01 AM
> >> To: linux-arm-kernel@lists.infradead.org
> >> Cc: Heiko Schocher <hs@denx.de>; Ashish Kumar <ashish.kumar@nxp.com>;
> >> Mark Brown <broonie@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> >> Yogesh Gaur <yogeshgaur.83@gmail.com>; devicetree@vger.kernel.org;
> >> linux- kernel@vger.kernel.org; linux-spi@vger.kernel.org
> >> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry
> >> for imx8mp in FlexSPI controller
> >>
> >> Caution: EXT Email
> >>
> >> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
> >>
> >> Signed-off-by: Heiko Schocher <hs@denx.de>
> >> ---
> >>
> >> (no changes since v1)
> >>
> >> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> index 7ac60d9fe3571..fd5f081f6d91b 100644
> >> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> @@ -4,6 +4,7 @@ Required properties:
> >> - compatible : Should be "nxp,lx2160a-fspi"
> >> "nxp,imx8qxp-fspi"
> >> "nxp,imx8mm-fspi"
> >> + "nxp,imx8mp-fspi"
> >
> > It seems the changes are not on top of tree. Please see[1] for latest changes
> including imx8dxl entry.
> > Snippet below:
> >
> > Required properties:
> > - compatible : Should be "nxp,lx2160a-fspi"
> > "nxp,imx8qxp-fspi"
> > "nxp,imx8mm-fspi"
> > "nxp,imx8dxl-fspi"
>
> My patches are based on mainline..
> * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-
> v5.12-2020-03-07'
> of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden)
> <Linus Torvalds>
>
> Should I post this patch rebased on [1] or may all patches rebased on [1] ?
Hi Heiko,
As per cover letter, I can identify that first two are driver/Documentation patches and other two are device-tree patches.
Device-tree patches(3/4 and 4/4) will go via Shawn tree (git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git)
And initial two driver patches(1/4 and 2/4) will go via Mark's tree (git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git)
One approach I can think of is to send driver patches first and later send device-tree patches mentioning dependency on first two patches.
Maybe Mark can comment here if he has any other opinion.
Thanks
Kuldeep
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller
2021-03-09 6:29 ` Kuldeep Singh
@ 2021-03-09 6:44 ` Heiko Schocher
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Schocher @ 2021-03-09 6:44 UTC (permalink / raw)
To: Kuldeep Singh, linux-arm-kernel, Mark Brown
Cc: Ashish Kumar, Rob Herring, Yogesh Gaur, devicetree, linux-kernel,
linux-spi
Hello Kuldeep,
On 09.03.21 07:29, Kuldeep Singh wrote:
>> Hi!
>>
>> On 09.03.21 06:56, Kuldeep Singh wrote:
>>> Hi Heiko,
>>>
>>>> -----Original Message-----
>>>> From: Heiko Schocher <hs@denx.de>
>>>> Sent: Tuesday, March 9, 2021 11:01 AM
>>>> To: linux-arm-kernel@lists.infradead.org
>>>> Cc: Heiko Schocher <hs@denx.de>; Ashish Kumar <ashish.kumar@nxp.com>;
>>>> Mark Brown <broonie@kernel.org>; Rob Herring <robh+dt@kernel.org>;
>>>> Yogesh Gaur <yogeshgaur.83@gmail.com>; devicetree@vger.kernel.org;
>>>> linux- kernel@vger.kernel.org; linux-spi@vger.kernel.org
>>>> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry
>>>> for imx8mp in FlexSPI controller
>>>>
>>>> Caution: EXT Email
>>>>
>>>> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
>>>>
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>> ---
>>>>
>>>> (no changes since v1)
>>>>
>>>> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> index 7ac60d9fe3571..fd5f081f6d91b 100644
>>>> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> @@ -4,6 +4,7 @@ Required properties:
>>>> - compatible : Should be "nxp,lx2160a-fspi"
>>>> "nxp,imx8qxp-fspi"
>>>> "nxp,imx8mm-fspi"
>>>> + "nxp,imx8mp-fspi"
>>>
>>> It seems the changes are not on top of tree. Please see[1] for latest changes
>> including imx8dxl entry.
>>> Snippet below:
>>>
>>> Required properties:
>>> - compatible : Should be "nxp,lx2160a-fspi"
>>> "nxp,imx8qxp-fspi"
>>> "nxp,imx8mm-fspi"
>>> "nxp,imx8dxl-fspi"
>>
>> My patches are based on mainline..
>> * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-
>> v5.12-2020-03-07'
>> of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden)
>> <Linus Torvalds>
>>
>> Should I post this patch rebased on [1] or may all patches rebased on [1] ?
>
> Hi Heiko,
>
> As per cover letter, I can identify that first two are driver/Documentation patches and other two are device-tree patches.
> Device-tree patches(3/4 and 4/4) will go via Shawn tree (git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git)
> And initial two driver patches(1/4 and 2/4) will go via Mark's tree (git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git)
>
> One approach I can think of is to send driver patches first and later send device-tree patches mentioning dependency on first two patches.
Yep, seems a good approach to me.
> Maybe Mark can comment here if he has any other opinion.
Yep, will wait for more comments, and if all is fine with this
patchset, I can split it into 2 series.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/4] enable flexspi support on imx8mp
2021-03-09 5:31 [PATCH v2 0/4] enable flexspi support on imx8mp Heiko Schocher
2021-03-09 5:31 ` [PATCH v2 1/4] spi: fspi: enable fspi driver for " Heiko Schocher
2021-03-09 5:31 ` [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller Heiko Schocher
@ 2021-03-09 8:19 ` Marco Felsch
2021-03-09 8:41 ` Heiko Schocher
2021-03-15 6:47 ` Shawn Guo
3 siblings, 1 reply; 12+ messages in thread
From: Marco Felsch @ 2021-03-09 8:19 UTC (permalink / raw)
To: Heiko Schocher
Cc: linux-arm-kernel, Alice Guo, Anson Huang, Ashish Kumar,
Dong Aisheng, Fabio Estevam, Horia Geantă,
Jacky Bai, Joakim Zhang, Krzysztof Kozlowski, Li Jun, Mark Brown,
NXP Linux Team, Peng Fan, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Shawn Guo, Teresa Remmet, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
Hi Heiko,
On 21-03-09 06:31, Heiko Schocher wrote:
>
> This series enables support for the SPI NOR on the
> imx8mp based phyboard-pollux-rdk board.
>
> Patches new in v2:
> "spi: fspi: enable fspi driver for on imx8mp"
> which adds own compatible entry for imx8mp
>
> and seperate in own patch the documentation entry in
> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
> as checkpatch says:
>
> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
Thanks for picking up the comments :) Did you missed to send them or did
you used an other Cc: and To: for the new patches?
Regards,
Marco
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/4] enable flexspi support on imx8mp
2021-03-09 8:19 ` [PATCH v2 0/4] enable flexspi support on imx8mp Marco Felsch
@ 2021-03-09 8:41 ` Heiko Schocher
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Schocher @ 2021-03-09 8:41 UTC (permalink / raw)
To: Marco Felsch
Cc: linux-arm-kernel, Alice Guo, Anson Huang, Ashish Kumar,
Dong Aisheng, Fabio Estevam, Horia Geantă,
Jacky Bai, Joakim Zhang, Krzysztof Kozlowski, Li Jun, Mark Brown,
NXP Linux Team, Peng Fan, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Shawn Guo, Teresa Remmet, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
Hello Marco,
On 09.03.21 09:19, Marco Felsch wrote:
> Hi Heiko,
>
> On 21-03-09 06:31, Heiko Schocher wrote:
>>
>> This series enables support for the SPI NOR on the
>> imx8mp based phyboard-pollux-rdk board.
>>
>> Patches new in v2:
>> "spi: fspi: enable fspi driver for on imx8mp"
>> which adds own compatible entry for imx8mp
>>
>> and seperate in own patch the documentation entry in
>> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
>> as checkpatch says:
>>
>> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
> Thanks for picking up the comments :) Did you missed to send them or did
> you used an other Cc: and To: for the new patches?
Damn, I use patman tool from u-boot source whoch generates cc list
and missed to add you explicitely to Cc... sorry
They are all on linux-arm-kernel:
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643290.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643291.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643292.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643293.html
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/4] enable flexspi support on imx8mp
2021-03-09 5:31 [PATCH v2 0/4] enable flexspi support on imx8mp Heiko Schocher
` (2 preceding siblings ...)
2021-03-09 8:19 ` [PATCH v2 0/4] enable flexspi support on imx8mp Marco Felsch
@ 2021-03-15 6:47 ` Shawn Guo
2021-03-15 7:10 ` Heiko Schocher
3 siblings, 1 reply; 12+ messages in thread
From: Shawn Guo @ 2021-03-15 6:47 UTC (permalink / raw)
To: Heiko Schocher
Cc: linux-arm-kernel, Alice Guo, Anson Huang, Ashish Kumar,
Dong Aisheng, Fabio Estevam, Horia Geantă,
Jacky Bai, Joakim Zhang, Krzysztof Kozlowski, Li Jun, Mark Brown,
NXP Linux Team, Peng Fan, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Teresa Remmet, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
>
> This series enables support for the SPI NOR on the
> imx8mp based phyboard-pollux-rdk board.
>
> Patches new in v2:
> "spi: fspi: enable fspi driver for on imx8mp"
> which adds own compatible entry for imx8mp
>
> and seperate in own patch the documentation entry in
> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
> as checkpatch says:
>
> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
>
> Changes in v2:
> - work in comments from Marco
> add own compatible entry for imx8mp
> - work in comments from Marco
> - add own compatible entry "nxp,imx8mp-fspi"
> - reworked order of properties as Marco mentioned
> - work in comments from Marco and Teresa
> - rename node into "'som_flash: flash@0 { }"
> - compatible is now first entry
> - removed #size-cells and #address-cells
> as no child node. If bootloader adds them bootloader
> can add them too.
>
> Heiko Schocher (4):
> spi: fspi: enable fspi driver for on imx8mp
> dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
> controller
> arm64: dts: imx8mp: add flexspi node
> arm64: imx8mp: imx8mp-phycore-som enable spi nor
Two DTS patch look good. Ping me when driver and bindings changes are
accepted.
Shawn
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 0/4] enable flexspi support on imx8mp
2021-03-15 6:47 ` Shawn Guo
@ 2021-03-15 7:10 ` Heiko Schocher
2021-03-15 7:17 ` Shawn Guo
0 siblings, 1 reply; 12+ messages in thread
From: Heiko Schocher @ 2021-03-15 7:10 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, Alice Guo, Anson Huang, Ashish Kumar,
Dong Aisheng, Fabio Estevam, Horia Geantă,
Jacky Bai, Joakim Zhang, Krzysztof Kozlowski, Li Jun, Mark Brown,
NXP Linux Team, Peng Fan, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Teresa Remmet, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
Hello Shawn,
On 15.03.21 07:47, Shawn Guo wrote:
> On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
>>
>> This series enables support for the SPI NOR on the
>> imx8mp based phyboard-pollux-rdk board.
>>
>> Patches new in v2:
>> "spi: fspi: enable fspi driver for on imx8mp"
>> which adds own compatible entry for imx8mp
>>
>> and seperate in own patch the documentation entry in
>> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
>> as checkpatch says:
>>
>> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>>
>>
>> Changes in v2:
>> - work in comments from Marco
>> add own compatible entry for imx8mp
>> - work in comments from Marco
>> - add own compatible entry "nxp,imx8mp-fspi"
>> - reworked order of properties as Marco mentioned
>> - work in comments from Marco and Teresa
>> - rename node into "'som_flash: flash@0 { }"
>> - compatible is now first entry
>> - removed #size-cells and #address-cells
>> as no child node. If bootloader adds them bootloader
>> can add them too.
>>
>> Heiko Schocher (4):
>> spi: fspi: enable fspi driver for on imx8mp
>> dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
>> controller
>> arm64: dts: imx8mp: add flexspi node
>> arm64: imx8mp: imx8mp-phycore-som enable spi nor
>
> Two DTS patch look good. Ping me when driver and bindings changes are
> accepted.
Thanks!
Hmm.. I have not splitted this series into 2 series... should I do
this now?
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs@denx.de
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v2 0/4] enable flexspi support on imx8mp
2021-03-15 7:10 ` Heiko Schocher
@ 2021-03-15 7:17 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-03-15 7:17 UTC (permalink / raw)
To: Heiko Schocher
Cc: linux-arm-kernel, Alice Guo, Anson Huang, Ashish Kumar,
Dong Aisheng, Fabio Estevam, Horia Geantă,
Jacky Bai, Joakim Zhang, Krzysztof Kozlowski, Li Jun, Mark Brown,
NXP Linux Team, Peng Fan, Pengutronix Kernel Team, Rob Herring,
Sascha Hauer, Teresa Remmet, Yogesh Gaur, devicetree,
linux-kernel, linux-spi
On Mon, Mar 15, 2021 at 08:10:37AM +0100, Heiko Schocher wrote:
> Hello Shawn,
>
> On 15.03.21 07:47, Shawn Guo wrote:
> > On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
> >>
> >> This series enables support for the SPI NOR on the
> >> imx8mp based phyboard-pollux-rdk board.
> >>
> >> Patches new in v2:
> >> "spi: fspi: enable fspi driver for on imx8mp"
> >> which adds own compatible entry for imx8mp
> >>
> >> and seperate in own patch the documentation entry in
> >> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
> >> as checkpatch says:
> >>
> >> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
> >>
> >>
> >> Changes in v2:
> >> - work in comments from Marco
> >> add own compatible entry for imx8mp
> >> - work in comments from Marco
> >> - add own compatible entry "nxp,imx8mp-fspi"
> >> - reworked order of properties as Marco mentioned
> >> - work in comments from Marco and Teresa
> >> - rename node into "'som_flash: flash@0 { }"
> >> - compatible is now first entry
> >> - removed #size-cells and #address-cells
> >> as no child node. If bootloader adds them bootloader
> >> can add them too.
> >>
> >> Heiko Schocher (4):
> >> spi: fspi: enable fspi driver for on imx8mp
> >> dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
> >> controller
> >> arm64: dts: imx8mp: add flexspi node
> >> arm64: imx8mp: imx8mp-phycore-som enable spi nor
> >
> > Two DTS patch look good. Ping me when driver and bindings changes are
> > accepted.
>
> Thanks!
>
> Hmm.. I have not splitted this series into 2 series... should I do
> this now?
No, you do not need to. I sent the message only because I didn't
receive patch #1 and #2, so I will not be aware of their status.
Shawn
^ permalink raw reply [flat|nested] 12+ messages in thread