[parent not found: <1479919031-5112-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>]
* [PATCH 1/4] spi: spi-axi: Fix module autoload
[not found] ` <1479919031-5112-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
@ 2016-11-23 16:37 ` Javier Martinez Canillas
[not found] ` <1479919031-5112-2-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Javier Martinez Canillas @ 2016-11-23 16:37 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Javier Martinez Canillas, Mark Brown, linux-spi-u79uwXL29TY76Z2rM5mHXA
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-axi-spi-engine.ko | grep alias
$
After this patch:
$ modinfo drivers/spi/spi-axi-spi-engine.ko | grep alias
alias: of:N*T*Cadi,axi-spi-engine-1.00.aC*
alias: of:N*T*Cadi,axi-spi-engine-1.00.a
Signed-off-by: Javier Martinez Canillas <javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
---
drivers/spi/spi-axi-spi-engine.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c
index 2b1456e5e221..319225d7e761 100644
--- a/drivers/spi/spi-axi-spi-engine.c
+++ b/drivers/spi/spi-axi-spi-engine.c
@@ -574,6 +574,7 @@ static const struct of_device_id spi_engine_match_table[] = {
{ .compatible = "adi,axi-spi-engine-1.00.a" },
{ },
};
+MODULE_DEVICE_TABLE(of, spi_engine_match_table);
static struct platform_driver spi_engine_driver = {
.probe = spi_engine_probe,
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/4] spi: jcore: Fix module autoload for OF registration
2016-11-23 16:37 [PATCH 0/4] spi: Fix module autoload for different platform drivers Javier Martinez Canillas
[not found] ` <1479919031-5112-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
@ 2016-11-23 16:37 ` Javier Martinez Canillas
2016-11-25 13:10 ` Applied "spi: jcore: Fix module autoload for OF registration" to the spi tree Mark Brown
2016-11-23 16:37 ` [PATCH 3/4] spi: xlp: Fix module autoload for OF registration Javier Martinez Canillas
2016-11-23 16:37 ` [PATCH 4/4] spi: ath79: Fix module autoload for OF registration Javier Martinez Canillas
3 siblings, 1 reply; 9+ messages in thread
From: Javier Martinez Canillas @ 2016-11-23 16:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Mark Brown, linux-spi
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-jcore.ko | grep alias
alias: platform:jcore_spi
After this patch:
$ modinfo drivers/spi/spi-jcore.ko | grep alias
alias: platform:jcore_spi
alias: of:N*T*Cjcore,spi2C*
alias: of:N*T*Cjcore,spi2
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/spi/spi-jcore.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-jcore.c b/drivers/spi/spi-jcore.c
index f8117b80fa22..cebfea5faa4b 100644
--- a/drivers/spi/spi-jcore.c
+++ b/drivers/spi/spi-jcore.c
@@ -214,6 +214,7 @@ static const struct of_device_id jcore_spi_of_match[] = {
{ .compatible = "jcore,spi2" },
{},
};
+MODULE_DEVICE_TABLE(of, jcore_spi_of_match);
static struct platform_driver jcore_spi_driver = {
.probe = jcore_spi_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Applied "spi: jcore: Fix module autoload for OF registration" to the spi tree
2016-11-23 16:37 ` [PATCH 2/4] spi: jcore: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-11-25 13:10 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2016-11-25 13:10 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: Mark Brown, linux-kernel, Mark Brown, linux-spi
The patch
spi: jcore: Fix module autoload for OF registration
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From aa12c1ab8bb21c9e83bcc92eb75928170f24e666 Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javier@osg.samsung.com>
Date: Wed, 23 Nov 2016 13:37:09 -0300
Subject: [PATCH] spi: jcore: Fix module autoload for OF registration
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-jcore.ko | grep alias
alias: platform:jcore_spi
After this patch:
$ modinfo drivers/spi/spi-jcore.ko | grep alias
alias: platform:jcore_spi
alias: of:N*T*Cjcore,spi2C*
alias: of:N*T*Cjcore,spi2
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-jcore.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-jcore.c b/drivers/spi/spi-jcore.c
index f8117b80fa22..cebfea5faa4b 100644
--- a/drivers/spi/spi-jcore.c
+++ b/drivers/spi/spi-jcore.c
@@ -214,6 +214,7 @@ static const struct of_device_id jcore_spi_of_match[] = {
{ .compatible = "jcore,spi2" },
{},
};
+MODULE_DEVICE_TABLE(of, jcore_spi_of_match);
static struct platform_driver jcore_spi_driver = {
.probe = jcore_spi_probe,
--
2.10.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/4] spi: xlp: Fix module autoload for OF registration
2016-11-23 16:37 [PATCH 0/4] spi: Fix module autoload for different platform drivers Javier Martinez Canillas
[not found] ` <1479919031-5112-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-11-23 16:37 ` [PATCH 2/4] spi: jcore: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-11-23 16:37 ` Javier Martinez Canillas
2016-11-25 13:10 ` Applied "spi: xlp: Fix module autoload for OF registration" to the spi tree Mark Brown
2016-11-23 16:37 ` [PATCH 4/4] spi: ath79: Fix module autoload for OF registration Javier Martinez Canillas
3 siblings, 1 reply; 9+ messages in thread
From: Javier Martinez Canillas @ 2016-11-23 16:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Mark Brown, linux-spi
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-xlp.ko | grep alias
alias: acpi*:BRCM900D:*
After this patch:
$ modinfo drivers/spi/spi-xlp.ko | grep alias
alias: acpi*:BRCM900D:*
alias: of:N*T*Cnetlogic,xlp832-spiC*
alias: of:N*T*Cnetlogic,xlp832-spi
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/spi/spi-xlp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-xlp.c b/drivers/spi/spi-xlp.c
index 4071a729eb2f..bea7a93a6046 100644
--- a/drivers/spi/spi-xlp.c
+++ b/drivers/spi/spi-xlp.c
@@ -451,6 +451,7 @@ static const struct of_device_id xlp_spi_dt_id[] = {
{ .compatible = "netlogic,xlp832-spi" },
{ },
};
+MODULE_DEVICE_TABLE(of, xlp_spi_dt_id);
static struct platform_driver xlp_spi_driver = {
.probe = xlp_spi_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Applied "spi: xlp: Fix module autoload for OF registration" to the spi tree
2016-11-23 16:37 ` [PATCH 3/4] spi: xlp: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-11-25 13:10 ` Mark Brown
0 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2016-11-25 13:10 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: Mark Brown, linux-kernel, Mark Brown, linux-spi
The patch
spi: xlp: Fix module autoload for OF registration
has been applied to the spi tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From b87c701b660f60cdb50a8613161b1037535e09b0 Mon Sep 17 00:00:00 2001
From: Javier Martinez Canillas <javier@osg.samsung.com>
Date: Wed, 23 Nov 2016 13:37:10 -0300
Subject: [PATCH] spi: xlp: Fix module autoload for OF registration
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-xlp.ko | grep alias
alias: acpi*:BRCM900D:*
After this patch:
$ modinfo drivers/spi/spi-xlp.ko | grep alias
alias: acpi*:BRCM900D:*
alias: of:N*T*Cnetlogic,xlp832-spiC*
alias: of:N*T*Cnetlogic,xlp832-spi
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-xlp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-xlp.c b/drivers/spi/spi-xlp.c
index 4071a729eb2f..bea7a93a6046 100644
--- a/drivers/spi/spi-xlp.c
+++ b/drivers/spi/spi-xlp.c
@@ -451,6 +451,7 @@ static const struct of_device_id xlp_spi_dt_id[] = {
{ .compatible = "netlogic,xlp832-spi" },
{ },
};
+MODULE_DEVICE_TABLE(of, xlp_spi_dt_id);
static struct platform_driver xlp_spi_driver = {
.probe = xlp_spi_probe,
--
2.10.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 4/4] spi: ath79: Fix module autoload for OF registration
2016-11-23 16:37 [PATCH 0/4] spi: Fix module autoload for different platform drivers Javier Martinez Canillas
` (2 preceding siblings ...)
2016-11-23 16:37 ` [PATCH 3/4] spi: xlp: Fix module autoload for OF registration Javier Martinez Canillas
@ 2016-11-23 16:37 ` Javier Martinez Canillas
[not found] ` <1479919031-5112-5-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
3 siblings, 1 reply; 9+ messages in thread
From: Javier Martinez Canillas @ 2016-11-23 16:37 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Mark Brown, linux-spi
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/spi/spi-ath79.ko | grep alias
alias: platform:ath79-spi
After this patch:
$ modinfo drivers/spi/spi-ath79.ko | grep alias
alias: platform:ath79-spi
alias: of:N*T*Cqca,ar7100-spiC*
alias: of:N*T*Cqca,ar7100-spi
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/spi/spi-ath79.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c
index 6165bf21d427..f369174fbd88 100644
--- a/drivers/spi/spi-ath79.c
+++ b/drivers/spi/spi-ath79.c
@@ -304,6 +304,7 @@ static const struct of_device_id ath79_spi_of_match[] = {
{ .compatible = "qca,ar7100-spi", },
{ },
};
+MODULE_DEVICE_TABLE(of, ath79_spi_of_match);
static struct platform_driver ath79_spi_driver = {
.probe = ath79_spi_probe,
--
2.7.4
^ permalink raw reply related [flat|nested] 9+ messages in thread