[PATCH 2/2] staging: rtl8192e: removes blank line

[PATCH 2/2] staging: rtl8192e: removes blank line

[Aruna Hewapathirane]

This patch fixes a checkpatch CHECK issue
CHECK: Please don't use multiple blank lines

Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
---
 drivers/staging/rtl8192e/rtllib_tx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index d5275319a486..f651947f6b44 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 					tcb_desc->bTxDisableRateFallBack = 1;
 				}
 
-
 				tcb_desc->RATRIndex = 7;
 				tcb_desc->bTxUseDriverAssingedRate = 1;
 				tcb_desc->bdhcp = 1;
-- 
2.30.2

Re: [PATCH 2/2] staging: rtl8192e: removes blank line

[Philipp Hortmann]

On 9/19/22 15:58, Aruna Hewapathirane wrote:
> This patch fixes a checkpatch CHECK issue
> CHECK: Please don't use multiple blank lines
> 
> Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index d5275319a486..f651947f6b44 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
>   					tcb_desc->bTxDisableRateFallBack = 1;
>   				}
>   
> -
>   				tcb_desc->RATRIndex = 7;
>   				tcb_desc->bTxUseDriverAssingedRate = 1;
>   				tcb_desc->bdhcp = 1;

Please avoid the 2/2 in the subject. This is only for patch series.
Create a version 2 of this patch with change history.
Removing blank lines is OK but do this for the entire document.
Add the file name to the subject to make it more unique.

Bye Philipp

Re: [PATCH 2/2] staging: rtl8192e: removes blank line

[Aruna Hewapathirane]

On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> > ---
> >   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> >                                       tcb_desc->bTxDisableRateFallBack = 1;
> >                               }
> >
> > -
> >                               tcb_desc->RATRIndex = 7;
> >                               tcb_desc->bTxUseDriverAssingedRate = 1;
> >                               tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.

I will do so in future I did not know this. My apologies.

> Create a version 2 of this patch with change history.

I have no idea how to create a version2 with a change history but I am
going to Google and see what I can find.

> Removing blank lines is OK but do this for the entire document.

Ah.. of course makes  sense. Once again my apologies.

> Add the file name to the subject to make it more unique.

I will do so. Thank you Philipp.

>
>
> Bye Philipp


On Mon, Sep 19, 2022 at 2:41 PM Philipp Hortmann
<philipp.g.hortmann@gmail.com> wrote:
>
> On 9/19/22 15:58, Aruna Hewapathirane wrote:
> > This patch fixes a checkpatch CHECK issue
> > CHECK: Please don't use multiple blank lines
> >
> > Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> > ---
> >   drivers/staging/rtl8192e/rtllib_tx.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> > index d5275319a486..f651947f6b44 100644
> > --- a/drivers/staging/rtl8192e/rtllib_tx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> > @@ -920,7 +920,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
> >                                       tcb_desc->bTxDisableRateFallBack = 1;
> >                               }
> >
> > -
> >                               tcb_desc->RATRIndex = 7;
> >                               tcb_desc->bTxUseDriverAssingedRate = 1;
> >                               tcb_desc->bdhcp = 1;
>
> Please avoid the 2/2 in the subject. This is only for patch series.
> Create a version 2 of this patch with change history.
> Removing blank lines is OK but do this for the entire document.
> Add the file name to the subject to make it more unique.
>
> Bye Philipp