linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
@ 2021-06-03 14:42 Suman Anna
  2021-06-04  4:55 ` Wilken Gottwalt
  2021-06-07 13:19 ` Rob Herring
  0 siblings, 2 replies; 6+ messages in thread
From: Suman Anna @ 2021-06-03 14:42 UTC (permalink / raw)
  To: Bjorn Andersson, Wilken Gottwalt
  Cc: Rob Herring, Mathieu Poirier, Maxime Ripard, Chen-Yu Tsai,
	devicetree, linux-remoteproc, linux-sunxi, linux-arm-kernel,
	linux-kernel, Suman Anna

The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
$id and fails to compile the example due to undefined args specifier
values for clocks and resets. Fix both of these issues.

Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Wilken,

This fixes the warnings for now on linux-next, but I think the example
should be including sun6i-a31-ccu.h files instead to be accurate, and
those files are missing the definitions for CLK_BUS_SPINLOCK and
RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
patch on top.

regards
Suman

 .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
index 733c3d01e56c..10e5a53e447b 100644
--- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
+$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
@@ -36,6 +36,9 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
+    #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
+
     hwlock@1c18000 {
         compatible = "allwinner,sun6i-a31-hwspinlock";
         reg = <0x01c18000 0x1000>;
-- 
2.30.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
  2021-06-03 14:42 [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding Suman Anna
@ 2021-06-04  4:55 ` Wilken Gottwalt
  2021-06-04  6:14   ` Suman Anna
  2021-06-07 13:19 ` Rob Herring
  1 sibling, 1 reply; 6+ messages in thread
From: Wilken Gottwalt @ 2021-06-04  4:55 UTC (permalink / raw)
  To: Suman Anna
  Cc: Bjorn Andersson, Rob Herring, Mathieu Poirier, Maxime Ripard,
	Chen-Yu Tsai, devicetree, linux-remoteproc, linux-sunxi,
	linux-arm-kernel, linux-kernel

On Thu, 3 Jun 2021 09:42:16 -0500
Suman Anna <s-anna@ti.com> wrote:

> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> $id and fails to compile the example due to undefined args specifier
> values for clocks and resets. Fix both of these issues.
> 
> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Wilken,
> 
> This fixes the warnings for now on linux-next, but I think the example
> should be including sun6i-a31-ccu.h files instead to be accurate, and
> those files are missing the definitions for CLK_BUS_SPINLOCK and
> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> patch on top.
> 
> regards
> Suman

Hi Suman,

thank you for fixing this. I would have fix it the same way for now, so it is
fine for me. But I will keep an eye on it.

greetings,
Will

>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index
> 733c3d01e56c..10e5a53e447b 100644 ---
> a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++
> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@
>  # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
>  title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
> @@ -36,6 +36,9 @@ additionalProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
> +    #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
> +
>      hwlock@1c18000 {
>          compatible = "allwinner,sun6i-a31-hwspinlock";
>          reg = <0x01c18000 0x1000>;


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
  2021-06-04  4:55 ` Wilken Gottwalt
@ 2021-06-04  6:14   ` Suman Anna
  0 siblings, 0 replies; 6+ messages in thread
From: Suman Anna @ 2021-06-04  6:14 UTC (permalink / raw)
  To: Wilken Gottwalt
  Cc: Bjorn Andersson, Rob Herring, Mathieu Poirier, Maxime Ripard,
	Chen-Yu Tsai, devicetree, linux-remoteproc, linux-sunxi,
	linux-arm-kernel, linux-kernel

On 6/3/21 11:55 PM, Wilken Gottwalt wrote:
> On Thu, 3 Jun 2021 09:42:16 -0500
> Suman Anna <s-anna@ti.com> wrote:
> 
>> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
>> $id and fails to compile the example due to undefined args specifier
>> values for clocks and resets. Fix both of these issues.
>>
>> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> Hi Wilken,
>>
>> This fixes the warnings for now on linux-next, but I think the example
>> should be including sun6i-a31-ccu.h files instead to be accurate, and
>> those files are missing the definitions for CLK_BUS_SPINLOCK and
>> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
>> patch on top.
>>
>> regards
>> Suman
> 
> Hi Suman,
> 
> thank you for fixing this. I would have fix it the same way for now, so it is
> fine for me. But I will keep an eye on it.

Thanks Will.

Bjorn,
Do ignore the RFC tag then, and you can pick up the patch.

regards
Suman


> 
> greetings,
> Will
> 
>>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
>> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml index
>> 733c3d01e56c..10e5a53e447b 100644 ---
>> a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml +++
>> b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml @@ -1,7 +1,7 @@
>>  # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>>  %YAML 1.2
>>  ---
>> -$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
>> +$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
>>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>>  
>>  title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
>> @@ -36,6 +36,9 @@ additionalProperties: false
>>  
>>  examples:
>>    - |
>> +    #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
>> +    #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
>> +
>>      hwlock@1c18000 {
>>          compatible = "allwinner,sun6i-a31-hwspinlock";
>>          reg = <0x01c18000 0x1000>;
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
  2021-06-03 14:42 [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding Suman Anna
  2021-06-04  4:55 ` Wilken Gottwalt
@ 2021-06-07 13:19 ` Rob Herring
  2021-06-14 19:15   ` Suman Anna
  1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-06-07 13:19 UTC (permalink / raw)
  To: Suman Anna
  Cc: Bjorn Andersson, Wilken Gottwalt, Mathieu Poirier, Maxime Ripard,
	Chen-Yu Tsai, devicetree,
	open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM, linux-sunxi,
	linux-arm-kernel, linux-kernel

On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <s-anna@ti.com> wrote:
>
> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> $id and fails to compile the example due to undefined args specifier
> values for clocks and resets. Fix both of these issues.
>
> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Wilken,
>
> This fixes the warnings for now on linux-next, but I think the example
> should be including sun6i-a31-ccu.h files instead to be accurate, and
> those files are missing the definitions for CLK_BUS_SPINLOCK and
> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> patch on top.
>
> regards
> Suman
>
>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
  2021-06-07 13:19 ` Rob Herring
@ 2021-06-14 19:15   ` Suman Anna
  2021-06-14 21:24     ` Bjorn Andersson
  0 siblings, 1 reply; 6+ messages in thread
From: Suman Anna @ 2021-06-14 19:15 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Wilken Gottwalt, Mathieu Poirier, Maxime Ripard, Chen-Yu Tsai,
	devicetree, open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM,
	linux-sunxi, linux-arm-kernel, linux-kernel, Rob Herring

Hi Bjorn,

On 6/7/21 8:19 AM, Rob Herring wrote:
> On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <s-anna@ti.com> wrote:
>>
>> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
>> $id and fails to compile the example due to undefined args specifier
>> values for clocks and resets. Fix both of these issues.
>>
>> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> Hi Wilken,
>>
>> This fixes the warnings for now on linux-next, but I think the example
>> should be including sun6i-a31-ccu.h files instead to be accurate, and
>> those files are missing the definitions for CLK_BUS_SPINLOCK and
>> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
>> patch on top.
>>
>> regards
>> Suman
>>
>>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 

Gentle ping, can you pick up this patch and the remoteproc pas binding
indentations fixes please so that linux-next is sane w.r.t these?

regards
Suman

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
  2021-06-14 19:15   ` Suman Anna
@ 2021-06-14 21:24     ` Bjorn Andersson
  0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-06-14 21:24 UTC (permalink / raw)
  To: Suman Anna
  Cc: Wilken Gottwalt, Mathieu Poirier, Maxime Ripard, Chen-Yu Tsai,
	devicetree, open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM,
	linux-sunxi, linux-arm-kernel, linux-kernel, Rob Herring

On Mon 14 Jun 14:15 CDT 2021, Suman Anna wrote:

> Hi Bjorn,
> 
> On 6/7/21 8:19 AM, Rob Herring wrote:
> > On Thu, Jun 3, 2021 at 9:42 AM Suman Anna <s-anna@ti.com> wrote:
> >>
> >> The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
> >> $id and fails to compile the example due to undefined args specifier
> >> values for clocks and resets. Fix both of these issues.
> >>
> >> Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
> >> Signed-off-by: Suman Anna <s-anna@ti.com>
> >> ---
> >> Hi Wilken,
> >>
> >> This fixes the warnings for now on linux-next, but I think the example
> >> should be including sun6i-a31-ccu.h files instead to be accurate, and
> >> those files are missing the definitions for CLK_BUS_SPINLOCK and
> >> RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
> >> patch on top.
> >>
> >> regards
> >> Suman
> >>
> >>  .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> > 
> 
> Gentle ping, can you pick up this patch and the remoteproc pas binding
> indentations fixes please so that linux-next is sane w.r.t these?
> 

Sorry, I picked up some (biological) bug and haven't been of much use
the last couple of weeks. I've picked the two patches now, thank you
Suman!

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-14 21:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 14:42 [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding Suman Anna
2021-06-04  4:55 ` Wilken Gottwalt
2021-06-04  6:14   ` Suman Anna
2021-06-07 13:19 ` Rob Herring
2021-06-14 19:15   ` Suman Anna
2021-06-14 21:24     ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).