linux-sunxi.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding
@ 2021-06-03 14:42 Suman Anna
  2021-06-04  4:55 ` Wilken Gottwalt
  2021-06-07 13:19 ` Rob Herring
  0 siblings, 2 replies; 6+ messages in thread
From: Suman Anna @ 2021-06-03 14:42 UTC (permalink / raw)
  To: Bjorn Andersson, Wilken Gottwalt
  Cc: Rob Herring, Mathieu Poirier, Maxime Ripard, Chen-Yu Tsai,
	devicetree, linux-remoteproc, linux-sunxi, linux-arm-kernel,
	linux-kernel, Suman Anna

The allwinner,sun6i-a31-hwspinlock.yaml binding has a mismatched
$id and fails to compile the example due to undefined args specifier
values for clocks and resets. Fix both of these issues.

Fixes: f9e784dcb63f ("dt-bindings: hwlock: add sun6i_hwspinlock")
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Wilken,

This fixes the warnings for now on linux-next, but I think the example
should be including sun6i-a31-ccu.h files instead to be accurate, and
those files are missing the definitions for CLK_BUS_SPINLOCK and
RST_BUS_SPINLOCK. Feel free to send a newer version or do an incremental
patch on top.

regards
Suman

 .../bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml      | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
index 733c3d01e56c..10e5a53e447b 100644
--- a/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
+++ b/Documentation/devicetree/bindings/hwlock/allwinner,sun6i-a31-hwspinlock.yaml
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-hwspinlock.yaml#
+$id: http://devicetree.org/schemas/hwlock/allwinner,sun6i-a31-hwspinlock.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: SUN6I hardware spinlock driver for Allwinner sun6i compatible SoCs
@@ -36,6 +36,9 @@ additionalProperties: false
 
 examples:
   - |
+    #include <dt-bindings/clock/sun8i-a23-a33-ccu.h>
+    #include <dt-bindings/reset/sun8i-a23-a33-ccu.h>
+
     hwlock@1c18000 {
         compatible = "allwinner,sun6i-a31-hwspinlock";
         reg = <0x01c18000 0x1000>;
-- 
2.30.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-14 21:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 14:42 [RFC PATCH] dt-bindings: hwlock: sun6i: Fix various warnings in binding Suman Anna
2021-06-04  4:55 ` Wilken Gottwalt
2021-06-04  6:14   ` Suman Anna
2021-06-07 13:19 ` Rob Herring
2021-06-14 19:15   ` Suman Anna
2021-06-14 21:24     ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).