From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sumit Gupta <sumitg@nvidia.com>,
treding@nvidia.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Cc: bbasu@nvidia.com, talho@nvidia.com,
Dmitry Osipenko <digetx@gmail.com>,
Ashish Mhetre <amhetre@nvidia.com>
Subject: Re: [Patch RESEND 1/4] memory: tegra: sort tegra234_mc_clients table as per register offsets
Date: Wed, 12 Jul 2023 21:40:55 +0200 [thread overview]
Message-ID: <a1ddbc5c-0e41-84b2-4281-7303cc3040f8@linaro.org> (raw)
In-Reply-To: <ac9e9e2a-00b8-c9e7-00c7-215cba139a39@nvidia.com>
On 10/07/2023 18:48, Sumit Gupta wrote:
>
>
> On 10/07/23 15:38, Krzysztof Kozlowski wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 21/06/2023 15:43, Sumit Gupta wrote:
>>> Sort the MC client entries in "tegra234_mc_clients" table as per the
>>> override and security register offsets. This will help to avoid
>>> creating duplicate entries.
>>
>> If person cannot search for existing symbol before adding new entry, I
>> doubt that sorting would solve it. OTOH, this patch makes backporting
>> changes trickier, so I don't think this is good approach. Are all other
>> Tegra files ordered in this matter?
>>
>>
>> Best regards,
>> Krzysztof
>>
>
> They are in order for previous T194 SoC.
> For T234 also, initially the entries were in order.
OK. This has an impact on backports, thus I would be happy to see some
acks or reviews from other developers of this code, that this change
actually helps them by making code more readable and maintainable.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-12 19:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:43 [Patch RESEND 0/4] Tegra234 Memory Interconnect followup changes Sumit Gupta
2023-06-21 13:43 ` [Patch RESEND 1/4] memory: tegra: sort tegra234_mc_clients table as per register offsets Sumit Gupta
2023-07-10 10:08 ` Krzysztof Kozlowski
2023-07-10 16:48 ` Sumit Gupta
2023-07-12 19:40 ` Krzysztof Kozlowski [this message]
2023-07-13 15:00 ` Thierry Reding
2023-06-21 13:43 ` [Patch RESEND 2/4] memory: tegra: Add clients used by DRM in Tegra234 Sumit Gupta
2023-07-13 15:01 ` Thierry Reding
2023-06-21 13:43 ` [Patch RESEND 3/4] memory: tegra: add check if MRQ_EMC_DVFS_LATENCY is supported Sumit Gupta
2023-07-13 15:02 ` Thierry Reding
2023-06-21 13:44 ` [Patch RESEND 4/4] memory: tegra: make icc_set_bw return zero if BWMGR not supported Sumit Gupta
2023-07-13 15:03 ` Thierry Reding
2023-07-25 18:29 ` Jon Hunter
2023-07-25 20:11 ` Krzysztof Kozlowski
2023-07-14 4:10 ` [Patch RESEND 0/4] Tegra234 Memory Interconnect followup changes Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1ddbc5c-0e41-84b2-4281-7303cc3040f8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amhetre@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumitg@nvidia.com \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).