From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jon Hunter <jonathanh@nvidia.com>,
Sumit Gupta <sumitg@nvidia.com>,
treding@nvidia.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Cc: bbasu@nvidia.com, talho@nvidia.com
Subject: Re: [Patch RESEND 4/4] memory: tegra: make icc_set_bw return zero if BWMGR not supported
Date: Tue, 25 Jul 2023 22:11:11 +0200 [thread overview]
Message-ID: <3a75c310-1eb3-ebcf-82e0-99897e5e37c9@linaro.org> (raw)
In-Reply-To: <df57e126-fe89-8a43-42aa-f0b4a5a404dc@nvidia.com>
On 25/07/2023 20:29, Jon Hunter wrote:
> Hi Krzysztof,
>
> On 21/06/2023 14:44, Sumit Gupta wrote:
>> Return zero from icc_set_bw() to MC client driver if MRQ_BWMGR_INT
>> is not supported by the BPMP-FW. Currently, 'EINVAL' is returned
>> which causes error message in client drivers even when the platform
>> doesn't support scaling.
>>
>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>> ---
>> drivers/memory/tegra/tegra234.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/memory/tegra/tegra234.c b/drivers/memory/tegra/tegra234.c
>> index bc73be7fe143..07aba301a173 100644
>> --- a/drivers/memory/tegra/tegra234.c
>> +++ b/drivers/memory/tegra/tegra234.c
>> @@ -951,7 +951,7 @@ static int tegra234_mc_icc_set(struct icc_node *src, struct icc_node *dst)
>> return 0;
>>
>> if (!mc->bwmgr_mrq_supported)
>> - return -EINVAL;
>> + return 0;
>>
>> if (!mc->bpmp) {
>> dev_err(mc->dev, "BPMP reference NULL\n");
>> @@ -998,7 +998,7 @@ static int tegra234_mc_icc_aggregate(struct icc_node *node, u32 tag, u32 avg_bw,
>> struct tegra_mc *mc = icc_provider_to_tegra_mc(p);
>>
>> if (!mc->bwmgr_mrq_supported)
>> - return -EINVAL;
>> + return 0;
>>
>> if (node->id == TEGRA_ICC_MC_CPU_CLUSTER0 ||
>> node->id == TEGRA_ICC_MC_CPU_CLUSTER1 ||
>
>
> I have also found that this change is needed for Linux v6.5 in order to
> work with current BPMP firmware. Without this patch PCIe does not work
> on Tegra234. We should probably also add the following fixes tag for
> this patch ...
>
> Fixes: 9365bf006f53 ("PCI: tegra194: Add interconnect support in Tegra234")
Thank you, I moved the commit to fixes branch. I hope other patches do
not depend on the order (it was part of the patchset as 3/4 commit).
Since I re-shuffled everything, I will send pull for current RC
tomorrow, not today.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-25 20:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 13:43 [Patch RESEND 0/4] Tegra234 Memory Interconnect followup changes Sumit Gupta
2023-06-21 13:43 ` [Patch RESEND 1/4] memory: tegra: sort tegra234_mc_clients table as per register offsets Sumit Gupta
2023-07-10 10:08 ` Krzysztof Kozlowski
2023-07-10 16:48 ` Sumit Gupta
2023-07-12 19:40 ` Krzysztof Kozlowski
2023-07-13 15:00 ` Thierry Reding
2023-06-21 13:43 ` [Patch RESEND 2/4] memory: tegra: Add clients used by DRM in Tegra234 Sumit Gupta
2023-07-13 15:01 ` Thierry Reding
2023-06-21 13:43 ` [Patch RESEND 3/4] memory: tegra: add check if MRQ_EMC_DVFS_LATENCY is supported Sumit Gupta
2023-07-13 15:02 ` Thierry Reding
2023-06-21 13:44 ` [Patch RESEND 4/4] memory: tegra: make icc_set_bw return zero if BWMGR not supported Sumit Gupta
2023-07-13 15:03 ` Thierry Reding
2023-07-25 18:29 ` Jon Hunter
2023-07-25 20:11 ` Krzysztof Kozlowski [this message]
2023-07-14 4:10 ` [Patch RESEND 0/4] Tegra234 Memory Interconnect followup changes Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a75c310-1eb3-ebcf-82e0-99897e5e37c9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bbasu@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=sumitg@nvidia.com \
--cc=talho@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).