From: Christoph Hellwig <hch@lst.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Gavin Li <git@thegavinli.com>,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
Minas Harutyunyan <hminas@synopsys.com>,
Alan Stern <stern@rowland.harvard.edu>,
Geoff Levand <geoff@infradead.org>,
Michal Simek <michal.simek@xilinx.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Mathias Nyman <mathias.nyman@intel.com>, Bin Liu <b-liu@ti.com>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-m68k@lists.linux-m68k.org,
iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/6] usb/max3421: remove the dummy {un,}map_urb_for_dma methods
Date: Fri, 16 Aug 2019 08:24:33 +0200 [thread overview]
Message-ID: <20190816062435.881-5-hch@lst.de> (raw)
In-Reply-To: <20190816062435.881-1-hch@lst.de>
Now that we have an explicit HCD_DMA flag, there is not need to override
these methods.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/usb/host/max3421-hcd.c | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/drivers/usb/host/max3421-hcd.c b/drivers/usb/host/max3421-hcd.c
index afa321ab55fc..8819f502b6a6 100644
--- a/drivers/usb/host/max3421-hcd.c
+++ b/drivers/usb/host/max3421-hcd.c
@@ -1800,21 +1800,6 @@ max3421_bus_resume(struct usb_hcd *hcd)
return -1;
}
-/*
- * The SPI driver already takes care of DMA-mapping/unmapping, so no
- * reason to do it twice.
- */
-static int
-max3421_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags)
-{
- return 0;
-}
-
-static void
-max3421_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
-{
-}
-
static const struct hc_driver max3421_hcd_desc = {
.description = "max3421",
.product_desc = DRIVER_DESC,
@@ -1826,8 +1811,6 @@ static const struct hc_driver max3421_hcd_desc = {
.get_frame_number = max3421_get_frame_number,
.urb_enqueue = max3421_urb_enqueue,
.urb_dequeue = max3421_urb_dequeue,
- .map_urb_for_dma = max3421_map_urb_for_dma,
- .unmap_urb_for_dma = max3421_unmap_urb_for_dma,
.endpoint_disable = max3421_endpoint_disable,
.hub_status_data = max3421_hub_status_data,
.hub_control = max3421_hub_control,
--
2.20.1
next prev parent reply other threads:[~2019-08-16 6:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 6:24 next take at setting up a dma mask by default for platform devices v2 Christoph Hellwig
2019-08-16 6:24 ` [PATCH 1/6] usb: don't create dma pools for HCDs with a localmem_pool Christoph Hellwig
2019-08-16 6:24 ` [PATCH 2/6] usb: add a hcd_uses_dma helper Christoph Hellwig
2019-08-16 6:24 ` [PATCH 3/6] usb: add a HCD_DMA flag instead of guestimating DMA capabilities Christoph Hellwig
2019-08-16 6:24 ` Christoph Hellwig [this message]
2019-08-16 6:24 ` [PATCH 5/6] dma-mapping: remove is_device_dma_capable Christoph Hellwig
2019-08-16 6:24 ` [PATCH 6/6] driver core: initialize a default DMA mask for platform device Christoph Hellwig
2019-08-16 7:39 ` Geert Uytterhoeven
2019-08-22 17:11 ` next take at setting up a dma mask by default for platform devices v2 Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2019-08-11 8:05 next take at setting up a dma mask by default for platform devices Christoph Hellwig
2019-08-11 8:05 ` [PATCH 4/6] usb/max3421: remove the dummy {un,}map_urb_for_dma methods Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816062435.881-5-hch@lst.de \
--to=hch@lst.de \
--cc=b-liu@ti.com \
--cc=festevam@gmail.com \
--cc=geoff@infradead.org \
--cc=git@thegavinli.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kernel@pengutronix.de \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mathias.nyman@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=michal.simek@xilinx.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).