From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: lars@metafoo.de, alexandru.Ardelean@analog.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
balbi@kernel.org
Cc: gregkh@linuxfoundation.org, bigeasy@linutronix.de,
m.olbrich@pengutronix.de, kernel@pengutronix.de
Subject: [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints
Date: Fri, 27 Mar 2020 09:43:03 +0100 [thread overview]
Message-ID: <20200327084302.606-1-m.grzeschik@pengutronix.de> (raw)
In-Reply-To: <dc52d6a0-12ed-a34c-01c4-0fc5ccbf7b1d@metafoo.de>
dwc3_gadget_ep_disable gets called before the last request gets
dequeued.
In __dwc3_gadget_ep_disable all started, pending and cancelled
lists for this endpoint will call dwc3_gadget_giveback in
dwc3_remove_requests.
After that no list containing the afterwards dequed request,
therefor it is not necessary to run the dequeue routine.
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
@Lars-Peter Clausen:
This patch addresses the case that not queued requests get dequeued.
The only case that this happens seems on disabling the gadget.
drivers/usb/dwc3/gadget.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 9a6f741d1db0dc..5d4fa8d6c93e49 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1609,6 +1609,9 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
trace_dwc3_ep_dequeue(req);
+ if (!(dep->flags & DWC3_EP_ENABLED))
+ return 0;
+
spin_lock_irqsave(&dwc->lock, flags);
list_for_each_entry(r, &dep->pending_list, list) {
--
2.26.0.rc2
next prev parent reply other threads:[~2020-03-27 8:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:45 [PATCH] usb: dwc3: gadget: Handle dequeuing of non queued URB gracefully Alexandru Ardelean
2019-11-12 14:41 ` Michael Olbrich
2020-01-16 11:12 ` Ardelean, Alexandru
2020-01-16 13:05 ` Felipe Balbi
2020-01-16 13:24 ` [PATCH][RESEND] " Alexandru Ardelean
2020-01-30 12:02 ` Felipe Balbi
2020-03-10 13:22 ` Ardelean, Alexandru
2020-03-10 13:45 ` Lars-Peter Clausen
2020-03-10 14:07 ` Lars-Peter Clausen
2020-03-27 8:43 ` Michael Grzeschik [this message]
2020-03-27 8:53 ` [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints Sergei Shtylyov
2020-03-27 11:15 ` Andy Shevchenko
2020-03-27 9:14 ` Lars-Peter Clausen
2020-03-27 10:43 ` Michael Grzeschik
2020-03-27 10:55 ` Lars-Peter Clausen
2020-03-28 8:27 ` Felipe Balbi
2020-03-29 19:02 ` Michael Grzeschik
2020-03-30 7:18 ` Felipe Balbi
2020-03-30 8:25 ` Michael Grzeschik
2020-03-30 10:06 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200327084302.606-1-m.grzeschik@pengutronix.de \
--to=m.grzeschik@pengutronix.de \
--cc=alexandru.Ardelean@analog.com \
--cc=balbi@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.olbrich@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).