[PATCH v2] watchdog: renesas_wdt: Fix typos

[PATCH v2] watchdog: renesas_wdt: Fix typos

[Fabrizio Castro]

Do not use "," but ";" to separate instructions.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>

---
v1->v2:
* Added changelog as suggested by Guenter Roeck

 drivers/watchdog/renesas_wdt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
index 0d74c3e..b570962 100644
--- a/drivers/watchdog/renesas_wdt.c
+++ b/drivers/watchdog/renesas_wdt.c
@@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
 		goto out_pm_disable;
 	}
 
-	priv->wdev.info = &rwdt_ident,
-	priv->wdev.ops = &rwdt_ops,
+	priv->wdev.info = &rwdt_ident;
+	priv->wdev.ops = &rwdt_ops;
 	priv->wdev.parent = &pdev->dev;
 	priv->wdev.min_timeout = 1;
 	priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
-- 
2.7.4

Re: [PATCH v2] watchdog: renesas_wdt: Fix typos

[Simon Horman]

On Mon, Nov 05, 2018 at 10:53:47AM +0000, Fabrizio Castro wrote:
> Do not use "," but ";" to separate instructions.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> ---
> v1->v2:
> * Added changelog as suggested by Guenter Roeck

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> 
>  drivers/watchdog/renesas_wdt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 0d74c3e..b570962 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev)
>  		goto out_pm_disable;
>  	}
>  
> -	priv->wdev.info = &rwdt_ident,
> -	priv->wdev.ops = &rwdt_ops,
> +	priv->wdev.info = &rwdt_ident;
> +	priv->wdev.ops = &rwdt_ops;
>  	priv->wdev.parent = &pdev->dev;
>  	priv->wdev.min_timeout = 1;
>  	priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
> -- 
> 2.7.4
> 

Re: [PATCH v2] watchdog: renesas_wdt: Fix typos

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

On Mon, Nov 05, 2018 at 10:53:47AM +0000, Fabrizio Castro wrote:
> Do not use "," but ";" to separate instructions.

This sentence would even be better as $subject, because current $subject
sounds like fixing a comment or so. Other than that:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]