From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: Pascal PAILLET-LME <p.paillet@st.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Enric Balletbo i Serra <eballetbo@gmail.com>
Subject: Re: [PATCH v4 1/8] dt-bindings: mfd: document stpmic1
Date: Fri, 26 Oct 2018 07:46:14 +0100 [thread overview]
Message-ID: <20181026064614.GG4870@dell> (raw)
In-Reply-To: <CAL_JsqKsp8kTK2v_cBrNm+enzieQSEh2G7KMxsBdidr+XhDwTg@mail.gmail.com>
On Thu, 25 Oct 2018, Rob Herring wrote:
> On Thu, Oct 25, 2018 at 4:44 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > Rob: please grep your name for some feedback.
[Moved to the top]
> > I'm surprised Rob allowed you to add register bits in a DT property?
>
> Yeah, they are certainly questionable and not something we encourage,
> but the alternative would be dozens of properties which only apply for
> this one device and just get translated back to register values.
I don't see how this device is any different to the 100's of devices
which are already supported in DT.
> > On Thu, 18 Oct 2018, Pascal PAILLET-LME wrote:
> >
> > > From: pascal paillet <p.paillet@st.com>
>
> > > +Optional parent device properties:
> > > +- st,main-control-register:
> > > + -bit 1: Power cycling will be performed on turn OFF condition
> > > + -bit 2: PWRCTRL is functional
> > > + -bit 3: PWRCTRL active high
> > > +- st,pads-pull-register:
> > > + -bit 1: WAKEUP pull down is not active
> > > + -bit 2: PWRCTRL pull up is active
> > > + -bit 3: PWRCTRL pull down is active
> > > + -bit 4: WAKEUP detector is disabled
This should be part of the Pinctrl configuration/driver.
And Pinctrl probably already has properties for this?
> > > +- st,vin-control-register:
> > > + -bit 0: VINLOW monitoring is enabled
> > > + -bit [1...3]: VINLOW rising threshold
> > > + 000 VINOK_f + 50mV
> > > + 001 VINOK_f + 100mV
> > > + 010 VINOK_f + 150mV
> > > + 011 VINOK_f + 200mV
> > > + 100 VINOK_f + 250mV
> > > + 101 VINOK_f + 300mV
> > > + 110 VINOK_f + 350mV
> > > + 111 VINOK_f + 400mV
> > > + -bit [4...5]: VINLOW hyst
> > > + 00 100mV
> > > + 01 200mV
> > > + 10 300mV
> > > + 11 400mV
> > > + -bit 6: SW_OUT detector is disabled
> > > + -bit 7: SW_IN detector is enabled.
This should be part of the Regulator configuration/driver?
> > > +- st,usb-control-register:
> > > + -bit 3: SW_OUT current limit
> > > + 0: 600mA
> > > + 1: 1.1A
> > > + -bit 4: VBUS_OTG discharge is enabled
> > > + -bit 5: SW_OUT discharge is enabled
> > > + -bit 6: VBUS_OTG detection is enabled
> > > + -bit 7: BOOST_OVP is disabled
This should be part of the USB configuration/driver?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-10-26 15:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-18 9:02 [PATCH v4 0/8] Introduce STPMIC1 PMIC Driver Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 2/8] mfd: stpmic1: add stpmic1 driver Pascal PAILLET-LME
2018-10-25 11:21 ` Lee Jones
2018-10-25 12:40 ` Benjamin Gaignard
2018-10-26 7:17 ` Lee Jones
2018-10-18 9:02 ` [PATCH v4 1/8] dt-bindings: mfd: document stpmic1 Pascal PAILLET-LME
2018-10-18 18:47 ` Rob Herring
2018-10-25 9:44 ` Lee Jones
2018-10-25 12:57 ` Rob Herring
2018-10-26 6:46 ` Lee Jones [this message]
2018-10-26 9:48 ` Pascal PAILLET-LME
2018-10-26 11:46 ` Lee Jones
2018-10-18 9:02 ` [PATCH v4 3/8] dt-bindings: regulator: document stpmic1 pmic regulators Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver Pascal PAILLET-LME
2018-10-19 11:50 ` Mark Brown
2018-10-24 12:54 ` Pascal PAILLET-LME
2018-10-24 13:17 ` Mark Brown
2018-10-25 13:23 ` Pascal PAILLET-LME
2018-10-26 20:33 ` Mark Brown
2018-10-18 9:02 ` [PATCH v4 6/8] input: stpmic1: add stpmic1 onkey driver Pascal PAILLET-LME
2018-10-18 18:12 ` dmitry.torokhov
2018-10-18 9:02 ` [PATCH v4 7/8] dt-bindings: watchdog: document stpmic1 pmic watchdog Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 5/8] dt-bindings: input: document stpmic1 pmic onkey Pascal PAILLET-LME
2018-10-18 9:02 ` [PATCH v4 8/8] watchdog: stpmic1: add stpmic1 watchdog driver Pascal PAILLET-LME
2018-10-18 13:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026064614.GG4870@dell \
--to=lee.jones@linaro.org \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eballetbo@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=p.paillet@st.com \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).