From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 08/16] watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout
Date: Mon, 29 Apr 2019 15:19:07 +0200 [thread overview]
Message-ID: <20190429131907.xpl6duf4cvtwbmud@pengutronix.de> (raw)
In-Reply-To: <616a9d4e-7050-a6c2-727d-f62e08d3d98c@roeck-us.net>
Hello,
On Mon, Apr 29, 2019 at 05:37:12AM -0700, Guenter Roeck wrote:
> On 4/29/19 3:15 AM, Uwe Kleine-König wrote:
> > On Fri, Apr 19, 2019 at 08:15:53PM +0200, Wolfram Sang wrote:
> > > The core will print out details now.
> > >
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > ---
> > > drivers/watchdog/imx_sc_wdt.c | 5 +----
> > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/watchdog/imx_sc_wdt.c b/drivers/watchdog/imx_sc_wdt.c
> > > index 86c2722f2a09..6dc24ceb1b2c 100644
> > > --- a/drivers/watchdog/imx_sc_wdt.c
> > > +++ b/drivers/watchdog/imx_sc_wdt.c
> >
> > This driver isn't in next, and I don't know where to look for it.
> >
>
> Branch watchdog-next of
> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
Thanks, found it now.
> > > @@ -117,10 +117,7 @@ static int imx_sc_wdt_probe(struct platform_device *pdev)
> > > imx_sc_wdd->parent = &pdev->dev;
> > > imx_sc_wdd->timeout = DEFAULT_TIMEOUT;
> > > - ret = watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev);
> > > - if (ret)
> > > - dev_warn(&pdev->dev, "Failed to set timeout value, using default\n");
> > > -
> > > + watchdog_init_timeout(imx_sc_wdd, 0, &pdev->dev);
> >
> > One side effect is however that ret isn't set any more. So I wonder if a
> > failure in watchdog_init_timeout() really makes the core print the
> > details as expected.
> >
>
> Sorry, I don't understand. The warning is printed in watchdog_init_timeout().
> What does that have to do with setting ret here or not ?
Ah, I thought the warning is done in the caller of the modified
function. Maybe this means the commit log can be improved to for
example:
The function watchdog_init_timeout() itself already emits a
more informative warning on failure. So drop the driver specific
one.
Otherwise my concerns are eliminated.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-04-29 13:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 18:15 [PATCH v3 00/16] watchdog: refactor init_timeout and update users Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 01/16] watchdog: refactor watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 02/16] watchdog: add error messages when initializing timeout fails Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 03/16] watchdog: cadence_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 04/16] watchdog: cadence_wdt: still probe if user supplied timeout is invalid Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 05/16] watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 06/16] watchdog: hpwdt: " Wolfram Sang
2019-04-19 21:18 ` Jerry Hoemann
2019-04-19 18:15 ` [PATCH v3 07/16] watchdog: i6300esb: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 08/16] watchdog: imx_sc_wdt: " Wolfram Sang
2019-04-29 10:15 ` Uwe Kleine-König
2019-04-29 12:37 ` Guenter Roeck
2019-04-29 13:19 ` Uwe Kleine-König [this message]
2019-04-19 18:15 ` [PATCH v3 09/16] watchdog: ni903x_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 10/16] watchdog: nic7018_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 11/16] watchdog: renesas_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 12/16] watchdog: sp5100_tco: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 13/16] watchdog: st_lpc_wdt: " Wolfram Sang
2019-04-19 18:15 ` [PATCH v3 14/16] watchdog: stm32_iwdg: " Wolfram Sang
2019-04-19 18:16 ` [PATCH v3 15/16] watchdog: xen_wdt: " Wolfram Sang
2019-04-19 18:16 ` [PATCH v3 16/16] watchdog: ziirave_wdt: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429131907.xpl6duf4cvtwbmud@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).