Re: [PATCH] watchdog: Remove iop_wdt - Russell King

From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Arnd Bergmann <arnd@arndb.de>, Laura Abbott <labbott@redhat.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	Lennert Buytenhek <kernel@wantstofly.org>
Subject: Re: [PATCH] watchdog: Remove iop_wdt
Date: Wed, 20 Nov 2019 23:56:52 +0000	[thread overview]
Message-ID: <20191120235652.GW25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191120230518.GA28840@roeck-us.net>

On Wed, Nov 20, 2019 at 03:05:18PM -0800, Guenter Roeck wrote:
> On Wed, Nov 20, 2019 at 10:30:54AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Nov 20, 2019 at 11:15:01AM +0100, Arnd Bergmann wrote:
> > > On Wed, Nov 20, 2019 at 11:03 AM Russell King - ARM Linux admin
> > > <linux@armlinux.org.uk> wrote:
> > > > On Tue, Nov 19, 2019 at 06:29:09AM -0800, Guenter Roeck wrote:
> > > > > On 11/19/19 1:40 AM, Arnd Bergmann wrote:
> > > > > > On Tue, Nov 19, 2019 at 3:08 AM Guenter Roeck <linux@roeck-us.net> wrote:
> > > > > > > On 11/18/19 2:04 PM, Laura Abbott wrote:
> > > > >
> > > > > Good point, especially since apparently no one cared for five years.
> > > >
> > > > Doesn't mean that there aren't interested parties.  I still have
> > > > IOP32x hardware running here in the form of a N2100 (my firewall)
> > > > and it seems that I never noticed this option disappearing until
> > > > now...
> > > 
> > > It's not that it was ever there for IOP32x: the driver was introduced in 2007
> > > and was available for IOP32x but failed to compile for it until 2014 when
> > > I sent the patch to disable the driver in all configurations that
> > > failed to build.
> > 
> > Well:
> > 
> > systems/n2100/boot/config-3.11.5+:CONFIG_IOP_WATCHDOG=m
> > systems/n2100/boot/config-3.12.6+:CONFIG_IOP_WATCHDOG=m
> > systems/n2100/boot/config-3.9.5+:CONFIG_IOP_WATCHDOG=m
> > 
> > -rw-rw-r-- 1 rmk rmk 5284 Dec 30  2013 systems/n2100/lib/modules/3.12.6+/kernel/drivers/watchdog/iop_wdt.ko
> > -rw-rw-r-- 1 rmk rmk 5276 Dec 20  2013 systems/n2100/lib/modules/3.9.5+/kernel/drivers/watchdog/iop_wdt.ko
> > 
> > It seems I've been carrying a patch to comment out the troublesome code:
> > 
> > -       write_wdtsr(IOP13XX_WDTCR_IB_RESET);
> > +//     write_wdtsr(IOP13XX_WDTCR_IB_RESET);
> > 
> > in my stable tree since 2015.
> 
> Do you have plans to update that kernel to mainline ?
> If yes, a patch to make the driver (and I guess everything else that broke
> since 3.12) work would be helpful.

It's a currently running 4.19.xx stable kernel, but as a result of the
patch to the Kconfig file, without the watchdog which I hadn't realised
until I saw this thread.  Is that mainline enough?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up