From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Laura Abbott <labbott@redhat.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Lennert Buytenhek <kernel@wantstofly.org>
Subject: Re: [PATCH] watchdog: Remove iop_wdt
Date: Tue, 19 Nov 2019 06:29:09 -0800 [thread overview]
Message-ID: <4f283ab6-0f3c-60e9-cfd1-29d10d978986@roeck-us.net> (raw)
In-Reply-To: <CAK8P3a0=3J3WHTKU7sPvd37VEwg3wOuZ5S2-xXtNYEcSQhWyHw@mail.gmail.com>
On 11/19/19 1:40 AM, Arnd Bergmann wrote:
> On Tue, Nov 19, 2019 at 3:08 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 11/18/19 2:04 PM, Laura Abbott wrote:
>>>
>>> Commit 59d3ae9a5bf6 ("ARM: remove Intel iop33x and iop13xx support")
>>> removed support for some old platforms. Given this driver depends on
>>> a now removed platform, just remove the driver.
>>>
>>> Signed-off-by: Laura Abbott <labbott@redhat.com>
>>> ---
>>> Found this while reviewing config options. Not sure if this was kept
>>> around for other reasons or just missed.
>>> ---
>>> drivers/watchdog/Kconfig | 16 ---
>>> drivers/watchdog/Makefile | 1 -
>>> drivers/watchdog/iop_wdt.c | 249 -------------------------------------
>>> 3 files changed, 266 deletions(-)
>>> delete mode 100644 drivers/watchdog/iop_wdt.c
>>>
>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>>> index 58e7c100b6ad..fef9078a44b6 100644
>>> --- a/drivers/watchdog/Kconfig
>>> +++ b/drivers/watchdog/Kconfig
>>> @@ -554,22 +554,6 @@ config PNX4008_WATCHDOG
>>>
>>> Say N if you are unsure.
>>>
>>> -config IOP_WATCHDOG
>>> - tristate "IOP Watchdog"
>>> - depends on ARCH_IOP13XX
>>> - select WATCHDOG_NOWAYOUT if (ARCH_IOP32X || ARCH_IOP33X)
>>
>> This is a bit confusing, but it suggests that the watchdog may also work
>> with ARCH_IOP32X, which is still supported. I don't know anything about
>> those architectures, but I hesitate to have the driver removed unless
>> we have confirmation that it won't work with ARCH_IOP32X.
>> Maybe the dependency needs to be updated instead ?
>
> See commit ec2e32ca661e ("watchdog: iop_wdt only builds for
> mach-iop13xx") from 2014: the watdog hardware exists on iop32x
> but the driver only successfully built on iop13xx, which is now gone.
>
> Adding Russell (who said he still uses iop32x hardware) and Lennert
> (who is still listed in the MAINTAINERS file, but previously said he
> does not use it any more) to Cc. If neither of them see a reason to
> keep the driver, I'd say we can remove it.
>
> It seems unlikely that anyone wants to revive the driver if they have
> not done it yet, and if they want to do it later, it is barely harder to revert
> the removal than to fix the compile-time problem.
>
Good point, especially since apparently no one cared for five years.
Guenter
next prev parent reply other threads:[~2019-11-19 14:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 22:04 [PATCH] watchdog: Remove iop_wdt Laura Abbott
2019-11-19 2:08 ` Guenter Roeck
2019-11-19 9:40 ` Arnd Bergmann
2019-11-19 14:29 ` Guenter Roeck [this message]
2019-11-20 10:03 ` Russell King - ARM Linux admin
2019-11-20 10:15 ` Arnd Bergmann
2019-11-20 10:30 ` Russell King - ARM Linux admin
2019-11-20 23:05 ` Guenter Roeck
2019-11-20 23:56 ` Russell King - ARM Linux admin
2019-11-21 0:36 ` Guenter Roeck
2019-11-20 9:56 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f283ab6-0f3c-60e9-cfd1-29d10d978986@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=kernel@wantstofly.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).