From: Sam Protsenko <semen.protsenko@linaro.org>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH v3 00/12] watchdog: s3c2410: Add Exynos850 support
Date: Sun, 7 Nov 2021 22:29:31 +0200 [thread overview]
Message-ID: <20211107202943.8859-1-semen.protsenko@linaro.org> (raw)
Exynos850 WDT IP-core differs a bit from existing platforms:
- Another set of PMU registers
- Separate WDT instance for each CPU cluster, having different PMU
registers/bits
- Source clock is different from PCLK
Implement all missing features above and enable Exynos850 WDT support.
While at it, do a bit of cleaning up.
Changes in v3:
- Renamed "samsung,index" property to more descriptive
"samsung,cluster-index"
- bindings: Disabled "samsung,cluster-index" property for SoCs other
than Exynos850
- Added quirks documentation
- Removed has_src_clk field: clk framework can handle NULL clk; added
s3c2410wdt_get_freq() function instead, to figure out which clock to
use for getting the rate
- Used pre-defined and completely set driver data for cluster0 and
cluster1
- Coding style changes
- Added R-b tags
Changes in v2:
- Added patch to fail probe if no valid timeout was found, as
suggested by Guenter Roeck (03/12)
- Extracted code for separating disable/mask functions into separate
patch (06/12)
- Added patch for inverting mask register value (07/12)
- Extracted PMU cleanup code to separate patch, to ease the review and
porting (09/12)
- Added patch for removing not needed 'err' label in probe function
(11/12)
- Addressed all outstanding review comments on mailing list
Sam Protsenko (12):
dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7
dt-bindings: watchdog: Document Exynos850 watchdog bindings
watchdog: s3c2410: Fail probe if can't find valid timeout
watchdog: s3c2410: Let kernel kick watchdog
watchdog: s3c2410: Make reset disable register optional
watchdog: s3c2410: Extract disable and mask code into separate
functions
watchdog: s3c2410: Implement a way to invert mask reg value
watchdog: s3c2410: Add support for WDT counter enable register
watchdog: s3c2410: Cleanup PMU related code
watchdog: s3c2410: Support separate source clock
watchdog: s3c2410: Remove superfluous err label
watchdog: s3c2410: Add Exynos850 support
.../bindings/watchdog/samsung-wdt.yaml | 48 ++-
drivers/watchdog/s3c2410_wdt.c | 322 +++++++++++++-----
2 files changed, 287 insertions(+), 83 deletions(-)
--
2.30.2
next reply other threads:[~2021-11-07 20:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-07 20:29 Sam Protsenko [this message]
2021-11-07 20:29 ` [PATCH v3 01/12] dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7 Sam Protsenko
2021-11-17 13:33 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 02/12] dt-bindings: watchdog: Document Exynos850 watchdog bindings Sam Protsenko
2021-11-08 13:08 ` Krzysztof Kozlowski
2021-11-12 22:43 ` Rob Herring
2021-11-17 13:34 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 03/12] watchdog: s3c2410: Fail probe if can't find valid timeout Sam Protsenko
2021-11-17 13:34 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 04/12] watchdog: s3c2410: Let kernel kick watchdog Sam Protsenko
2021-11-17 13:34 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 05/12] watchdog: s3c2410: Make reset disable register optional Sam Protsenko
2021-11-17 13:35 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 06/12] watchdog: s3c2410: Extract disable and mask code into separate functions Sam Protsenko
2021-11-17 13:35 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 07/12] watchdog: s3c2410: Implement a way to invert mask reg value Sam Protsenko
2021-11-17 13:35 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 08/12] watchdog: s3c2410: Add support for WDT counter enable register Sam Protsenko
2021-11-17 13:36 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 09/12] watchdog: s3c2410: Cleanup PMU related code Sam Protsenko
2021-11-17 13:36 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 10/12] watchdog: s3c2410: Support separate source clock Sam Protsenko
2021-11-08 13:24 ` Krzysztof Kozlowski
2021-11-17 13:37 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 11/12] watchdog: s3c2410: Remove superfluous err label Sam Protsenko
2021-11-17 13:37 ` Guenter Roeck
2021-11-07 20:29 ` [PATCH v3 12/12] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-11-08 13:25 ` Krzysztof Kozlowski
2021-11-17 13:37 ` Guenter Roeck
2021-11-20 20:29 ` Guenter Roeck
2021-11-21 16:25 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211107202943.8859-1-semen.protsenko@linaro.org \
--to=semen.protsenko@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).