* [PATCH] watchdog: sbsa: only use 32-bit accessors
@ 2021-09-03 11:21 Jamie Iles
2021-09-03 14:05 ` Guenter Roeck
2021-09-06 11:30 ` Shaokun Zhang
0 siblings, 2 replies; 3+ messages in thread
From: Jamie Iles @ 2021-09-03 11:21 UTC (permalink / raw)
To: linux-watchdog; +Cc: wim, linux, zhangshaokun
SBSA says of the generic watchdog:
All registers are 32 bits in size and should be accessed using 32-bit
reads and writes. If an access size other than 32 bits is used then
the results are IMPLEMENTATION DEFINED.
and for qemu, the implementation will only allow 32-bit accesses
resulting in a synchronous external abort when configuring the watchdog.
Use lo_hi_* accessors rather than a readq/writeq.
Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
---
drivers/watchdog/sbsa_gwdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
index ee9ff38929eb..6f4319bdbc50 100644
--- a/drivers/watchdog/sbsa_gwdt.c
+++ b/drivers/watchdog/sbsa_gwdt.c
@@ -130,7 +130,7 @@ static u64 sbsa_gwdt_reg_read(struct sbsa_gwdt *gwdt)
if (gwdt->version == 0)
return readl(gwdt->control_base + SBSA_GWDT_WOR);
else
- return readq(gwdt->control_base + SBSA_GWDT_WOR);
+ return lo_hi_readq(gwdt->control_base + SBSA_GWDT_WOR);
}
static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
@@ -138,7 +138,7 @@ static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
if (gwdt->version == 0)
writel((u32)val, gwdt->control_base + SBSA_GWDT_WOR);
else
- writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
+ lo_hi_writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
}
/*
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: sbsa: only use 32-bit accessors
2021-09-03 11:21 [PATCH] watchdog: sbsa: only use 32-bit accessors Jamie Iles
@ 2021-09-03 14:05 ` Guenter Roeck
2021-09-06 11:30 ` Shaokun Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-09-03 14:05 UTC (permalink / raw)
To: Jamie Iles, linux-watchdog; +Cc: wim, zhangshaokun
On 9/3/21 4:21 AM, Jamie Iles wrote:
> SBSA says of the generic watchdog:
>
> All registers are 32 bits in size and should be accessed using 32-bit
> reads and writes. If an access size other than 32 bits is used then
> the results are IMPLEMENTATION DEFINED.
>
> and for qemu, the implementation will only allow 32-bit accesses
> resulting in a synchronous external abort when configuring the watchdog.
> Use lo_hi_* accessors rather than a readq/writeq.
>
> Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sbsa_gwdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index ee9ff38929eb..6f4319bdbc50 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -130,7 +130,7 @@ static u64 sbsa_gwdt_reg_read(struct sbsa_gwdt *gwdt)
> if (gwdt->version == 0)
> return readl(gwdt->control_base + SBSA_GWDT_WOR);
> else
> - return readq(gwdt->control_base + SBSA_GWDT_WOR);
> + return lo_hi_readq(gwdt->control_base + SBSA_GWDT_WOR);
> }
>
> static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> @@ -138,7 +138,7 @@ static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> if (gwdt->version == 0)
> writel((u32)val, gwdt->control_base + SBSA_GWDT_WOR);
> else
> - writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
> + lo_hi_writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
> }
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] watchdog: sbsa: only use 32-bit accessors
2021-09-03 11:21 [PATCH] watchdog: sbsa: only use 32-bit accessors Jamie Iles
2021-09-03 14:05 ` Guenter Roeck
@ 2021-09-06 11:30 ` Shaokun Zhang
1 sibling, 0 replies; 3+ messages in thread
From: Shaokun Zhang @ 2021-09-06 11:30 UTC (permalink / raw)
To: Jamie Iles, linux-watchdog; +Cc: wim, linux
Hi Jamie，
On 2021/9/3 19:21, Jamie Iles wrote:
> SBSA says of the generic watchdog:
>
> All registers are 32 bits in size and should be accessed using 32-bit
> reads and writes. If an access size other than 32 bits is used then
> the results are IMPLEMENTATION DEFINED.
>
> and for qemu, the implementation will only allow 32-bit accesses
> resulting in a synchronous external abort when configuring the watchdog.
> Use lo_hi_* accessors rather than a readq/writeq.
>
> Fixes: abd3ac7902fb ("watchdog: sbsa: Support architecture version 1")
> Signed-off-by: Jamie Iles <quic_jiles@quicinc.com>
> ---
> drivers/watchdog/sbsa_gwdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/sbsa_gwdt.c b/drivers/watchdog/sbsa_gwdt.c
> index ee9ff38929eb..6f4319bdbc50 100644
> --- a/drivers/watchdog/sbsa_gwdt.c
> +++ b/drivers/watchdog/sbsa_gwdt.c
> @@ -130,7 +130,7 @@ static u64 sbsa_gwdt_reg_read(struct sbsa_gwdt *gwdt)
> if (gwdt->version == 0)
> return readl(gwdt->control_base + SBSA_GWDT_WOR);
> else
> - return readq(gwdt->control_base + SBSA_GWDT_WOR);
> + return lo_hi_readq(gwdt->control_base + SBSA_GWDT_WOR);
My bad, I didn't check this carefully. Please feel free to add：
Reviewed-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Thanks,
Shaokun
> }
>
> static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> @@ -138,7 +138,7 @@ static void sbsa_gwdt_reg_write(u64 val, struct sbsa_gwdt *gwdt)
> if (gwdt->version == 0)
> writel((u32)val, gwdt->control_base + SBSA_GWDT_WOR);
> else
> - writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
> + lo_hi_writeq(val, gwdt->control_base + SBSA_GWDT_WOR);
> }
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-06 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-03 11:21 [PATCH] watchdog: sbsa: only use 32-bit accessors Jamie Iles
2021-09-03 14:05 ` Guenter Roeck
2021-09-06 11:30 ` Shaokun Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).