linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [v1,0/3] watchdog: mt8195: add wdt support
@ 2021-06-20 13:49 Christine Zhu
       [not found] ` <20210620134954.15233-4-Christine.Zhu@mediatek.com>
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Christine Zhu @ 2021-06-20 13:49 UTC (permalink / raw)
  To: linux, robh+dt, wim, matthias.bgg
  Cc: linux-arm-kernel, linux-mediatek, linux-kernel, seiya.wang,
	linux-watchdog, rex-bc.chen,
	Project_Global_Chrome_Upstream_Group, srv_heupstream

christine.zhu (3):
  dt-binding: mt8195: update mtk-wdt document
  dt-binding: mt8195: add toprgu reset-controller head file
  watchdog: mt8195: add wdt support

 .../devicetree/bindings/watchdog/mtk-wdt.txt  |  2 +-
 drivers/watchdog/mtk_wdt.c                    |  5 ++++
 include/dt-bindings/reset/mt8195-resets.h     | 29 +++++++++++++++++++
 3 files changed, 35 insertions(+), 1 deletion(-)



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [v1,3/3] watchdog: mt8195: add wdt support
       [not found] ` <20210620134954.15233-4-Christine.Zhu@mediatek.com>
@ 2021-06-21  6:11   ` Tzung-Bi Shih
  0 siblings, 0 replies; 5+ messages in thread
From: Tzung-Bi Shih @ 2021-06-21  6:11 UTC (permalink / raw)
  To: Christine Zhu
  Cc: linux, robh+dt, wim, matthias.bgg, linux-arm-kernel,
	linux-mediatek, linux-kernel, seiya.wang, linux-watchdog,
	rex-bc.chen, Project_Global_Chrome_Upstream_Group,
	srv_heupstream

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
<Christine.Zhu@mediatek.com> wrote:
> add support for watchdog device found in MT8195 SoC
Please write complete sentences.  For example, "Supports MT8195
watchdog device."

> Change-Id: Ib2434cf2d47a2e14916056f08a4fc630569624ed
Remove the unneeded tag.

> +static const struct mtk_wdt_data mt8195_data = {
> +       .toprgu_sw_rst_num = MT8195_TOPRGU_SW_RST_NUM,
> +};
Expect to see the of_device_id (i.e. mtk_wdt_dt_ids) has the newly
introduced compatible string and use the mt8195_data but failed to
find it.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [v1,0/3] watchdog: mt8195: add wdt support
  2021-06-20 13:49 [v1,0/3] watchdog: mt8195: add wdt support Christine Zhu
       [not found] ` <20210620134954.15233-4-Christine.Zhu@mediatek.com>
@ 2021-06-21  6:11 ` Tzung-Bi Shih
       [not found] ` <20210620134954.15233-2-Christine.Zhu@mediatek.com>
       [not found] ` <20210620134954.15233-3-Christine.Zhu@mediatek.com>
  3 siblings, 0 replies; 5+ messages in thread
From: Tzung-Bi Shih @ 2021-06-21  6:11 UTC (permalink / raw)
  To: Christine Zhu
  Cc: linux, robh+dt, wim, matthias.bgg, linux-arm-kernel,
	linux-mediatek, linux-kernel, seiya.wang, linux-watchdog,
	rex-bc.chen, Project_Global_Chrome_Upstream_Group,
	srv_heupstream

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
<Christine.Zhu@mediatek.com> wrote:
> christine.zhu (3):
>   dt-binding: mt8195: update mtk-wdt document
>   dt-binding: mt8195: add toprgu reset-controller head file
>   watchdog: mt8195: add wdt support
Please provide some information in the cover letter to let people know
what the series fixes about.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [v1,1/3] dt-binding: mt8195: update mtk-wdt document
       [not found] ` <20210620134954.15233-2-Christine.Zhu@mediatek.com>
@ 2021-06-21  6:11   ` Tzung-Bi Shih
  0 siblings, 0 replies; 5+ messages in thread
From: Tzung-Bi Shih @ 2021-06-21  6:11 UTC (permalink / raw)
  To: Christine Zhu
  Cc: linux, robh+dt, wim, matthias.bgg, linux-arm-kernel,
	linux-mediatek, linux-kernel, seiya.wang, linux-watchdog,
	rex-bc.chen, Project_Global_Chrome_Upstream_Group,
	srv_heupstream

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
<Christine.Zhu@mediatek.com> wrote:
> update mtk-wdt document for MT8195 platform
Please write complete sentences.

> Change-Id: Id18393e8deff2c3492e21c85e97a28e88bc9ca0f
Remove the unneeded tag.

The patch needs other proper prefixes.  For example, "dt-bindings:
mediatek: mt8195:".

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [v1,2/3] dt-binding: mt8195: add toprgu reset-controller head file
       [not found] ` <20210620134954.15233-3-Christine.Zhu@mediatek.com>
@ 2021-06-21  6:11   ` Tzung-Bi Shih
  0 siblings, 0 replies; 5+ messages in thread
From: Tzung-Bi Shih @ 2021-06-21  6:11 UTC (permalink / raw)
  To: Christine Zhu
  Cc: linux, robh+dt, wim, matthias.bgg, linux-arm-kernel,
	linux-mediatek, linux-kernel, seiya.wang, linux-watchdog,
	rex-bc.chen, Project_Global_Chrome_Upstream_Group,
	srv_heupstream

On Sun, Jun 20, 2021 at 9:50 PM Christine Zhu
<Christine.Zhu@mediatek.com> wrote:
> add toprgu reset-controller head file for MT8195 platform
Please write complete sentences.

> Change-Id: Ib08da609e87d31ff0aa06b066f9797070931a693
Remove the unneeded tag.

> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2020 MediaTek Inc.
Maybe 2021?

The patch needs other proper prefixes.  For example, "dt-bindings:
reset: mt8195".

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-21  6:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-20 13:49 [v1,0/3] watchdog: mt8195: add wdt support Christine Zhu
     [not found] ` <20210620134954.15233-4-Christine.Zhu@mediatek.com>
2021-06-21  6:11   ` [v1,3/3] " Tzung-Bi Shih
2021-06-21  6:11 ` [v1,0/3] " Tzung-Bi Shih
     [not found] ` <20210620134954.15233-2-Christine.Zhu@mediatek.com>
2021-06-21  6:11   ` [v1,1/3] dt-binding: mt8195: update mtk-wdt document Tzung-Bi Shih
     [not found] ` <20210620134954.15233-3-Christine.Zhu@mediatek.com>
2021-06-21  6:11   ` [v1,2/3] dt-binding: mt8195: add toprgu reset-controller head file Tzung-Bi Shih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).