linux-watchdog.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Julius Werner <jwerner@chromium.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Evan Benn" <evanbenn@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Julius Werner" <jwerner@chromium.org>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
	"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Olof Johansson" <olof@lixom.net>,
	"Leonard Crestez" <leonard.crestez@nxp.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Will Deacon" <will@kernel.org>,
	linux-watchdog@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Clément Péron" <peron.clem@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Anson Huang" <Anson.Huang@nxp.com>
Subject: Re: [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver
Date: Fri, 14 Feb 2020 13:32:09 -0800	[thread overview]
Message-ID: <CAODwPW-d_PpV4Jhg2CC+7Tfyrrh=gh6hRfcEKFb4gj+LB6vrWw@mail.gmail.com> (raw)
In-Reply-To: <804d3cc5-688d-7025-cb87-10b9616f4d9b@roeck-us.net>

> > with a Secure Monitor firmware to forward watchdog operations to
> > firmware via a Secure Monitor Call. This may be useful for platforms
> > using TrustZone that want the Secure Monitor firmware to have the final
> > control over the watchdog.
> >
>
> As written, one would assume this to work on all systems implementing
> ARM secure firmware, which is not the case. Please select a different
> name, and provide information about the systems where this is actually
> supported.
>
> If it happens to be standardized, we will need a reference to the standard
> supported. This needs to distinguish from IMX_SC_WDT, which also supports
> a secure monitor based watchdog (but doesn't claim to be generic).

Back when I wrote this I was hoping it could be something that other
platforms can pick up if they want to, but that hasn't happened yet
and the code on the Trusted Firmware side is still MediaTek-specific.
Unfortunately Arm doesn't make it easy to write generic SMC interfaces
and my attempts to change that haven't been very fruitful for now. So
yes, probably makes sense to treat this as MediaTek-specific for now,
we can still consider expanding it later if there's interest from
other platforms. (I would like to avoid every vendor writing their own
driver and SMC interface for this, although looking at that IMX driver
it seems that we're already there.)

  reply	other threads:[~2020-02-14 21:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  6:26 [PATCH 0/2] Add a watchdog driver that uses ARM Secure Monitor Calls Evan Benn
2020-02-14  6:26 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Evan Benn
2020-02-19 22:30   ` Rob Herring
2020-02-19 23:04     ` Julius Werner
2020-02-19 23:20       ` Guenter Roeck
2020-02-20  6:41         ` Evan Benn
2020-02-20 15:43           ` Guenter Roeck
2020-02-21 15:36           ` Xingyu Chen
2020-02-21 19:41             ` Julius Werner
2020-02-21 20:46               ` Guenter Roeck
2020-02-22  4:01               ` Xingyu Chen
2020-02-24  1:10                 ` Evan Benn
2020-02-25  1:23                 ` Julius Werner
2020-02-25  7:44                   ` Xingyu Chen
2020-03-10  1:00                     ` Evan Benn
     [not found]                       ` <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com>
2020-03-11 19:24                         ` Julius Werner
2020-03-13 16:13                           ` Xingyu Chen
2020-02-14  6:26 ` [PATCH 2/2] watchdog: Add new arm_smc_wdt watchdog driver Evan Benn
2020-02-14  9:35   ` Enric Balletbo Serra
2020-02-14 14:10   ` Guenter Roeck
2020-02-14 21:32     ` Julius Werner [this message]
2020-02-15  1:39       ` Evan Benn
2020-02-20  6:50     ` Evan Benn
2020-02-20 15:52       ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAODwPW-d_PpV4Jhg2CC+7Tfyrrh=gh6hRfcEKFb4gj+LB6vrWw@mail.gmail.com' \
    --to=jwerner@chromium.org \
    --cc=Anson.Huang@nxp.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=dinguyen@kernel.org \
    --cc=evanbenn@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=olof@lixom.net \
    --cc=peron.clem@gmail.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).