From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog <linux-watchdog@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion
Date: Wed, 31 Mar 2021 09:53:08 +0800 [thread overview]
Message-ID: <fe4808f6-a628-7126-5d9c-d0132a0e97fc@huawei.com> (raw)
In-Reply-To: <28b7616a-daa7-e944-8c0f-640eddaaebc8@roeck-us.net>
On 2021/3/28 3:50, Guenter Roeck wrote:
> On 3/26/21 6:20 PM, Zhen Lei wrote:
>> The header file <linux/kernel.h> is already included above and can be
>> removed here.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>
> Already submitted:
>
> https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/
>
> In general, when removing duplicate or unnecessary header files,
> please retain or improve alphabetic order. This patch makes it worse.
Okay, thanks for the heads-up. I'll pay attention next time.
>
> Guenter
>
>> ---
>> drivers/watchdog/dw_wdt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
>> index 32d0e1781e63c4e..b1642e2d9175584 100644
>> --- a/drivers/watchdog/dw_wdt.c
>> +++ b/drivers/watchdog/dw_wdt.c
>> @@ -19,7 +19,6 @@
>> #include <linux/delay.h>
>> #include <linux/err.h>
>> #include <linux/io.h>
>> -#include <linux/kernel.h>
>> #include <linux/module.h>
>> #include <linux/moduleparam.h>
>> #include <linux/interrupt.h>
>>
>
>
> .
>
prev parent reply other threads:[~2021-03-31 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 1:20 [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion Zhen Lei
2021-03-27 19:50 ` Guenter Roeck
2021-03-31 1:53 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe4808f6-a628-7126-5d9c-d0132a0e97fc@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).