Linux-Watchdog Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion
@ 2021-03-27  1:20 Zhen Lei
  2021-03-27 19:50 ` Guenter Roeck
  0 siblings, 1 reply; 3+ messages in thread
From: Zhen Lei @ 2021-03-27  1:20 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, linux-watchdog, linux-kernel; +Cc: Zhen Lei

The header file <linux/kernel.h> is already included above and can be
removed here.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 drivers/watchdog/dw_wdt.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
index 32d0e1781e63c4e..b1642e2d9175584 100644
--- a/drivers/watchdog/dw_wdt.c
+++ b/drivers/watchdog/dw_wdt.c
@@ -19,7 +19,6 @@
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/io.h>
-#include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/interrupt.h>
-- 
1.8.3



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion
  2021-03-27  1:20 [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion Zhen Lei
@ 2021-03-27 19:50 ` Guenter Roeck
  2021-03-31  1:53   ` Leizhen (ThunderTown)
  0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2021-03-27 19:50 UTC (permalink / raw)
  To: Zhen Lei, Wim Van Sebroeck, linux-watchdog, linux-kernel

On 3/26/21 6:20 PM, Zhen Lei wrote:
> The header file <linux/kernel.h> is already included above and can be
> removed here.
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>

Already submitted:

https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/

In general, when removing duplicate or unnecessary header files,
please retain or improve alphabetic order. This patch makes it worse.

Guenter

> ---
>  drivers/watchdog/dw_wdt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e1781e63c4e..b1642e2d9175584 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -19,7 +19,6 @@
>  #include <linux/delay.h>
>  #include <linux/err.h>
>  #include <linux/io.h>
> -#include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
>  #include <linux/interrupt.h>
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion
  2021-03-27 19:50 ` Guenter Roeck
@ 2021-03-31  1:53   ` Leizhen (ThunderTown)
  0 siblings, 0 replies; 3+ messages in thread
From: Leizhen (ThunderTown) @ 2021-03-31  1:53 UTC (permalink / raw)
  To: Guenter Roeck, Wim Van Sebroeck, linux-watchdog, linux-kernel



On 2021/3/28 3:50, Guenter Roeck wrote:
> On 3/26/21 6:20 PM, Zhen Lei wrote:
>> The header file <linux/kernel.h> is already included above and can be
>> removed here.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> 
> Already submitted:
> 
> https://patchwork.kernel.org/project/linux-watchdog/patch/20210325112916.865510-1-wanjiabing@vivo.com/
> 
> In general, when removing duplicate or unnecessary header files,
> please retain or improve alphabetic order. This patch makes it worse.

Okay, thanks for the heads-up. I'll pay attention next time.

> 
> Guenter
> 
>> ---
>>  drivers/watchdog/dw_wdt.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
>> index 32d0e1781e63c4e..b1642e2d9175584 100644
>> --- a/drivers/watchdog/dw_wdt.c
>> +++ b/drivers/watchdog/dw_wdt.c
>> @@ -19,7 +19,6 @@
>>  #include <linux/delay.h>
>>  #include <linux/err.h>
>>  #include <linux/io.h>
>> -#include <linux/kernel.h>
>>  #include <linux/module.h>
>>  #include <linux/moduleparam.h>
>>  #include <linux/interrupt.h>
>>
> 
> 
> .
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27  1:20 [PATCH 1/1] watchdog: dw_wdt: Remove duplicated header file inclusion Zhen Lei
2021-03-27 19:50 ` Guenter Roeck
2021-03-31  1:53   ` Leizhen (ThunderTown)

Linux-Watchdog Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-watchdog/0 linux-watchdog/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-watchdog linux-watchdog/ https://lore.kernel.org/linux-watchdog \
		linux-watchdog@vger.kernel.org
	public-inbox-index linux-watchdog

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-watchdog


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git