* [PATCH 01/41] wil6210: wmi: Correct misnamed function parameter 'ptr_'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 8:10 ` Kalle Valo
2020-11-02 11:23 ` [PATCH 02/41] rsi_91x_usb: Fix some basic kernel-doc issues Lee Jones
` (40 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Maya Erez, David S. Miller,
Jakub Kicinski, linux-wireless, wil6210, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block'
drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block'
Cc: Maya Erez <merez@codeaurora.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: wil6210@qti.qualcomm.com
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/wil6210/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index 421aebbb49e54..8699f8279a8be 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -262,7 +262,7 @@ struct fw_map *wil_find_fw_mapping(const char *section)
/**
* Check address validity for WMI buffer; remap if needed
* @wil: driver data
- * @ptr: internal (linker) fw/ucode address
+ * @ptr_: internal (linker) fw/ucode address
* @size: if non zero, validate the block does not
* exceed the device memory (bar)
*
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 02/41] rsi_91x_usb: Fix some basic kernel-doc issues
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
2020-11-02 11:23 ` [PATCH 01/41] wil6210: wmi: Correct misnamed function parameter 'ptr_' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 16:03 ` [02/41] rsi: " Kalle Valo
2020-11-02 11:23 ` [PATCH 03/41] rtl8192cu: mac: Fix some missing/ill-documented function parameters Lee Jones
` (39 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Amitkumar Karwar, Siva Rebbagondla,
David S. Miller, Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/rsi/rsi_91x_usb.c:26: warning: cannot understand function prototype: 'u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; '
drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Function parameter or member 'endpoint' not described in 'rsi_write_multiple'
drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Excess function parameter 'addr' description in 'rsi_write_multiple'
drivers/net/wireless/rsi/rsi_91x_usb.c:320: warning: Function parameter or member 'ep_num' not described in 'rsi_rx_urb_submit'
drivers/net/wireless/rsi/rsi_91x_usb.c:320: warning: Function parameter or member 'mem_flags' not described in 'rsi_rx_urb_submit'
Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: Siva Rebbagondla <siva8118@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/rsi/rsi_91x_usb.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c
index a62d41c0ccbc0..8928e14671512 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb.c
@@ -1,4 +1,4 @@
-/**
+/*
* Copyright (c) 2014 Redpine Signals Inc.
*
* Permission to use, copy, modify, and/or distribute this software for any
@@ -75,7 +75,7 @@ static int rsi_usb_card_write(struct rsi_hw *adapter,
* rsi_write_multiple() - This function writes multiple bytes of information
* to the USB card.
* @adapter: Pointer to the adapter structure.
- * @addr: Address of the register.
+ * @endpoint: Type of endpoint.
* @data: Pointer to the data that has to be written.
* @count: Number of multiple bytes to be written.
*
@@ -313,6 +313,8 @@ static void rsi_rx_urb_kill(struct rsi_hw *adapter, u8 ep_num)
/**
* rsi_rx_urb_submit() - This function submits the given URB to the USB stack.
* @adapter: Pointer to the adapter structure.
+ * @ep_num: Endpoint number.
+ * @mem_flags: The type of memory to allocate.
*
* Return: 0 on success, a negative error code on failure.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [02/41] rsi: rsi_91x_usb: Fix some basic kernel-doc issues
2020-11-02 11:23 ` [PATCH 02/41] rsi_91x_usb: Fix some basic kernel-doc issues Lee Jones
@ 2020-11-07 16:03 ` Kalle Valo
0 siblings, 0 replies; 61+ messages in thread
From: Kalle Valo @ 2020-11-07 16:03 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Lee Jones, Amitkumar Karwar, Siva Rebbagondla,
David S. Miller, Jakub Kicinski, linux-wireless, netdev
Lee Jones <lee.jones@linaro.org> wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/rsi/rsi_91x_usb.c:26: warning: cannot understand function prototype: 'u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; '
> drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Function parameter or member 'endpoint' not described in 'rsi_write_multiple'
> drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Excess function parameter 'addr' description in 'rsi_write_multiple'
> drivers/net/wireless/rsi/rsi_91x_usb.c:320: warning: Function parameter or member 'ep_num' not described in 'rsi_rx_urb_submit'
> drivers/net/wireless/rsi/rsi_91x_usb.c:320: warning: Function parameter or member 'mem_flags' not described in 'rsi_rx_urb_submit'
>
> Cc: Amitkumar Karwar <amitkarwar@gmail.com>
> Cc: Siva Rebbagondla <siva8118@gmail.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
2 patches applied to wireless-drivers-next.git, thanks.
f21e6c5822f2 rsi: rsi_91x_usb: Fix some basic kernel-doc issues
63636b385e39 rsi: rsi_91x_usb_ops: Source file headers are not good candidates for kernel-doc
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201102112410.1049272-3-lee.jones@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* [PATCH 03/41] rtl8192cu: mac: Fix some missing/ill-documented function parameters
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
2020-11-02 11:23 ` [PATCH 01/41] wil6210: wmi: Correct misnamed function parameter 'ptr_' Lee Jones
2020-11-02 11:23 ` [PATCH 02/41] rsi_91x_usb: Fix some basic kernel-doc issues Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 16:15 ` [03/41] rtlwifi: " Kalle Valo
2020-11-02 11:23 ` [PATCH 04/41] rsi_91x_usb_ops: Source file headers are not good candidates for kernel-doc Lee Jones
` (38 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Function parameter or member 'hw' not described in 'rtl92c_llt_write'
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Excess function parameter 'io' description in 'rtl92c_llt_write'
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:155: warning: Function parameter or member 'hw' not described in 'rtl92c_init_llt_table'
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:155: warning: Excess function parameter 'io' description in 'rtl92c_init_llt_table'
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
index 2890a495a23ec..8d2c6d8d32d93 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c
@@ -113,7 +113,7 @@ void rtl92c_read_chip_version(struct ieee80211_hw *hw)
/**
* writeLLT - LLT table write access
- * @io: io callback
+ * @hw: Pointer to the ieee80211_hw structure.
* @address: LLT logical address.
* @data: LLT data content
*
@@ -145,11 +145,10 @@ bool rtl92c_llt_write(struct ieee80211_hw *hw, u32 address, u32 data)
/**
* rtl92c_init_LLT_table - Init LLT table
- * @io: io callback
- * @boundary:
+ * @hw: Pointer to the ieee80211_hw structure.
+ * @boundary: Page boundary.
*
* Realtek hardware access function.
- *
*/
bool rtl92c_init_llt_table(struct ieee80211_hw *hw, u32 boundary)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [03/41] rtlwifi: rtl8192cu: mac: Fix some missing/ill-documented function parameters
2020-11-02 11:23 ` [PATCH 03/41] rtl8192cu: mac: Fix some missing/ill-documented function parameters Lee Jones
@ 2020-11-07 16:15 ` Kalle Valo
0 siblings, 0 replies; 61+ messages in thread
From: Kalle Valo @ 2020-11-07 16:15 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Lee Jones <lee.jones@linaro.org> wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Function parameter or member 'hw' not described in 'rtl92c_llt_write'
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Excess function parameter 'io' description in 'rtl92c_llt_write'
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:155: warning: Function parameter or member 'hw' not described in 'rtl92c_init_llt_table'
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:155: warning: Excess function parameter 'io' description in 'rtl92c_init_llt_table'
>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
11 patches applied to wireless-drivers-next.git, thanks.
230f874e4d95 rtlwifi: rtl8192cu: mac: Fix some missing/ill-documented function parameters
906a1b4f81a3 rtlwifi: rtl8192cu: trx: Demote clear abuse of kernel-doc format
bb053d0251a2 rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
87b08d1ecb93 rtlwifi: phy: Remove set but unused variable 'bbvalue'
0c73dab72f53 rtlwifi: halbtc8821a1ant: Remove set but unused variable 'wifi_rssi_state'
0a43d993ee7e rtlwifi: rtl8723be: Remove set but unused variable 'lc_cal'
6c75eab0417b rtlwifi: rtl8188ee: Remove set but unused variable 'reg_ea4'
28f811876262 rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
44ec6d9df96d rtlwifi: rtl8723be: Remove set but unused variable 'cck_highpwr'
29c6099a3890 rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
398d816a64eb rtlwifi: rtl8821ae: Place braces around empty if() body
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201102112410.1049272-4-lee.jones@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* [PATCH 04/41] rsi_91x_usb_ops: Source file headers are not good candidates for kernel-doc
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (2 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 03/41] rtl8192cu: mac: Fix some missing/ill-documented function parameters Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format Lee Jones
` (37 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Amitkumar Karwar, Siva Rebbagondla,
David S. Miller, Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/rsi/rsi_91x_usb_ops.c:22: warning: Incorrect use of kernel-doc format: * rsi_usb_rx_thread() - This is a kernel thread to receive the packets from
drivers/net/wireless/rsi/rsi_91x_usb_ops.c:29: warning: Function parameter or member 'common' not described in 'rsi_usb_rx_thread'
Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: Siva Rebbagondla <siva8118@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/rsi/rsi_91x_usb_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_usb_ops.c b/drivers/net/wireless/rsi/rsi_91x_usb_ops.c
index b1687d22f73f5..4ffcdde1acb1e 100644
--- a/drivers/net/wireless/rsi/rsi_91x_usb_ops.c
+++ b/drivers/net/wireless/rsi/rsi_91x_usb_ops.c
@@ -1,4 +1,4 @@
-/**
+/*
* Copyright (c) 2014 Redpine Signals Inc.
*
* Permission to use, copy, modify, and/or distribute this software for any
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (3 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 04/41] rsi_91x_usb_ops: Source file headers are not good candidates for kernel-doc Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 16:50 ` Larry Finger
2020-11-02 11:23 ` [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist' Lee Jones
` (36 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:455: warning: Function parameter or member 'txdesc' not described in '_rtl_tx_desc_checksum'
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
index 1ad0cf37f60bb..87f959d5d861d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
@@ -448,7 +448,7 @@ static void _rtl_fill_usb_tx_desc(__le32 *txdesc)
set_tx_desc_first_seg(txdesc, 1);
}
-/**
+/*
* For HW recovery information
*/
static void _rtl_tx_desc_checksum(__le32 *txdesc)
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format
2020-11-02 11:23 ` [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format Lee Jones
@ 2020-11-02 16:50 ` Larry Finger
2020-11-03 8:51 ` Lee Jones
0 siblings, 1 reply; 61+ messages in thread
From: Larry Finger @ 2020-11-02 16:50 UTC (permalink / raw)
To: Lee Jones, kvalo
Cc: linux-kernel, Ping-Ke Shih, David S. Miller, Jakub Kicinski,
linux-wireless, netdev
On 11/2/20 5:23 AM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:455: warning: Function parameter or member 'txdesc' not described in '_rtl_tx_desc_checksum'
>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> index 1ad0cf37f60bb..87f959d5d861d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> @@ -448,7 +448,7 @@ static void _rtl_fill_usb_tx_desc(__le32 *txdesc)
> set_tx_desc_first_seg(txdesc, 1);
> }
>
> -/**
> +/*
> * For HW recovery information
> */
> static void _rtl_tx_desc_checksum(__le32 *txdesc)
>
Did you check this patch with checkpatch.pl? I think you substituted one warning
for another. The wireless-testing trees previously did not accept a bare "/*",
which is why "/**" was present.
This particular instance should have
/* For HW recovery information */
as the comment.
Larry
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format
2020-11-02 16:50 ` Larry Finger
@ 2020-11-03 8:51 ` Lee Jones
0 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-03 8:51 UTC (permalink / raw)
To: Larry Finger
Cc: kvalo, linux-kernel, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
On Mon, 02 Nov 2020, Larry Finger wrote:
> On 11/2/20 5:23 AM, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c:455: warning: Function parameter or member 'txdesc' not described in '_rtl_tx_desc_checksum'
> >
> > Cc: Ping-Ke Shih <pkshih@realtek.com>
> > Cc: Kalle Valo <kvalo@codeaurora.org>
> > Cc: "David S. Miller" <davem@davemloft.net>
> > Cc: Jakub Kicinski <kuba@kernel.org>
> > Cc: Larry Finger <Larry.Finger@lwfinger.net>
> > Cc: linux-wireless@vger.kernel.org
> > Cc: netdev@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> > index 1ad0cf37f60bb..87f959d5d861d 100644
> > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c
> > @@ -448,7 +448,7 @@ static void _rtl_fill_usb_tx_desc(__le32 *txdesc)
> > set_tx_desc_first_seg(txdesc, 1);
> > }
> > -/**
> > +/*
> > * For HW recovery information
> > */
> > static void _rtl_tx_desc_checksum(__le32 *txdesc)
> >
>
> Did you check this patch with checkpatch.pl?
Yes.
> I think you substituted one
> warning for another. The wireless-testing trees previously did not accept a
> bare "/*", which is why "/**" was present.
I don't see a problem.
$ git format-patch -n1 --stdout 8cd8b929e0458 | ./scripts/checkpatch.pl
total: 0 errors, 0 warnings, 0 checks, 8 lines checked
"[PATCH 1/1] rtl8192cu: trx: Demote clear abuse of kernel-doc format"
has no obvious style problems and is ready for submission.
> This particular instance should have
> /* For HW recovery information */
> as the comment.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 61+ messages in thread
* [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (4 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 05/41] rtl8192cu: trx: Demote clear abuse of kernel-doc format Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 16:04 ` Kalle Valo
2020-11-02 11:23 ` [PATCH 07/41] brcmfmac: pcie: Provide description for missing function parameter 'devinfo' Lee Jones
` (35 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Arend van Spriel, Franky Lin,
Hante Meuleman, Chi-Hsien Lin, Wright Feng, David S. Miller,
Jakub Kicinski, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: Function parameter or member 'pktlist' not described in 'brcmf_sdiod_sglist_rw'
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: Excess function parameter 'pkt' description in 'brcmf_sdiod_sglist_rw'
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Wright Feng <wright.feng@cypress.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
index f9ebb98b0e3c7..ce8c102df7b3e 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c
@@ -367,7 +367,7 @@ static int mmc_submit_one(struct mmc_data *md, struct mmc_request *mr,
* @func: SDIO function
* @write: direction flag
* @addr: dongle memory address as source/destination
- * @pkt: skb pointer
+ * @pktlist: skb buffer head pointer
*
* This function takes the respbonsibility as the interface function to MMC
* stack for block data access. It assumes that the skb passed down by the
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
2020-11-02 11:23 ` [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist' Lee Jones
@ 2020-11-07 16:04 ` Kalle Valo
0 siblings, 0 replies; 61+ messages in thread
From: Kalle Valo @ 2020-11-07 16:04 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Lee Jones, Arend van Spriel, Franky Lin,
Hante Meuleman, Chi-Hsien Lin, Wright Feng, David S. Miller,
Jakub Kicinski, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Lee Jones <lee.jones@linaro.org> wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: Function parameter or member 'pktlist' not described in 'brcmf_sdiod_sglist_rw'
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: Excess function parameter 'pkt' description in 'brcmf_sdiod_sglist_rw'
>
> Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
> Cc: Franky Lin <franky.lin@broadcom.com>
> Cc: Hante Meuleman <hante.meuleman@broadcom.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
> Cc: Wright Feng <wright.feng@cypress.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: brcm80211-dev-list.pdl@broadcom.com
> Cc: brcm80211-dev-list@cypress.com
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
3 patches applied to wireless-drivers-next.git, thanks.
6f0d044fc82e brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
05cefa989e8b brcmfmac: pcie: Provide description for missing function parameter 'devinfo'
9bd28c6607ba brcmfmac: fweh: Add missing description for 'gfp'
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201102112410.1049272-7-lee.jones@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* [PATCH 07/41] brcmfmac: pcie: Provide description for missing function parameter 'devinfo'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (5 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 08/41] iwlwifi: mvm: rs: Demote non-conformant function documentation headers Lee Jones
` (34 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Arend van Spriel, Franky Lin,
Hante Meuleman, Chi-Hsien Lin, Wright Feng, David S. Miller,
Jakub Kicinski, Sumit Semwal, Christian König,
linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
netdev, linux-media, dri-devel, linaro-mm-sig
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:766: warning: Function parameter or member 'devinfo' not described in 'brcmf_pcie_bus_console_read'
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Wright Feng <wright.feng@cypress.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: netdev@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 39381cbde89e6..1d3cc1c7c9c50 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -759,6 +759,7 @@ static void brcmf_pcie_bus_console_init(struct brcmf_pciedev_info *devinfo)
/**
* brcmf_pcie_bus_console_read - reads firmware messages
*
+ * @devinfo: pointer to the device data structure
* @error: specifies if error has occurred (prints messages unconditionally)
*/
static void brcmf_pcie_bus_console_read(struct brcmf_pciedev_info *devinfo,
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 08/41] iwlwifi: mvm: rs: Demote non-conformant function documentation headers
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (6 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 07/41] brcmfmac: pcie: Provide description for missing function parameter 'devinfo' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 09/41] wl1251: cmd: Rename 'len' to 'buf_len' in the documentation Lee Jones
` (33 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Johannes Berg, Emmanuel Grumbach,
Luca Coelho, Intel Linux Wireless, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Also add documentation for 'mvm'.
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:400: warning: cannot understand function prototype: 'const u16 expected_tpt_legacy[IWL_RATE_COUNT] = '
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'mvm' not described in '_rs_collect_tx_data'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'tbl' not described in '_rs_collect_tx_data'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'scale_index' not described in '_rs_collect_tx_data'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'attempts' not described in '_rs_collect_tx_data'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'successes' not described in '_rs_collect_tx_data'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'window' not described in '_rs_collect_tx_data'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2677: warning: duplicate section name 'NOTE'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'mvm' not described in 'rs_initialize_lq'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'sta' not described in 'rs_initialize_lq'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'lq_sta' not described in 'rs_initialize_lq'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'band' not described in 'rs_initialize_lq'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'mvm' not described in 'rs_program_fix_rate'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'lq_sta' not described in 'rs_program_fix_rate'
drivers/net/wireless/intel/iwlwifi/mvm/rs.c:4213: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_tx_protection'
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
index ed7382e7ea177..91b6541d579f5 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c
@@ -386,7 +386,7 @@ static void rs_fill_lq_cmd(struct iwl_mvm *mvm,
const struct rs_rate *initial_rate);
static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search);
-/**
+/*
* The following tables contain the expected throughput metrics for all rates
*
* 1, 2, 5.5, 11, 6, 9, 12, 18, 24, 36, 48, 54, 60 MBits
@@ -396,7 +396,6 @@ static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search);
* CCK rates are only valid in legacy table and will only be used in G
* (2.4 GHz) band.
*/
-
static const u16 expected_tpt_legacy[IWL_RATE_COUNT] = {
7, 13, 35, 58, 40, 57, 72, 98, 121, 154, 177, 186, 0, 0, 0
};
@@ -670,7 +669,7 @@ static s32 get_expected_tpt(struct iwl_scale_tbl_info *tbl, int rs_index)
return 0;
}
-/**
+/*
* rs_collect_tx_data - Update the success/failure sliding window
*
* We keep a sliding window of the last 62 packets transmitted
@@ -2667,7 +2666,7 @@ void rs_update_last_rssi(struct iwl_mvm *mvm,
}
}
-/**
+/*
* rs_initialize_lq - Initialize a station's hardware rate table
*
* The uCode's station table contains a table of fallback rates
@@ -3756,7 +3755,7 @@ int rs_pretty_print_rate(char *buf, int bufsz, const u32 rate)
}
#ifdef CONFIG_MAC80211_DEBUGFS
-/**
+/*
* Program the device to use fixed rate for frame transmit
* This is for debugging/testing only
* once the device start use fixed rate, we need to reload the module
@@ -4211,6 +4210,7 @@ static int rs_drv_tx_protection(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta,
/**
* iwl_mvm_tx_protection - ask FW to enable RTS/CTS protection
+ * @mvm: The mvm component
* @mvmsta: The station
* @enable: Enable Tx protection?
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 09/41] wl1251: cmd: Rename 'len' to 'buf_len' in the documentation
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (7 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 08/41] iwlwifi: mvm: rs: Demote non-conformant function documentation headers Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 16:06 ` Kalle Valo
2020-11-02 11:23 ` [PATCH 10/41] ath9k: ar9330_1p1_initvals: Remove unused const variable 'ar9331_common_tx_gain_offset1_1' Lee Jones
` (32 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, David S. Miller, Jakub Kicinski,
linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ti/wl1251/cmd.c:70: warning: Function parameter or member 'buf_len' not described in 'wl1251_cmd_test'
drivers/net/wireless/ti/wl1251/cmd.c:70: warning: Excess function parameter 'len' description in 'wl1251_cmd_test'
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ti/wl1251/cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wl1251/cmd.c b/drivers/net/wireless/ti/wl1251/cmd.c
index 9547aea01b0fb..e1095b8de2bdc 100644
--- a/drivers/net/wireless/ti/wl1251/cmd.c
+++ b/drivers/net/wireless/ti/wl1251/cmd.c
@@ -63,7 +63,7 @@ int wl1251_cmd_send(struct wl1251 *wl, u16 id, void *buf, size_t len)
*
* @wl: wl struct
* @buf: buffer containing the command, with all headers, must work with dma
- * @len: length of the buffer
+ * @buf_len: length of the buffer
* @answer: is answer needed
*/
int wl1251_cmd_test(struct wl1251 *wl, void *buf, size_t buf_len, u8 answer)
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 10/41] ath9k: ar9330_1p1_initvals: Remove unused const variable 'ar9331_common_tx_gain_offset1_1'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (8 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 09/41] wl1251: cmd: Rename 'len' to 'buf_len' in the documentation Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 8:08 ` Kalle Valo
2020-11-02 11:23 ` [PATCH 11/41] ath9k: ar9340_initvals: Remove unused const variable 'ar9340Modes_ub124_tx_gain_table_1p0' Lee Jones
` (31 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, QCA ath9k Development, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning: ‘ar9331_common_tx_gain_offset1_1’ defined but not used [-Wunused-const-variable=]
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h b/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h
index 29479afbc4f10..3e783fc13553b 100644
--- a/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h
@@ -1010,11 +1010,4 @@ static const u32 ar9331_common_rx_gain_1p1[][2] = {
{0x0000a1fc, 0x00000296},
};
-static const u32 ar9331_common_tx_gain_offset1_1[][1] = {
- {0x00000000},
- {0x00000003},
- {0x00000000},
- {0x00000000},
-};
-
#endif /* INITVALS_9330_1P1_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 11/41] ath9k: ar9340_initvals: Remove unused const variable 'ar9340Modes_ub124_tx_gain_table_1p0'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (9 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 10/41] ath9k: ar9330_1p1_initvals: Remove unused const variable 'ar9331_common_tx_gain_offset1_1' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 12/41] ath9k: ar9485_initvals: Remove unused const variable 'ar9485_fast_clock_1_1_baseband_postamble' Lee Jones
` (30 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, QCA ath9k Development, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9340_initvals.h:624:18: warning: ‘ar9340Modes_ub124_tx_gain_table_1p0’ defined but not used [-Wunused-const-variable=]
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../net/wireless/ath/ath9k/ar9340_initvals.h | 101 ------------------
1 file changed, 101 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h
index 2eb163fc1c18f..3da4ea564148c 100644
--- a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h
@@ -621,107 +621,6 @@ static const u32 ar9340Modes_high_ob_db_tx_gain_table_1p0[][5] = {
{0x00016448, 0x8e481666, 0x8e481666, 0x8e481266, 0x8e481266},
};
-static const u32 ar9340Modes_ub124_tx_gain_table_1p0[][5] = {
- /* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */
- {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8005, 0xd00a8005},
- {0x00009820, 0x206a022e, 0x206a022e, 0x206a00ae, 0x206a00ae},
- {0x00009830, 0x0000059c, 0x0000059c, 0x0000059c, 0x0000059c},
- {0x00009e10, 0x7ec88d2e, 0x7ec88d2e, 0x7ec82d2e, 0x7ec82d2e},
- {0x0000a2dc, 0xfef5d402, 0xfef5d402, 0xfdab5b52, 0xfdab5b52},
- {0x0000a2e0, 0xfe896600, 0xfe896600, 0xfd339c84, 0xfd339c84},
- {0x0000a2e4, 0xff01f800, 0xff01f800, 0xfec3e000, 0xfec3e000},
- {0x0000a2e8, 0xfffe0000, 0xfffe0000, 0xfffc0000, 0xfffc0000},
- {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9},
- {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000},
- {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002},
- {0x0000a508, 0x09002421, 0x09002421, 0x08000004, 0x08000004},
- {0x0000a50c, 0x0d002621, 0x0d002621, 0x0b000200, 0x0b000200},
- {0x0000a510, 0x13004620, 0x13004620, 0x0f000202, 0x0f000202},
- {0x0000a514, 0x19004a20, 0x19004a20, 0x11000400, 0x11000400},
- {0x0000a518, 0x1d004e20, 0x1d004e20, 0x15000402, 0x15000402},
- {0x0000a51c, 0x21005420, 0x21005420, 0x19000404, 0x19000404},
- {0x0000a520, 0x26005e20, 0x26005e20, 0x1b000603, 0x1b000603},
- {0x0000a524, 0x2b005e40, 0x2b005e40, 0x1f000a02, 0x1f000a02},
- {0x0000a528, 0x2f005e42, 0x2f005e42, 0x23000a04, 0x23000a04},
- {0x0000a52c, 0x33005e44, 0x33005e44, 0x26000a20, 0x26000a20},
- {0x0000a530, 0x38005e65, 0x38005e65, 0x2a000e20, 0x2a000e20},
- {0x0000a534, 0x3c005e69, 0x3c005e69, 0x2e000e22, 0x2e000e22},
- {0x0000a538, 0x40005e6b, 0x40005e6b, 0x31000e24, 0x31000e24},
- {0x0000a53c, 0x44005e6d, 0x44005e6d, 0x34001640, 0x34001640},
- {0x0000a540, 0x49005e72, 0x49005e72, 0x38001660, 0x38001660},
- {0x0000a544, 0x4e005eb2, 0x4e005eb2, 0x3b001861, 0x3b001861},
- {0x0000a548, 0x53005f12, 0x53005f12, 0x3e001a81, 0x3e001a81},
- {0x0000a54c, 0x59025eb5, 0x59025eb5, 0x42001a83, 0x42001a83},
- {0x0000a550, 0x5e025f12, 0x5e025f12, 0x44001c84, 0x44001c84},
- {0x0000a554, 0x61027f12, 0x61027f12, 0x48001ce3, 0x48001ce3},
- {0x0000a558, 0x6702bf12, 0x6702bf12, 0x4c001ce5, 0x4c001ce5},
- {0x0000a55c, 0x6b02bf14, 0x6b02bf14, 0x50001ce9, 0x50001ce9},
- {0x0000a560, 0x6f02bf16, 0x6f02bf16, 0x54001ceb, 0x54001ceb},
- {0x0000a564, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a568, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a56c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a570, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a574, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a578, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a57c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec},
- {0x0000a580, 0x00802220, 0x00802220, 0x00800000, 0x00800000},
- {0x0000a584, 0x04802222, 0x04802222, 0x04800002, 0x04800002},
- {0x0000a588, 0x09802421, 0x09802421, 0x08800004, 0x08800004},
- {0x0000a58c, 0x0d802621, 0x0d802621, 0x0b800200, 0x0b800200},
- {0x0000a590, 0x13804620, 0x13804620, 0x0f800202, 0x0f800202},
- {0x0000a594, 0x19804a20, 0x19804a20, 0x11800400, 0x11800400},
- {0x0000a598, 0x1d804e20, 0x1d804e20, 0x15800402, 0x15800402},
- {0x0000a59c, 0x21805420, 0x21805420, 0x19800404, 0x19800404},
- {0x0000a5a0, 0x26805e20, 0x26805e20, 0x1b800603, 0x1b800603},
- {0x0000a5a4, 0x2b805e40, 0x2b805e40, 0x1f800a02, 0x1f800a02},
- {0x0000a5a8, 0x2f805e42, 0x2f805e42, 0x23800a04, 0x23800a04},
- {0x0000a5ac, 0x33805e44, 0x33805e44, 0x26800a20, 0x26800a20},
- {0x0000a5b0, 0x38805e65, 0x38805e65, 0x2a800e20, 0x2a800e20},
- {0x0000a5b4, 0x3c805e69, 0x3c805e69, 0x2e800e22, 0x2e800e22},
- {0x0000a5b8, 0x40805e6b, 0x40805e6b, 0x31800e24, 0x31800e24},
- {0x0000a5bc, 0x44805e6d, 0x44805e6d, 0x34801640, 0x34801640},
- {0x0000a5c0, 0x49805e72, 0x49805e72, 0x38801660, 0x38801660},
- {0x0000a5c4, 0x4e805eb2, 0x4e805eb2, 0x3b801861, 0x3b801861},
- {0x0000a5c8, 0x53805f12, 0x53805f12, 0x3e801a81, 0x3e801a81},
- {0x0000a5cc, 0x59825eb2, 0x59825eb2, 0x42801a83, 0x42801a83},
- {0x0000a5d0, 0x5e825f12, 0x5e825f12, 0x44801c84, 0x44801c84},
- {0x0000a5d4, 0x61827f12, 0x61827f12, 0x48801ce3, 0x48801ce3},
- {0x0000a5d8, 0x6782bf12, 0x6782bf12, 0x4c801ce5, 0x4c801ce5},
- {0x0000a5dc, 0x6b82bf14, 0x6b82bf14, 0x50801ce9, 0x50801ce9},
- {0x0000a5e0, 0x6f82bf16, 0x6f82bf16, 0x54801ceb, 0x54801ceb},
- {0x0000a5e4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x0000a5e8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x0000a5ec, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x0000a5f0, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x0000a5f4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x0000a5f8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x0000a5fc, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec},
- {0x00016044, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4},
- {0x00016048, 0x8e480086, 0x8e480086, 0x8e480086, 0x8e480086},
- {0x00016444, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4},
- {0x00016448, 0x8e480086, 0x8e480086, 0x8e480086, 0x8e480086},
- {0x0000a600, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
- {0x0000a604, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
- {0x0000a608, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
- {0x0000a60c, 0x00000000, 0x00000000, 0x00000000, 0x00000000},
- {0x0000a610, 0x00804000, 0x00804000, 0x00000000, 0x00000000},
- {0x0000a614, 0x00804201, 0x00804201, 0x01404000, 0x01404000},
- {0x0000a618, 0x0280c802, 0x0280c802, 0x01404501, 0x01404501},
- {0x0000a61c, 0x0280ca03, 0x0280ca03, 0x02008501, 0x02008501},
- {0x0000a620, 0x04c15104, 0x04c15104, 0x0280ca03, 0x0280ca03},
- {0x0000a624, 0x04c15305, 0x04c15305, 0x03010c04, 0x03010c04},
- {0x0000a628, 0x04c15305, 0x04c15305, 0x04014c04, 0x04014c04},
- {0x0000a62c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
- {0x0000a630, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
- {0x0000a634, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
- {0x0000a638, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
- {0x0000a63c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005},
- {0x0000b2dc, 0xfef5d402, 0xfef5d402, 0xfdab5b52, 0xfdab5b52},
- {0x0000b2e0, 0xfe896600, 0xfe896600, 0xfd339c84, 0xfd339c84},
- {0x0000b2e4, 0xff01f800, 0xff01f800, 0xfec3e000, 0xfec3e000},
- {0x0000b2e8, 0xfffe0000, 0xfffe0000, 0xfffc0000, 0xfffc0000},
-};
-
static const u32 ar9340Modes_low_ob_db_tx_gain_table_1p0[][5] = {
/* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */
{0x0000a2dc, 0x0380c7fc, 0x0380c7fc, 0x03aaa352, 0x03aaa352},
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 12/41] ath9k: ar9485_initvals: Remove unused const variable 'ar9485_fast_clock_1_1_baseband_postamble'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (10 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 11/41] ath9k: ar9340_initvals: Remove unused const variable 'ar9340Modes_ub124_tx_gain_table_1p0' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 13/41] ath9k: ar9003_2p2_initvals: Remove unused const variables Lee Jones
` (29 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, QCA ath9k Development, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9485_initvals.h:1009:18: warning: ‘ar9485_fast_clock_1_1_baseband_postamble’ defined but not used [-Wunused-const-variable=]
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/ath9k/ar9485_initvals.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9485_initvals.h b/drivers/net/wireless/ath/ath9k/ar9485_initvals.h
index bdf6f107f6f1e..4afe52c0456e9 100644
--- a/drivers/net/wireless/ath/ath9k/ar9485_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9485_initvals.h
@@ -1006,13 +1006,6 @@ static const u32 ar9485_1_1_soc_preamble[][2] = {
{0x00007048, 0x00000002},
};
-static const u32 ar9485_fast_clock_1_1_baseband_postamble[][3] = {
- /* Addr 5G_HT20 5G_HT40 */
- {0x00009e00, 0x03721821, 0x03721821},
- {0x0000a230, 0x0000400b, 0x00004016},
- {0x0000a254, 0x00000898, 0x00001130},
-};
-
static const u32 ar9485_1_1_baseband_postamble[][5] = {
/* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */
{0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8005, 0xd00a8005},
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 13/41] ath9k: ar9003_2p2_initvals: Remove unused const variables
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (11 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 12/41] ath9k: ar9485_initvals: Remove unused const variable 'ar9485_fast_clock_1_1_baseband_postamble' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 14/41] prism54: isl_ioctl: Fix one function header and demote another Lee Jones
` (28 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, QCA ath9k Development, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1734:18: warning: ‘ar9300PciePhy_clkreq_disable_L1_2p2’ defined but not used [-Wunused-const-variable=]
drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1727:18: warning: ‘ar9300PciePhy_clkreq_enable_L1_2p2’ defined but not used [-Wunused-const-variable=]
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../net/wireless/ath/ath9k/ar9003_2p2_initvals.h | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
index c07866a2fdf96..16d5c0c5e2a8d 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
+++ b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h
@@ -1724,20 +1724,6 @@ static const u32 ar9300PciePhy_pll_on_clkreq_disable_L1_2p2[][2] = {
{0x00004044, 0x00000000},
};
-static const u32 ar9300PciePhy_clkreq_enable_L1_2p2[][2] = {
- /* Addr allmodes */
- {0x00004040, 0x0825365e},
- {0x00004040, 0x0008003b},
- {0x00004044, 0x00000000},
-};
-
-static const u32 ar9300PciePhy_clkreq_disable_L1_2p2[][2] = {
- /* Addr allmodes */
- {0x00004040, 0x0821365e},
- {0x00004040, 0x0008003b},
- {0x00004044, 0x00000000},
-};
-
static const u32 ar9300_2p2_baseband_core_txfir_coeff_japan_2484[][2] = {
/* Addr allmodes */
{0x0000a398, 0x00000000},
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 14/41] prism54: isl_ioctl: Fix one function header and demote another
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (12 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 13/41] ath9k: ar9003_2p2_initvals: Remove unused const variables Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 15/41] iwlwifi: iwl-eeprom-read: Demote one nonconformant function header Lee Jones
` (27 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Luis Chamberlain, David S. Miller,
Jakub Kicinski, Aurelien Alleaume, Valerio Riedel,
Luis R. Rodriguez, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
from drivers/net/wireless/intersil/prism54/isl_ioctl.c:22:
inlined from ‘prism54_get_name’ at drivers/net/wireless/intersil/prism54/isl_ioctl.c:283:2:
drivers/net/wireless/intersil/prism54/isl_ioctl.c:68: warning: Function parameter or member 'priv' not described in 'prism54_mib_mode_helper'
drivers/net/wireless/intersil/prism54/isl_ioctl.c:68: warning: Excess function parameter 'mib' description in 'prism54_mib_mode_helper'
drivers/net/wireless/intersil/prism54/isl_ioctl.c:127: warning: Function parameter or member 'priv' not described in 'prism54_mib_init'
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Aurelien Alleaume <slts@free.fr>
Cc: Valerio Riedel <hvr@gnu.org>
Cc: "Luis R. Rodriguez" <mcgrof@ruslug.rutgers.edu>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/intersil/prism54/isl_ioctl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intersil/prism54/isl_ioctl.c b/drivers/net/wireless/intersil/prism54/isl_ioctl.c
index 2076f449b6e25..5e5ceafe098b9 100644
--- a/drivers/net/wireless/intersil/prism54/isl_ioctl.c
+++ b/drivers/net/wireless/intersil/prism54/isl_ioctl.c
@@ -54,7 +54,7 @@ static const unsigned char scan_rate_list[] = { 2, 4, 11, 22,
/**
* prism54_mib_mode_helper - MIB change mode helper function
- * @mib: the &struct islpci_mib object to modify
+ * @priv: the &struct islpci_private object to modify
* @iw_mode: new mode (%IW_MODE_*)
*
* This is a helper function, hence it does not lock. Make sure
@@ -114,14 +114,13 @@ prism54_mib_mode_helper(islpci_private *priv, u32 iw_mode)
return 0;
}
-/**
+/*
* prism54_mib_init - fill MIB cache with defaults
*
* this function initializes the struct given as @mib with defaults,
* of which many are retrieved from the global module parameter
* variables.
*/
-
void
prism54_mib_init(islpci_private *priv)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 15/41] iwlwifi: iwl-eeprom-read: Demote one nonconformant function header
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (13 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 14/41] prism54: isl_ioctl: Fix one function header and demote another Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 16/41] iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's header Lee Jones
` (26 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Johannes Berg, Emmanuel Grumbach,
Luca Coelho, Intel Linux Wireless, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'trans' not described in 'iwl_read_eeprom'
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'eeprom' not described in 'iwl_read_eeprom'
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'eeprom_size' not described in 'iwl_read_eeprom'
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c
index ad6dc4497437e..1b2d9fd82a3de 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c
@@ -335,7 +335,7 @@ static int iwl_find_otp_image(struct iwl_trans *trans,
return -EINVAL;
}
-/**
+/*
* iwl_read_eeprom - read EEPROM contents
*
* Load the EEPROM contents from adapter and return it
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 16/41] iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's header
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (14 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 15/41] iwlwifi: iwl-eeprom-read: Demote one nonconformant function header Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast Lee Jones
` (25 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Johannes Berg, Emmanuel Grumbach,
Luca Coelho, Intel Linux Wireless, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c:340: warning: cannot understand function prototype: 'struct iwl_eeprom_enhanced_txpwr '
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c
index cf7e2a9232e52..f29d5758c8dff 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c
@@ -324,15 +324,15 @@ enum iwl_eeprom_enhanced_txpwr_flags {
};
/**
- * iwl_eeprom_enhanced_txpwr structure
+ * struct iwl_eeprom_enhanced_txpwr
* @flags: entry flags
* @channel: channel number
- * @chain_a_max_pwr: chain a max power in 1/2 dBm
- * @chain_b_max_pwr: chain b max power in 1/2 dBm
- * @chain_c_max_pwr: chain c max power in 1/2 dBm
+ * @chain_a_max: chain a max power in 1/2 dBm
+ * @chain_b_max: chain b max power in 1/2 dBm
+ * @chain_c_max: chain c max power in 1/2 dBm
* @delta_20_in_40: 20-in-40 deltas (hi/lo)
- * @mimo2_max_pwr: mimo2 max power in 1/2 dBm
- * @mimo3_max_pwr: mimo3 max power in 1/2 dBm
+ * @mimo2_max: mimo2 max power in 1/2 dBm
+ * @mimo3_max: mimo3 max power in 1/2 dBm
*
* This structure presents the enhanced regulatory tx power limit layout
* in an EEPROM image.
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (15 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 16/41] iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's header Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 16:01 ` Kalle Valo
2020-11-02 11:23 ` [PATCH 18/41] brcm80211: fweh: Add missing description for 'gfp' Lee Jones
` (24 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Jouni Malinen, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_init_local_data’:
drivers/net/wireless/intersil/hostap/hostap_hw.c:3173:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
drivers/net/wireless/intersil/hostap/hostap_hw.c:3175:2: note: in expansion of macro ‘HOSTAP_TASKLET_INIT’
NB: Repeats lots of times - snipped for brevity
Cc: Jouni Malinen <j@w1.fi>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../net/wireless/intersil/hostap/hostap_hw.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/intersil/hostap/hostap_hw.c b/drivers/net/wireless/intersil/hostap/hostap_hw.c
index 22cfb64526448..c877b677505ed 100644
--- a/drivers/net/wireless/intersil/hostap/hostap_hw.c
+++ b/drivers/net/wireless/intersil/hostap/hostap_hw.c
@@ -36,6 +36,7 @@
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#include <linux/if_arp.h>
+#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/random.h>
#include <linux/wait.h>
@@ -3169,22 +3170,16 @@ prism2_init_local_data(struct prism2_helper_functions *funcs, int card_idx,
/* Initialize tasklets for handling hardware IRQ related operations
* outside hw IRQ handler */
-#define HOSTAP_TASKLET_INIT(q, f, d) \
-do { memset((q), 0, sizeof(*(q))); (q)->func = (void(*)(unsigned long))(f); } \
-while (0)
- HOSTAP_TASKLET_INIT(&local->bap_tasklet, hostap_bap_tasklet,
- (unsigned long) local);
-
- HOSTAP_TASKLET_INIT(&local->info_tasklet, hostap_info_tasklet,
- (unsigned long) local);
+
+ tasklet_setup(&local->bap_tasklet, hostap_bap_tasklet);
+
+ tasklet_setup(&local->info_tasklet, hostap_info_tasklet);
hostap_info_init(local);
- HOSTAP_TASKLET_INIT(&local->rx_tasklet,
- hostap_rx_tasklet, (unsigned long) local);
+ tasklet_setup(&local->rx_tasklet, hostap_rx_tasklet);
skb_queue_head_init(&local->rx_list);
- HOSTAP_TASKLET_INIT(&local->sta_tx_exc_tasklet,
- hostap_sta_tx_exc_tasklet, (unsigned long) local);
+ tasklet_setup(&local->sta_tx_exc_tasklet, hostap_sta_tx_exc_tasklet);
skb_queue_head_init(&local->sta_tx_exc_list);
INIT_LIST_HEAD(&local->cmd_queue);
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast
2020-11-02 11:23 ` [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast Lee Jones
@ 2020-11-07 16:01 ` Kalle Valo
0 siblings, 0 replies; 61+ messages in thread
From: Kalle Valo @ 2020-11-07 16:01 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Lee Jones, Jouni Malinen, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Lee Jones <lee.jones@linaro.org> wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/intersil/hostap/hostap_hw.c: In function ‘prism2_init_local_data’:
> drivers/net/wireless/intersil/hostap/hostap_hw.c:3173:48: warning: cast between incompatible function types from ‘void (*)(struct tasklet_struct *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type]
> drivers/net/wireless/intersil/hostap/hostap_hw.c:3175:2: note: in expansion of macro ‘HOSTAP_TASKLET_INIT’
>
> NB: Repeats lots of times - snipped for brevity
>
> Cc: Jouni Malinen <j@w1.fi>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Already fixed in wireless-drivers-next
Recorded preimage for 'drivers/net/wireless/intersil/hostap/hostap_hw.c'
error: Failed to merge in the changes.
Applying: intersil: hostap_hw: Prevent incompatible function type cast
Using index info to reconstruct a base tree...
M drivers/net/wireless/intersil/hostap/hostap_hw.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/net/wireless/intersil/hostap/hostap_hw.c
CONFLICT (content): Merge conflict in drivers/net/wireless/intersil/hostap/hostap_hw.c
Patch failed at 0001 intersil: hostap_hw: Prevent incompatible function type cast
The copy of the patch that failed is found in: .git/rebase-apply/patch
Patch set to Superseded.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201102112410.1049272-18-lee.jones@linaro.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* [PATCH 18/41] brcm80211: fweh: Add missing description for 'gfp'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (16 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 19/41] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param Lee Jones
` (23 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Arend van Spriel, Franky Lin,
Hante Meuleman, Chi-Hsien Lin, Wright Feng, David S. Miller,
Jakub Kicinski, linux-wireless, brcm80211-dev-list.pdl,
brcm80211-dev-list, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:394: warning: Function parameter or member 'gfp' not described in 'brcmf_fweh_process_event'
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Wright Feng <wright.feng@cypress.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
index 430d2cca98b33..bc3f4e4edcdf9 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c
@@ -384,6 +384,7 @@ int brcmf_fweh_activate_events(struct brcmf_if *ifp)
* @drvr: driver information object.
* @event_packet: event packet to process.
* @packet_len: length of the packet
+ * @gfp: memory allocation flags.
*
* If the packet buffer contains a firmware event message it will
* dispatch the event to a registered handler (using worker).
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 19/41] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (17 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 18/41] brcm80211: fweh: Add missing description for 'gfp' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-07 8:07 ` Kalle Valo
2020-11-02 11:23 ` [PATCH 20/41] ath9k: ar5008_phy: Demote half completed function headers Lee Jones
` (22 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, David S. Miller, Jakub Kicinski,
linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/regd.c:378: warning: Function parameter or member 'reg' not described in 'ath_reg_apply_ir_flags'
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/regd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c
index bee9110b91f38..b2400e2417a55 100644
--- a/drivers/net/wireless/ath/regd.c
+++ b/drivers/net/wireless/ath/regd.c
@@ -360,6 +360,7 @@ ath_reg_apply_beaconing_flags(struct wiphy *wiphy,
/**
* ath_reg_apply_ir_flags()
* @wiphy: the wiphy to use
+ * @reg: regulatory structure - used for country selection
* @initiator: the regulatory hint initiator
*
* If no country IE has been received always enable passive scan
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 20/41] ath9k: ar5008_phy: Demote half completed function headers
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (18 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 19/41] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 21/41] ath: dfs_pattern_detector: Fix some function kernel-doc headers Lee Jones
` (21 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, QCA ath9k Development, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'rfBuf' not described in 'ar5008_hw_phy_modify_rx_buffer'
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'reg32' not described in 'ar5008_hw_phy_modify_rx_buffer'
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'numBits' not described in 'ar5008_hw_phy_modify_rx_buffer'
drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'firstBit' not described in 'ar5008_hw_phy_modify_rx_buffer'
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/ath9k/ar5008_phy.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
index 2fa30834a88db..6610d76131fa8 100644
--- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c
+++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c
@@ -102,13 +102,8 @@ static void ar5008_write_bank6(struct ath_hw *ah, unsigned int *writecnt)
REGWRITE_BUFFER_FLUSH(ah);
}
-/**
+/*
* ar5008_hw_phy_modify_rx_buffer() - perform analog swizzling of parameters
- * @rfbuf:
- * @reg32:
- * @numBits:
- * @firstBit:
- * @column:
*
* Performs analog "swizzling" of parameters into their location.
* Used on external AR2133/AR5133 radios.
@@ -198,10 +193,8 @@ static void ar5008_hw_force_bias(struct ath_hw *ah, u16 synth_freq)
ar5008_write_bank6(ah, ®_writes);
}
-/**
+/*
* ar5008_hw_set_channel - tune to a channel on the external AR2133/AR5133 radios
- * @ah: atheros hardware structure
- * @chan:
*
* For the external AR2133/AR5133 radios, takes the MHz channel value and set
* the channel value. Assumes writes enabled to analog bus and bank6 register
@@ -430,10 +423,8 @@ void ar5008_hw_cmn_spur_mitigate(struct ath_hw *ah,
REG_WRITE(ah, AR_PHY_MASK2_P_61_45, tmp_mask);
}
-/**
+/*
* ar5008_hw_spur_mitigate - convert baseband spur frequency for external radios
- * @ah: atheros hardware structure
- * @chan:
*
* For non single-chip solutions. Converts to baseband spur frequency given the
* input channel frequency and compute register settings below.
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 21/41] ath: dfs_pattern_detector: Fix some function kernel-doc headers
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (19 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 20/41] ath9k: ar5008_phy: Demote half completed function headers Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 22/41] ath: dfs_pri_detector: Demote zero/half completed " Lee Jones
` (20 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, David S. Miller, Jakub Kicinski,
linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/dfs_pattern_detector.c:34: warning: Function parameter or member 'region' not described in 'radar_types'
drivers/net/wireless/ath/dfs_pattern_detector.c:141: warning: Function parameter or member 'region' not described in 'get_dfs_domain_radar_types'
drivers/net/wireless/ath/dfs_pattern_detector.c:239: warning: Function parameter or member 'dpd' not described in 'channel_detector_get'
drivers/net/wireless/ath/dfs_pattern_detector.c:239: warning: Function parameter or member 'freq' not described in 'channel_detector_get'
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/dfs_pattern_detector.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/dfs_pattern_detector.c b/drivers/net/wireless/ath/dfs_pattern_detector.c
index 0813473793df1..80390495ea250 100644
--- a/drivers/net/wireless/ath/dfs_pattern_detector.c
+++ b/drivers/net/wireless/ath/dfs_pattern_detector.c
@@ -23,7 +23,7 @@
/**
* struct radar_types - contains array of patterns defined for one DFS domain
- * @domain: DFS regulatory domain
+ * @region: regulatory DFS region
* @num_radar_types: number of radar types to follow
* @radar_types: radar types array
*/
@@ -133,8 +133,9 @@ static const struct radar_types *dfs_domains[] = {
/**
* get_dfs_domain_radar_types() - get radar types for a given DFS domain
- * @param domain DFS domain
- * @return radar_types ptr on success, NULL if DFS domain is not supported
+ * @region: regulatory DFS region
+ *
+ * Return value: radar_types ptr on success, NULL if DFS domain is not supported
*/
static const struct radar_types *
get_dfs_domain_radar_types(enum nl80211_dfs_regions region)
@@ -227,9 +228,10 @@ channel_detector_create(struct dfs_pattern_detector *dpd, u16 freq)
/**
* channel_detector_get() - get channel detector for given frequency
- * @param dpd instance pointer
- * @param freq frequency in MHz
- * @return pointer to channel detector on success, NULL otherwise
+ * @dpd: DPD instance pointer
+ * @freq: freq frequency in MHz
+ *
+ * Return value: pointer to channel detector on success, NULL otherwise
*
* Return existing channel detector for the given frequency or return a
* newly create one.
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 22/41] ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (20 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 21/41] ath: dfs_pattern_detector: Fix some function kernel-doc headers Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 23/41] iwlwifi: iwl-phy-db: Add missing struct member description for 'trans' Lee Jones
` (19 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, David S. Miller, Jakub Kicinski,
linux-wireless, netdev
There are only a couple of these and none of them are conformant.
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/dfs_pri_detector.c:39: warning: Function parameter or member 'head' not described in 'pulse_elem'
drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'val' not described in 'pde_get_multiple'
drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'fraction' not described in 'pde_get_multiple'
drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'tolerance' not described in 'pde_get_multiple'
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/dfs_pri_detector.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/dfs_pri_detector.c b/drivers/net/wireless/ath/dfs_pri_detector.c
index 05b0464c6b92c..d07c454c9c00d 100644
--- a/drivers/net/wireless/ath/dfs_pri_detector.c
+++ b/drivers/net/wireless/ath/dfs_pri_detector.c
@@ -29,18 +29,17 @@ struct ath_dfs_pool_stats global_dfs_pool_stats = {};
(MIN + PRI_TOLERANCE == MAX - PRI_TOLERANCE ? \
MIN + PRI_TOLERANCE : RUNTIME)
-/**
+/*
* struct pulse_elem - elements in pulse queue
- * @ts: time stamp in usecs
*/
struct pulse_elem {
struct list_head head;
u64 ts;
};
-/**
+/*
* pde_get_multiple() - get number of multiples considering a given tolerance
- * @return factor if abs(val - factor*fraction) <= tolerance, 0 otherwise
+ * Return value: factor if abs(val - factor*fraction) <= tolerance, 0 otherwise
*/
static u32 pde_get_multiple(u32 val, u32 fraction, u32 tolerance)
{
@@ -70,7 +69,7 @@ static u32 pde_get_multiple(u32 val, u32 fraction, u32 tolerance)
return factor;
}
-/**
+/*
* DOC: Singleton Pulse and Sequence Pools
*
* Instances of pri_sequence and pulse_elem are kept in singleton pools to
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 23/41] iwlwifi: iwl-phy-db: Add missing struct member description for 'trans'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (21 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 22/41] ath: dfs_pri_detector: Demote zero/half completed " Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 24/41] wl3501_cs: Fix misspelling and provide missing documentation Lee Jones
` (18 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Johannes Berg, Emmanuel Grumbach,
Luca Coelho, Intel Linux Wireless, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c:97: warning: Function parameter or member 'trans' not described in 'iwl_phy_db'
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
index ae83cfdb750e6..c9ce270ceee07 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c
@@ -79,11 +79,11 @@ struct iwl_phy_db_entry {
*
* @cfg: phy configuration.
* @calib_nch: non channel specific calibration data.
- * @calib_ch: channel specific calibration data.
* @n_group_papd: number of entries in papd channel group.
* @calib_ch_group_papd: calibration data related to papd channel group.
* @n_group_txp: number of entries in tx power channel group.
* @calib_ch_group_txp: calibration data related to tx power chanel group.
+ * @trans: transport layer
*/
struct iwl_phy_db {
struct iwl_phy_db_entry cfg;
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 24/41] wl3501_cs: Fix misspelling and provide missing documentation
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (22 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 23/41] iwlwifi: iwl-phy-db: Add missing struct member description for 'trans' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 25/41] rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables Lee Jones
` (17 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, David S. Miller, Jakub Kicinski,
Fox Chen, de Melo, Gustavo Niemeyer, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
In file included from drivers/net/wireless/wl3501_cs.c:57:
drivers/net/wireless/wl3501_cs.c:143: warning: Function parameter or member 'reg_domain' not described in 'iw_valid_channel'
drivers/net/wireless/wl3501_cs.c:143: warning: Excess function parameter 'reg_comain' description in 'iw_valid_channel'
drivers/net/wireless/wl3501_cs.c:469: warning: Function parameter or member 'data' not described in 'wl3501_send_pkt'
drivers/net/wireless/wl3501_cs.c:469: warning: Function parameter or member 'len' not described in 'wl3501_send_pkt'
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Fox Chen <mhchen@golf.ccl.itri.org.tw>
Cc: de Melo <acme@conectiva.com.br>
Cc: Gustavo Niemeyer <niemeyer@conectiva.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/wl3501_cs.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/wl3501_cs.c b/drivers/net/wireless/wl3501_cs.c
index 026e88b80bfc4..8ca5789c7b378 100644
--- a/drivers/net/wireless/wl3501_cs.c
+++ b/drivers/net/wireless/wl3501_cs.c
@@ -134,7 +134,7 @@ static const struct {
/**
* iw_valid_channel - validate channel in regulatory domain
- * @reg_comain: regulatory domain
+ * @reg_domain: regulatory domain
* @channel: channel to validate
*
* Returns 0 if invalid in the specified regulatory domain, non-zero if valid.
@@ -458,11 +458,9 @@ static int wl3501_pwr_mgmt(struct wl3501_card *this, int suspend)
/**
* wl3501_send_pkt - Send a packet.
* @this: Card
- *
- * Send a packet.
- *
- * data = Ethernet raw frame. (e.g. data[0] - data[5] is Dest MAC Addr,
+ * @data: Ethernet raw frame. (e.g. data[0] - data[5] is Dest MAC Addr,
* data[6] - data[11] is Src MAC Addr)
+ * @len: Packet length
* Ref: IEEE 802.11
*/
static int wl3501_send_pkt(struct wl3501_card *this, u8 *data, u16 len)
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 25/41] rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (23 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 24/41] wl3501_cs: Fix misspelling and provide missing documentation Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 26/41] rtlwifi: phy: Remove set but unused variable 'bbvalue' Lee Jones
` (16 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_wifi_idle_process’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:1631:40: warning: variable ‘bt_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:1631:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_sco’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2767:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_hid’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2810:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_a2dp’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2855:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_a2dp_pan_hs’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2929:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_edr’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:2976:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_hs’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3028:22: warning: variable ‘wifi_rssi_state1’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3028:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_edr_a2dp’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3066:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_pan_edr_hid’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3121:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_hid_a2dp_pan_edr’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3185:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c: In function ‘btc8723b2ant_action_hid_a2dp’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c:3244:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../rtlwifi/btcoexist/halbtc8723b2ant.c | 48 +++++++++----------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
index fb57cc8b2e471..7a71f063015ab 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c
@@ -1628,17 +1628,17 @@ static void btc8723b2ant_action_wifi_link_process(struct btc_coexist
static bool btc8723b2ant_action_wifi_idle_process(struct btc_coexist *btcoexist)
{
struct rtl_priv *rtlpriv = btcoexist->adapter;
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1;
u8 ap_num = 0;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset - coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset - coex_dm->switch_thres_offset;
- bt_rssi_state = btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0);
+ btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0);
btcoexist->btc_get(btcoexist, BTC_GET_U1_AP_NUM, &ap_num);
@@ -2764,10 +2764,10 @@ static void btc8723b2ant_tdma_duration_adjust(struct btc_coexist *btcoexist,
/* SCO only or SCO+PAN(HS) */
static void btc8723b2ant_action_sco(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, bt_rssi_state;
+ u8 bt_rssi_state;
u32 wifi_bw;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
bt_rssi_state = btc8723b2ant_bt_rssi_state(
btcoexist, 2, BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset,
@@ -2807,12 +2807,12 @@ static void btc8723b2ant_action_sco(struct btc_coexist *btcoexist)
static void btc8723b2ant_action_hid(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, bt_rssi_state;
+ u8 bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
bt_rssi_state = btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0);
btcoexist->btc_set_rf_reg(btcoexist, BTC_RF_A, 0x1, 0xfffff, 0x0);
@@ -2852,13 +2852,13 @@ static void btc8723b2ant_action_hid(struct btc_coexist *btcoexist)
/* A2DP only / PAN(EDR) only/ A2DP+PAN(HS) */
static void btc8723b2ant_action_a2dp(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 ap_num = 0;
u8 tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2, 40, 0);
bt_rssi_state = btc8723b2ant_bt_rssi_state(btcoexist, 2, tmp, 0);
@@ -2926,12 +2926,12 @@ static void btc8723b2ant_action_a2dp(struct btc_coexist *btcoexist)
static void btc8723b2ant_action_a2dp_pan_hs(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
@@ -2973,12 +2973,12 @@ static void btc8723b2ant_action_a2dp_pan_hs(struct btc_coexist *btcoexist)
static void btc8723b2ant_action_pan_edr(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
@@ -3025,13 +3025,13 @@ static void btc8723b2ant_action_pan_edr(struct btc_coexist *btcoexist)
/* PAN(HS) only */
static void btc8723b2ant_action_pan_hs(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
- wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
@@ -3063,12 +3063,12 @@ static void btc8723b2ant_action_pan_hs(struct btc_coexist *btcoexist)
/* PAN(EDR) + A2DP */
static void btc8723b2ant_action_pan_edr_a2dp(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
@@ -3118,12 +3118,12 @@ static void btc8723b2ant_action_pan_edr_a2dp(struct btc_coexist *btcoexist)
static void btc8723b2ant_action_pan_edr_hid(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
@@ -3182,12 +3182,12 @@ static void btc8723b2ant_action_pan_edr_hid(struct btc_coexist *btcoexist)
/* HID + A2DP + PAN(EDR) */
static void btc8723b2ant_action_hid_a2dp_pan_edr(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
@@ -3241,13 +3241,13 @@ static void btc8723b2ant_action_hid_a2dp_pan_edr(struct btc_coexist *btcoexist)
static void btc8723b2ant_action_hid_a2dp(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1, bt_rssi_state;
u32 wifi_bw;
u8 ap_num = 0;
u8 tmp = BT_8723B_2ANT_WIFI_RSSI_COEXSWITCH_THRES -
coex_dm->switch_thres_offset;
- wifi_rssi_state = btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8723b2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8723b2ant_wifi_rssi_state(btcoexist, 1, 2,
tmp, 0);
tmp = BT_8723B_2ANT_BT_RSSI_COEXSWITCH_THRES -
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 26/41] rtlwifi: phy: Remove set but unused variable 'bbvalue'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (24 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 25/41] rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 27/41] rtlwifi: halbtc8821a1ant: Remove set but unused variable 'wifi_rssi_state' Lee Jones
` (15 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c: In function ‘_rtl8723e_phy_iq_calibrate’:
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c:1150:6: warning: variable ‘bbvalue’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
index fa0eed434d4f6..fe9b407dc2aff 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/phy.c
@@ -1147,10 +1147,8 @@ static void _rtl8723e_phy_iq_calibrate(struct ieee80211_hw *hw,
const u32 retrycount = 2;
- u32 bbvalue;
-
if (t == 0) {
- bbvalue = rtl_get_bbreg(hw, 0x800, MASKDWORD);
+ rtl_get_bbreg(hw, 0x800, MASKDWORD);
rtl8723_save_adda_registers(hw, adda_reg,
rtlphy->adda_backup, 16);
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 27/41] rtlwifi: halbtc8821a1ant: Remove set but unused variable 'wifi_rssi_state'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (25 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 26/41] rtlwifi: phy: Remove set but unused variable 'bbvalue' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 28/41] rtl8723be: phy: Remove set but unused variable 'lc_cal' Lee Jones
` (14 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c: In function ‘btc8821a1ant_run_coexist_mechanism’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1904:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
index 9f5e85be97645..a18dffc8753a9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c
@@ -1901,7 +1901,6 @@ static void btc8821a1ant_run_coexist_mechanism(struct btc_coexist *btcoexist)
bool increase_scan_dev_num = false;
bool bt_ctrl_agg_buf_size = false;
u8 agg_buf_size = 5;
- u8 wifi_rssi_state = BTC_RSSI_STATE_HIGH;
u32 wifi_link_status = 0;
u32 num_of_wifi_link = 0;
bool wifi_under_5g = false;
@@ -1962,8 +1961,7 @@ static void btc8821a1ant_run_coexist_mechanism(struct btc_coexist *btcoexist)
btc8821a1ant_limited_tx(btcoexist, NORMAL_EXEC, 0, 0, 0, 0);
} else {
if (wifi_connected) {
- wifi_rssi_state =
- btc8821a1ant_wifi_rssi_state(btcoexist, 1, 2,
+ btc8821a1ant_wifi_rssi_state(btcoexist, 1, 2,
30, 0);
btc8821a1ant_limited_tx(btcoexist,
NORMAL_EXEC, 1, 1,
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 28/41] rtl8723be: phy: Remove set but unused variable 'lc_cal'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (26 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 27/41] rtlwifi: halbtc8821a1ant: Remove set but unused variable 'wifi_rssi_state' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 29/41] rtl8188ee: phy: Remove set but unused variable 'reg_ea4' Lee Jones
` (13 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c: In function ‘_rtl8723be_phy_lc_calibrate’:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c:2181:36: warning: variable ‘lc_cal’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
index f09f55b0468a4..2b9313cb93dbd 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
@@ -2178,7 +2178,7 @@ static u8 _get_right_chnl_place_for_iqk(u8 chnl)
static void _rtl8723be_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t)
{
u8 tmpreg;
- u32 rf_a_mode = 0, rf_b_mode = 0, lc_cal;
+ u32 rf_a_mode = 0, rf_b_mode = 0;
struct rtl_priv *rtlpriv = rtl_priv(hw);
tmpreg = rtl_read_byte(rtlpriv, 0xd03);
@@ -2202,7 +2202,7 @@ static void _rtl8723be_phy_lc_calibrate(struct ieee80211_hw *hw, bool is2t)
rtl_set_rfreg(hw, RF90_PATH_B, 0x00, MASK12BITS,
(rf_b_mode & 0x8FFFF) | 0x10000);
}
- lc_cal = rtl_get_rfreg(hw, RF90_PATH_A, 0x18, MASK12BITS);
+ rtl_get_rfreg(hw, RF90_PATH_A, 0x18, MASK12BITS);
rtl_set_rfreg(hw, RF90_PATH_A, 0xb0, RFREG_OFFSET_MASK, 0xdfbe0);
rtl_set_rfreg(hw, RF90_PATH_A, 0x18, MASK12BITS, 0x8c0a);
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 29/41] rtl8188ee: phy: Remove set but unused variable 'reg_ea4'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (27 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 28/41] rtl8723be: phy: Remove set but unused variable 'lc_cal' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:23 ` [PATCH 30/41] rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables Lee Jones
` (12 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c: In function ‘_rtl88e_phy_path_a_iqk’:
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c:1351:33: warning: variable ‘reg_ea4’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c
index 9be032e8ec95b..12d0b3a87af7c 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/phy.c
@@ -1348,7 +1348,7 @@ static bool _rtl88e_phy_set_sw_chnl_cmdarray(struct swchnlcmd *cmdtable,
static u8 _rtl88e_phy_path_a_iqk(struct ieee80211_hw *hw, bool config_pathb)
{
- u32 reg_eac, reg_e94, reg_e9c, reg_ea4;
+ u32 reg_eac, reg_e94, reg_e9c;
u8 result = 0x00;
rtl_set_bbreg(hw, 0xe30, MASKDWORD, 0x10008c1c);
@@ -1365,7 +1365,7 @@ static u8 _rtl88e_phy_path_a_iqk(struct ieee80211_hw *hw, bool config_pathb)
reg_eac = rtl_get_bbreg(hw, 0xeac, MASKDWORD);
reg_e94 = rtl_get_bbreg(hw, 0xe94, MASKDWORD);
reg_e9c = rtl_get_bbreg(hw, 0xe9c, MASKDWORD);
- reg_ea4 = rtl_get_bbreg(hw, 0xea4, MASKDWORD);
+ rtl_get_bbreg(hw, 0xea4, MASKDWORD);
if (!(reg_eac & BIT(28)) &&
(((reg_e94 & 0x03FF0000) >> 16) != 0x142) &&
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 30/41] rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (28 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 29/41] rtl8188ee: phy: Remove set but unused variable 'reg_ea4' Lee Jones
@ 2020-11-02 11:23 ` Lee Jones
2020-11-02 11:24 ` [PATCH 31/41] mwifiex: pcie: Remove a couple of unchecked 'ret's Lee Jones
` (11 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:23 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c: In function ‘btc8821a2ant_action_bt_inquiry’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:1451:40: warning: variable ‘bt_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:1451:22: warning: variable ‘wifi_rssi_state1’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:1451:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c: In function ‘btc8821a2ant_action_wifi_idle_process’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:1519:40: warning: variable ‘bt_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:1519:5: warning: variable ‘wifi_rssi_state’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c: In function ‘btc8821a2ant_action_pan_hs’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:2990:22: warning: variable ‘wifi_rssi_state1’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c: In function ‘btc8821a2ant_action_hid_a2dp’:
drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c:3277:22: warning: variable ‘wifi_rssi_state1’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
.../rtlwifi/btcoexist/halbtc8821a2ant.c | 27 +++++++++----------
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c
index e53789f11b08a..447caa4aad325 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a2ant.c
@@ -1448,17 +1448,15 @@ static void btc8821a2ant_init_coex_dm(struct btc_coexist *btcoexist)
static void btc8821a2ant_action_bt_inquiry(struct btc_coexist *btcoexist)
{
struct rtl_priv *rtlpriv = btcoexist->adapter;
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
bool wifi_connected = false;
bool low_pwr_disable = true;
bool scan = false, link = false, roam = false;
- wifi_rssi_state =
- btc8821a2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
- wifi_rssi_state1 = btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
+ btc8821a2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
BT_8821A_2ANT_WIFI_RSSI_COEXSWITCH_THRES, 0);
- bt_rssi_state = btc8821a2ant_bt_rssi_state(btcoexist,
- 2, BT_8821A_2ANT_BT_RSSI_COEXSWITCH_THRES, 0);
+ btc8821a2ant_bt_rssi_state(btcoexist,
+ 2, BT_8821A_2ANT_BT_RSSI_COEXSWITCH_THRES, 0);
btcoexist->btc_set(btcoexist, BTC_SET_ACT_DISABLE_LOW_POWER,
&low_pwr_disable);
@@ -1516,15 +1514,14 @@ static void btc8821a2ant_action_wifi_link_process(struct btc_coexist *btcoexist)
static bool btc8821a2ant_action_wifi_idle_process(struct btc_coexist *btcoexist)
{
struct rtl_priv *rtlpriv = btcoexist->adapter;
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state1;
u8 ap_num = 0;
- wifi_rssi_state =
- btc8821a2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
+ btc8821a2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
wifi_rssi_state1 = btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
BT_8821A_2ANT_WIFI_RSSI_COEXSWITCH_THRES - 20, 0);
- bt_rssi_state = btc8821a2ant_bt_rssi_state(btcoexist,
- 2, BT_8821A_2ANT_BT_RSSI_COEXSWITCH_THRES, 0);
+ btc8821a2ant_bt_rssi_state(btcoexist,
+ 2, BT_8821A_2ANT_BT_RSSI_COEXSWITCH_THRES, 0);
btcoexist->btc_get(btcoexist, BTC_GET_U1_AP_NUM, &ap_num);
@@ -2987,11 +2984,11 @@ static void btc8821a2ant_action_pan_edr(struct btc_coexist *btcoexist)
/* PAN(HS) only */
static void btc8821a2ant_action_pan_hs(struct btc_coexist *btcoexist)
{
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state, bt_rssi_state;
u32 wifi_bw;
wifi_rssi_state = btc8821a2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
- wifi_rssi_state1 = btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
+ btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
BT_8821A_2ANT_WIFI_RSSI_COEXSWITCH_THRES, 0);
bt_rssi_state = btc8821a2ant_bt_rssi_state(btcoexist,
2, BT_8821A_2ANT_BT_RSSI_COEXSWITCH_THRES, 0);
@@ -3274,11 +3271,11 @@ static void btc8821a2ant_act_hid_a2dp_pan_edr(struct btc_coexist *btcoexist)
static void btc8821a2ant_action_hid_a2dp(struct btc_coexist *btcoexist)
{
u32 wifi_bw;
- u8 wifi_rssi_state, wifi_rssi_state1, bt_rssi_state;
+ u8 wifi_rssi_state, bt_rssi_state;
u8 ap_num = 0;
wifi_rssi_state = btc8821a2ant_wifi_rssi_state(btcoexist, 0, 2, 15, 0);
- wifi_rssi_state1 = btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
+ btc8821a2ant_wifi_rssi_state(btcoexist, 1, 2,
BT_8821A_2ANT_WIFI_RSSI_COEXSWITCH_THRES, 0);
bt_rssi_state = btc8821a2ant_bt_rssi_state(btcoexist,
3, BT_8821A_2ANT_BT_RSSI_COEXSWITCH_THRES, 37);
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 31/41] mwifiex: pcie: Remove a couple of unchecked 'ret's
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (29 preceding siblings ...)
2020-11-02 11:23 ` [PATCH 30/41] rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 32/41] rtl8723be: trx: Remove set but unused variable 'cck_highpwr' Lee Jones
` (10 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Amitkumar Karwar, Ganapathi Bhat,
Xinming Hu, David S. Miller, Jakub Kicinski, linux-wireless,
netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_pcie_remove’:
drivers/net/wireless/marvell/mwifiex/pcie.c:432:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/marvell/mwifiex/pcie.c: In function ‘mwifiex_cleanup_pcie’:
drivers/net/wireless/marvell/mwifiex/pcie.c:3142:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: Ganapathi Bhat <ganapathi.bhat@nxp.com>
Cc: Xinming Hu <huxinming820@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 6a10ff0377a24..67e0247ebaa65 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -429,7 +429,6 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
struct mwifiex_private *priv;
const struct mwifiex_pcie_card_reg *reg;
u32 fw_status;
- int ret;
card = pci_get_drvdata(pdev);
@@ -441,7 +440,7 @@ static void mwifiex_pcie_remove(struct pci_dev *pdev)
reg = card->pcie.reg;
if (reg)
- ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
+ mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
else
fw_status = -1;
@@ -3139,12 +3138,11 @@ static void mwifiex_cleanup_pcie(struct mwifiex_adapter *adapter)
struct pcie_service_card *card = adapter->card;
struct pci_dev *pdev = card->dev;
const struct mwifiex_pcie_card_reg *reg = card->pcie.reg;
- int ret;
u32 fw_status;
cancel_work_sync(&card->work);
- ret = mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
+ mwifiex_read_reg(adapter, reg->fw_status, &fw_status);
if (fw_status == FIRMWARE_READY_PCIE) {
mwifiex_dbg(adapter, INFO,
"Clearing driver ready signature\n");
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 32/41] rtl8723be: trx: Remove set but unused variable 'cck_highpwr'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (30 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 31/41] mwifiex: pcie: Remove a couple of unchecked 'ret's Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 33/41] rtlwifi: rtl8821ae: phy: Remove a couple of unused variables Lee Jones
` (9 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c: In function ‘_rtl8723be_query_rxphystatus’:
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c:53:6: warning: variable ‘cck_highpwr’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c
index 559ab78687c37..5a7cd270575a2 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c
@@ -50,7 +50,6 @@ static void _rtl8723be_query_rxphystatus(struct ieee80211_hw *hw,
pstatus->rx_mimo_signalquality[1] = -1;
if (is_cck) {
- u8 cck_highpwr;
u8 cck_agc_rpt;
cck_agc_rpt = p_phystrpt->cck_agc_rpt_ofdm_cfosho_a;
@@ -59,8 +58,7 @@ static void _rtl8723be_query_rxphystatus(struct ieee80211_hw *hw,
/* (2)PWDB, Average PWDB cacluated by
* hardware (for rate adaptive)
*/
- cck_highpwr = (u8)rtl_get_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2,
- BIT(9));
+ rtl_get_bbreg(hw, RFPGA0_XA_HSSIPARAMETER2, BIT(9));
lan_idx = ((cck_agc_rpt & 0xE0) >> 5);
vga_idx = (cck_agc_rpt & 0x1f);
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 33/41] rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (31 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 32/41] rtl8723be: trx: Remove set but unused variable 'cck_highpwr' Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 34/41] rtl8821ae: phy: Place braces around empty if() body Lee Jones
` (8 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: In function ‘rtl8821ae_phy_switch_wirelessband’:
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:597:14: warning: variable ‘rxpath’ set but not used [-Wunused-but-set-variable]
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:597:6: warning: variable ‘txpath’ set but not used [-Wunused-but-set-variable]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index f41a7643b9c42..72ee0700a5497 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -594,11 +594,10 @@ void rtl8821ae_phy_switch_wirelessband(struct ieee80211_hw *hw, u8 band)
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
struct rtl_dm *rtldm = rtl_dm(rtlpriv);
u8 current_band = rtlhal->current_bandtype;
- u32 txpath, rxpath;
s8 bb_diff_between_band;
- txpath = rtl8821ae_phy_query_bb_reg(hw, RTXPATH, 0xf0);
- rxpath = rtl8821ae_phy_query_bb_reg(hw, RCCK_RX, 0x0f000000);
+ rtl8821ae_phy_query_bb_reg(hw, RTXPATH, 0xf0);
+ rtl8821ae_phy_query_bb_reg(hw, RCCK_RX, 0x0f000000);
rtlhal->current_bandtype = (enum band_type) band;
/* reconfig BB/RF according to wireless mode */
if (rtlhal->current_bandtype == BAND_ON_2_4G) {
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 34/41] rtl8821ae: phy: Place braces around empty if() body
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (32 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 33/41] rtlwifi: rtl8821ae: phy: Remove a couple of unused variables Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 35/41] wlcore: spi: Demote a non-compliant function header, fix another Lee Jones
` (7 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Ping-Ke Shih, David S. Miller,
Jakub Kicinski, Larry Finger, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c: In function ‘_rtl8812ae_phy_get_txpower_limit’:
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:2453:3: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 72ee0700a5497..8a1a2277e137b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -2448,8 +2448,9 @@ static s8 _rtl8812ae_phy_get_txpower_limit(struct ieee80211_hw *hw,
else if (band == BAND_ON_5G)
channel_temp = _rtl8812ae_phy_get_chnl_idx_of_txpwr_lmt(hw,
BAND_ON_5G, channel);
- else if (band == BAND_ON_BOTH)
+ else if (band == BAND_ON_BOTH) {
;/* BAND_ON_BOTH don't care temporarily */
+ }
if (band_temp == -1 || regulation == -1 || bandwidth_temp == -1 ||
rate_section == -1 || channel_temp == -1) {
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 35/41] wlcore: spi: Demote a non-compliant function header, fix another
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (33 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 34/41] rtl8821ae: phy: Place braces around empty if() body Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 36/41] rtw8822b: Return type is not const Lee Jones
` (6 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, David S. Miller, Jakub Kicinski,
Geert Uytterhoeven, Luciano Coelho, Juuso Oikarinen,
linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ti/wlcore/spi.c:403: warning: Function parameter or member 'child' not described in 'wl12xx_spi_set_block_size'
drivers/net/wireless/ti/wlcore/spi.c:403: warning: Function parameter or member 'blksz' not described in 'wl12xx_spi_set_block_size'
drivers/net/wireless/ti/wlcore/spi.c:440: warning: Excess function parameter 'res' description in 'wlcore_probe_of'
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Luciano Coelho <luciano.coelho@nokia.com>
Cc: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ti/wlcore/spi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/spi.c b/drivers/net/wireless/ti/wlcore/spi.c
index 18c4d998ce4b9..f26fc150ecd01 100644
--- a/drivers/net/wireless/ti/wlcore/spi.c
+++ b/drivers/net/wireless/ti/wlcore/spi.c
@@ -391,7 +391,7 @@ static int wl12xx_spi_set_power(struct device *child, bool enable)
return ret;
}
-/**
+/*
* wl12xx_spi_set_block_size
*
* This function is not needed for spi mode, but need to be present.
@@ -431,7 +431,6 @@ MODULE_DEVICE_TABLE(of, wlcore_spi_of_match_table);
/**
* wlcore_probe_of - DT node parsing.
* @spi: SPI slave device parameters.
- * @res: resource parameters.
* @glue: wl12xx SPI bus to slave device glue parameters.
* @pdev_data: wlcore device parameters
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 36/41] rtw8822b: Return type is not const
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (34 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 35/41] wlcore: spi: Demote a non-compliant function header, fix another Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-07 16:10 ` [36/41] rtw88: " Kalle Valo
2020-11-02 11:24 ` [PATCH 37/41] iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header Lee Jones
` (5 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Yan-Hsuan Chuang, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtw88/rtw8822b.c:90:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
index 22d0dd640ac94..b420eb9148796 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c
@@ -87,7 +87,7 @@ static const u32 rtw8822b_txscale_tbl[RTW_TXSCALE_SIZE] = {
0x2d3, 0x2fe, 0x32b, 0x35c, 0x38e, 0x3c4, 0x3fe
};
-static const u8 rtw8822b_get_swing_index(struct rtw_dev *rtwdev)
+static u8 rtw8822b_get_swing_index(struct rtw_dev *rtwdev)
{
u8 i = 0;
u32 swing, table_value;
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 37/41] iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (35 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 36/41] rtw8822b: Return type is not const Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 38/41] realtek: rtw8822c: Remove unused variable 'corr_val' Lee Jones
` (4 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Johannes Berg, Emmanuel Grumbach,
Luca Coelho, Intel Linux Wireless, David S. Miller,
Jakub Kicinski, Shahar S Matityahu, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/fw/dbg.c:1932: warning: Function parameter or member 'reg_data' not described in 'iwl_dump_ini_mem'
drivers/net/wireless/intel/iwlwifi/fw/dbg.c:1932: warning: Excess function parameter 'reg' description in 'iwl_dump_ini_mem'
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
index ab4a8b942c81d..c0a180b496988 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c
@@ -1923,7 +1923,7 @@ struct iwl_dump_ini_mem_ops {
*
* @fwrt: fw runtime struct
* @list: list to add the dump tlv to
- * @reg: memory region
+ * @reg_data: memory region
* @ops: memory dump operations
*/
static u32 iwl_dump_ini_mem(struct iwl_fw_runtime *fwrt, struct list_head *list,
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 38/41] realtek: rtw8822c: Remove unused variable 'corr_val'
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (36 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 37/41] iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-07 16:11 ` [38/41] rtw88: " Kalle Valo
2020-11-02 11:24 ` [PATCH 39/41] ath9k: dynack: Demote non-compliant function header Lee Jones
` (3 subsequent siblings)
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Yan-Hsuan Chuang, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function ‘rtw8822c_dpk_dc_corr_check’:
drivers/net/wireless/realtek/rtw88/rtw8822c.c:2445:5: warning: variable ‘corr_val’ set but not used [-Wunused-but-set-variable]
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtw88/rtw8822c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
index e37300e98517b..b129a10707573 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
@@ -2442,7 +2442,7 @@ static void rtw8822c_dpk_rxbb_dc_cal(struct rtw_dev *rtwdev, u8 path)
static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
{
u16 dc_i, dc_q;
- u8 corr_val, corr_idx;
+ u8 corr_idx;
rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000900f0);
dc_i = (u16)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(27, 16));
@@ -2455,7 +2455,7 @@ static u8 rtw8822c_dpk_dc_corr_check(struct rtw_dev *rtwdev, u8 path)
rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000000f0);
corr_idx = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(7, 0));
- corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8));
+ rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8));
if (dc_i > 200 || dc_q > 200 || corr_idx < 40 || corr_idx > 65)
return 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 39/41] ath9k: dynack: Demote non-compliant function header
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (37 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 38/41] realtek: rtw8822c: Remove unused variable 'corr_val' Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 40/41] iwlwifi: fw: acpi: Demote non-conformant function headers Lee Jones
` (2 subsequent siblings)
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, QCA ath9k Development, David S. Miller,
Jakub Kicinski, Lorenzo Bianconi, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or member 'old' not described in 'ath_dynack_ewma'
drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or member 'new' not described in 'ath_dynack_ewma'
Cc: QCA ath9k Development <ath9k-devel@qca.qualcomm.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/ath/ath9k/dynack.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/dynack.c b/drivers/net/wireless/ath/ath9k/dynack.c
index fbeb4a739d321..3219715174a2f 100644
--- a/drivers/net/wireless/ath/ath9k/dynack.c
+++ b/drivers/net/wireless/ath/ath9k/dynack.c
@@ -44,9 +44,8 @@ static u32 ath_dynack_get_max_to(struct ath_hw *ah)
return 600;
}
-/**
+/*
* ath_dynack_ewma - EWMA (Exponentially Weighted Moving Average) calculation
- *
*/
static inline int ath_dynack_ewma(int old, int new)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 40/41] iwlwifi: fw: acpi: Demote non-conformant function headers
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (38 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 39/41] ath9k: dynack: Demote non-compliant function header Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-02 11:24 ` [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown Lee Jones
2020-11-02 15:42 ` [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless Kalle Valo
41 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Johannes Berg, Emmanuel Grumbach,
Luca Coelho, Intel Linux Wireless, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_object'
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_object'
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_object'
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'args' not described in 'iwl_acpi_get_dsm_object'
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_u8'
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_u8'
drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_u8'
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
index 3e5a35e26ad34..ab1d8b18d9976 100644
--- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
+++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c
@@ -113,11 +113,11 @@ void *iwl_acpi_get_object(struct device *dev, acpi_string method)
}
IWL_EXPORT_SYMBOL(iwl_acpi_get_object);
-/**
-* Generic function for evaluating a method defined in the device specific
-* method (DSM) interface. The returned acpi object must be freed by calling
-* function.
-*/
+/*
+ * Generic function for evaluating a method defined in the device specific
+ * method (DSM) interface. The returned acpi object must be freed by calling
+ * function.
+ */
static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func,
union acpi_object *args)
{
@@ -134,7 +134,7 @@ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func,
return obj;
}
-/**
+/*
* Evaluate a DSM with no arguments and a single u8 return value (inside a
* buffer object), verify and return that value.
*/
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (39 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 40/41] iwlwifi: fw: acpi: Demote non-conformant function headers Lee Jones
@ 2020-11-02 11:24 ` Lee Jones
2020-11-03 0:06 ` Brian Norris
2020-11-02 15:42 ` [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless Kalle Valo
41 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-02 11:24 UTC (permalink / raw)
To: kvalo
Cc: linux-kernel, Lee Jones, Yan-Hsuan Chuang, David S. Miller,
Jakub Kicinski, linux-wireless, netdev
Fixes the following W=1 kernel build warning(s):
drivers/net/wireless/realtek/rtw88/pci.c:1488:5: warning: no previous prototype for ‘rtw_pci_probe’ [-Wmissing-prototypes]
1488 | int rtw_pci_probe(struct pci_dev *pdev,
| ^~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/pci.c:1568:6: warning: no previous prototype for ‘rtw_pci_remove’ [-Wmissing-prototypes]
1568 | void rtw_pci_remove(struct pci_dev *pdev)
| ^~~~~~~~~~~~~~
drivers/net/wireless/realtek/rtw88/pci.c:1590:6: warning: no previous prototype for ‘rtw_pci_shutdown’ [-Wmissing-prototypes]
1590 | void rtw_pci_shutdown(struct pci_dev *pdev)
| ^~~~~~~~~~~~~~~~
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/net/wireless/realtek/rtw88/pci.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.h b/drivers/net/wireless/realtek/rtw88/pci.h
index ca17aa9cf7dc7..7cdbb9533a09a 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.h
+++ b/drivers/net/wireless/realtek/rtw88/pci.h
@@ -212,6 +212,10 @@ struct rtw_pci {
void __iomem *mmap;
};
+int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
+void rtw_pci_remove(struct pci_dev *pdev);
+void rtw_pci_shutdown(struct pci_dev *pdev);
+
static inline u32 max_num_of_tx_queue(u8 queue)
{
u32 max_num;
--
2.25.1
^ permalink raw reply related [flat|nested] 61+ messages in thread
* Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
2020-11-02 11:24 ` [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown Lee Jones
@ 2020-11-03 0:06 ` Brian Norris
2020-11-03 8:44 ` Lee Jones
0 siblings, 1 reply; 61+ messages in thread
From: Brian Norris @ 2020-11-03 0:06 UTC (permalink / raw)
To: Lee Jones
Cc: Kalle Valo, Linux Kernel, Yan-Hsuan Chuang, David S. Miller,
Jakub Kicinski, linux-wireless, <netdev@vger.kernel.org>
On Mon, Nov 2, 2020 at 3:25 AM Lee Jones <lee.jones@linaro.org> wrote:
> --- a/drivers/net/wireless/realtek/rtw88/pci.h
> +++ b/drivers/net/wireless/realtek/rtw88/pci.h
> @@ -212,6 +212,10 @@ struct rtw_pci {
> void __iomem *mmap;
> };
>
> +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
> +void rtw_pci_remove(struct pci_dev *pdev);
> +void rtw_pci_shutdown(struct pci_dev *pdev);
> +
>
These definitions are already in 4 other header files:
drivers/net/wireless/realtek/rtw88/rtw8723de.h
drivers/net/wireless/realtek/rtw88/rtw8821ce.h
drivers/net/wireless/realtek/rtw88/rtw8822be.h
drivers/net/wireless/realtek/rtw88/rtw8822ce.h
Seems like you should be moving them, not just adding yet another duplicate.
Brian
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
2020-11-03 0:06 ` Brian Norris
@ 2020-11-03 8:44 ` Lee Jones
2020-11-07 16:28 ` Kalle Valo
0 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-03 8:44 UTC (permalink / raw)
To: Brian Norris
Cc: Kalle Valo, Linux Kernel, Yan-Hsuan Chuang, David S. Miller,
Jakub Kicinski, linux-wireless, <netdev@vger.kernel.org>
On Mon, 02 Nov 2020, Brian Norris wrote:
> On Mon, Nov 2, 2020 at 3:25 AM Lee Jones <lee.jones@linaro.org> wrote:
> > --- a/drivers/net/wireless/realtek/rtw88/pci.h
> > +++ b/drivers/net/wireless/realtek/rtw88/pci.h
> > @@ -212,6 +212,10 @@ struct rtw_pci {
> > void __iomem *mmap;
> > };
> >
> > +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
> > +void rtw_pci_remove(struct pci_dev *pdev);
> > +void rtw_pci_shutdown(struct pci_dev *pdev);
> > +
> >
>
> These definitions are already in 4 other header files:
>
> drivers/net/wireless/realtek/rtw88/rtw8723de.h
> drivers/net/wireless/realtek/rtw88/rtw8821ce.h
> drivers/net/wireless/realtek/rtw88/rtw8822be.h
> drivers/net/wireless/realtek/rtw88/rtw8822ce.h
>
> Seems like you should be moving them, not just adding yet another duplicate.
I followed the current convention.
Happy to optimise if that's what is required.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
2020-11-03 8:44 ` Lee Jones
@ 2020-11-07 16:28 ` Kalle Valo
2020-11-07 18:42 ` Lee Jones
0 siblings, 1 reply; 61+ messages in thread
From: Kalle Valo @ 2020-11-07 16:28 UTC (permalink / raw)
To: Lee Jones
Cc: Brian Norris, Kalle Valo, Linux Kernel, Yan-Hsuan Chuang,
David S. Miller, Jakub Kicinski, linux-wireless,
<netdev@vger.kernel.org>
Lee Jones <lee.jones@linaro.org> writes:
> On Mon, 02 Nov 2020, Brian Norris wrote:
>
>> On Mon, Nov 2, 2020 at 3:25 AM Lee Jones <lee.jones@linaro.org> wrote:
>> > --- a/drivers/net/wireless/realtek/rtw88/pci.h
>> > +++ b/drivers/net/wireless/realtek/rtw88/pci.h
>> > @@ -212,6 +212,10 @@ struct rtw_pci {
>> > void __iomem *mmap;
>> > };
>> >
>> > +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
>> > +void rtw_pci_remove(struct pci_dev *pdev);
>> > +void rtw_pci_shutdown(struct pci_dev *pdev);
>> > +
>> >
>>
>> These definitions are already in 4 other header files:
>>
>> drivers/net/wireless/realtek/rtw88/rtw8723de.h
>> drivers/net/wireless/realtek/rtw88/rtw8821ce.h
>> drivers/net/wireless/realtek/rtw88/rtw8822be.h
>> drivers/net/wireless/realtek/rtw88/rtw8822ce.h
>>
>> Seems like you should be moving them, not just adding yet another duplicate.
>
> I followed the current convention.
>
> Happy to optimise if that's what is required.
I agree with Brian, these and rtw_pm_ops should be moved to pci.h to
avoid code duplication.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
2020-11-07 16:28 ` Kalle Valo
@ 2020-11-07 18:42 ` Lee Jones
0 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-07 18:42 UTC (permalink / raw)
To: Kalle Valo
Cc: Brian Norris, Linux Kernel, Yan-Hsuan Chuang, David S. Miller,
Jakub Kicinski, linux-wireless, <netdev@vger.kernel.org>
On Sat, 07 Nov 2020, Kalle Valo wrote:
> Lee Jones <lee.jones@linaro.org> writes:
>
> > On Mon, 02 Nov 2020, Brian Norris wrote:
> >
> >> On Mon, Nov 2, 2020 at 3:25 AM Lee Jones <lee.jones@linaro.org> wrote:
> >> > --- a/drivers/net/wireless/realtek/rtw88/pci.h
> >> > +++ b/drivers/net/wireless/realtek/rtw88/pci.h
> >> > @@ -212,6 +212,10 @@ struct rtw_pci {
> >> > void __iomem *mmap;
> >> > };
> >> >
> >> > +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id);
> >> > +void rtw_pci_remove(struct pci_dev *pdev);
> >> > +void rtw_pci_shutdown(struct pci_dev *pdev);
> >> > +
> >> >
> >>
> >> These definitions are already in 4 other header files:
> >>
> >> drivers/net/wireless/realtek/rtw88/rtw8723de.h
> >> drivers/net/wireless/realtek/rtw88/rtw8821ce.h
> >> drivers/net/wireless/realtek/rtw88/rtw8822be.h
> >> drivers/net/wireless/realtek/rtw88/rtw8822ce.h
> >>
> >> Seems like you should be moving them, not just adding yet another duplicate.
> >
> > I followed the current convention.
> >
> > Happy to optimise if that's what is required.
>
> I agree with Brian, these and rtw_pm_ops should be moved to pci.h to
> avoid code duplication.
Will do, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless
[not found] <20201102112410.1049272-1-lee.jones@linaro.org>
` (40 preceding siblings ...)
2020-11-02 11:24 ` [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown Lee Jones
@ 2020-11-02 15:42 ` Kalle Valo
2020-11-06 13:28 ` Lee Jones
41 siblings, 1 reply; 61+ messages in thread
From: Kalle Valo @ 2020-11-02 15:42 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, linux-wireless
Lee Jones <lee.jones@linaro.org> writes:
> [Last batch!]
>
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (41):
> wil6210: wmi: Correct misnamed function parameter 'ptr_'
> rsi_91x_usb: Fix some basic kernel-doc issues
> rtl8192cu: mac: Fix some missing/ill-documented function parameters
> rsi_91x_usb_ops: Source file headers are not good candidates for
> kernel-doc
> rtl8192cu: trx: Demote clear abuse of kernel-doc format
> brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
> brcmfmac: pcie: Provide description for missing function parameter
> 'devinfo'
> iwlwifi: mvm: rs: Demote non-conformant function documentation headers
> wl1251: cmd: Rename 'len' to 'buf_len' in the documentation
> ath9k: ar9330_1p1_initvals: Remove unused const variable
> 'ar9331_common_tx_gain_offset1_1'
> ath9k: ar9340_initvals: Remove unused const variable
> 'ar9340Modes_ub124_tx_gain_table_1p0'
> ath9k: ar9485_initvals: Remove unused const variable
> 'ar9485_fast_clock_1_1_baseband_postamble'
> ath9k: ar9003_2p2_initvals: Remove unused const variables
> prism54: isl_ioctl: Fix one function header and demote another
> iwlwifi: iwl-eeprom-read: Demote one nonconformant function header
> iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's
> header
> intersil: hostap_hw: Prevent incompatible function type cast
> brcm80211: fweh: Add missing description for 'gfp'
> ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg'
> param
> ath9k: ar5008_phy: Demote half completed function headers
> ath: dfs_pattern_detector: Fix some function kernel-doc headers
> ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers
> iwlwifi: iwl-phy-db: Add missing struct member description for 'trans'
> wl3501_cs: Fix misspelling and provide missing documentation
> rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
> rtlwifi: phy: Remove set but unused variable 'bbvalue'
> rtlwifi: halbtc8821a1ant: Remove set but unused variable
> 'wifi_rssi_state'
> rtl8723be: phy: Remove set but unused variable 'lc_cal'
> rtl8188ee: phy: Remove set but unused variable 'reg_ea4'
> rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
> mwifiex: pcie: Remove a couple of unchecked 'ret's
> rtl8723be: trx: Remove set but unused variable 'cck_highpwr'
> rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
> rtl8821ae: phy: Place braces around empty if() body
> wlcore: spi: Demote a non-compliant function header, fix another
> rtw8822b: Return type is not const
> iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header
> realtek: rtw8822c: Remove unused variable 'corr_val'
> ath9k: dynack: Demote non-compliant function header
> iwlwifi: fw: acpi: Demote non-conformant function headers
> realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
The cover letter was not CCed to linux-wireless, adding that. But the
patches itself look ok, I see all 41 of them in pathwork:
https://patchwork.kernel.org/project/linux-wireless/list/?series=375401&order=date
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless
2020-11-02 15:42 ` [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless Kalle Valo
@ 2020-11-06 13:28 ` Lee Jones
2020-11-06 13:35 ` Kalle Valo
0 siblings, 1 reply; 61+ messages in thread
From: Lee Jones @ 2020-11-06 13:28 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-kernel, linux-wireless
On Mon, 02 Nov 2020, Kalle Valo wrote:
> Lee Jones <lee.jones@linaro.org> writes:
>
> > [Last batch!]
> >
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (41):
> > wil6210: wmi: Correct misnamed function parameter 'ptr_'
> > rsi_91x_usb: Fix some basic kernel-doc issues
> > rtl8192cu: mac: Fix some missing/ill-documented function parameters
> > rsi_91x_usb_ops: Source file headers are not good candidates for
> > kernel-doc
> > rtl8192cu: trx: Demote clear abuse of kernel-doc format
> > brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
> > brcmfmac: pcie: Provide description for missing function parameter
> > 'devinfo'
> > iwlwifi: mvm: rs: Demote non-conformant function documentation headers
> > wl1251: cmd: Rename 'len' to 'buf_len' in the documentation
> > ath9k: ar9330_1p1_initvals: Remove unused const variable
> > 'ar9331_common_tx_gain_offset1_1'
> > ath9k: ar9340_initvals: Remove unused const variable
> > 'ar9340Modes_ub124_tx_gain_table_1p0'
> > ath9k: ar9485_initvals: Remove unused const variable
> > 'ar9485_fast_clock_1_1_baseband_postamble'
> > ath9k: ar9003_2p2_initvals: Remove unused const variables
> > prism54: isl_ioctl: Fix one function header and demote another
> > iwlwifi: iwl-eeprom-read: Demote one nonconformant function header
> > iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's
> > header
> > intersil: hostap_hw: Prevent incompatible function type cast
> > brcm80211: fweh: Add missing description for 'gfp'
> > ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg'
> > param
> > ath9k: ar5008_phy: Demote half completed function headers
> > ath: dfs_pattern_detector: Fix some function kernel-doc headers
> > ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers
> > iwlwifi: iwl-phy-db: Add missing struct member description for 'trans'
> > wl3501_cs: Fix misspelling and provide missing documentation
> > rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
> > rtlwifi: phy: Remove set but unused variable 'bbvalue'
> > rtlwifi: halbtc8821a1ant: Remove set but unused variable
> > 'wifi_rssi_state'
> > rtl8723be: phy: Remove set but unused variable 'lc_cal'
> > rtl8188ee: phy: Remove set but unused variable 'reg_ea4'
> > rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
> > mwifiex: pcie: Remove a couple of unchecked 'ret's
> > rtl8723be: trx: Remove set but unused variable 'cck_highpwr'
> > rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
> > rtl8821ae: phy: Place braces around empty if() body
> > wlcore: spi: Demote a non-compliant function header, fix another
> > rtw8822b: Return type is not const
> > iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header
> > realtek: rtw8822c: Remove unused variable 'corr_val'
> > ath9k: dynack: Demote non-compliant function header
> > iwlwifi: fw: acpi: Demote non-conformant function headers
> > realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
>
> The cover letter was not CCed to linux-wireless, adding that. But the
> patches itself look ok, I see all 41 of them in pathwork:
>
> https://patchwork.kernel.org/project/linux-wireless/list/?series=375401&order=date
What's the plan for these Kalle?
Are you able to take the ones that do not require a respin? It would
certainly safe a great deal of mailing list churn if I only
re-submitted the ones that required refactoring.
Of course if you require me to re-submit all of them, then I will do so.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless
2020-11-06 13:28 ` Lee Jones
@ 2020-11-06 13:35 ` Kalle Valo
2020-11-06 14:35 ` Lee Jones
0 siblings, 1 reply; 61+ messages in thread
From: Kalle Valo @ 2020-11-06 13:35 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel, linux-wireless
Lee Jones <lee.jones@linaro.org> writes:
> On Mon, 02 Nov 2020, Kalle Valo wrote:
>
>> Lee Jones <lee.jones@linaro.org> writes:
>>
>> > [Last batch!]
>> >
>> > This set is part of a larger effort attempting to clean-up W=1
>> > kernel builds, which are currently overwhelmingly riddled with
>> > niggly little warnings.
>> >
>> > Lee Jones (41):
>> > wil6210: wmi: Correct misnamed function parameter 'ptr_'
>> > rsi_91x_usb: Fix some basic kernel-doc issues
>> > rtl8192cu: mac: Fix some missing/ill-documented function parameters
>> > rsi_91x_usb_ops: Source file headers are not good candidates for
>> > kernel-doc
>> > rtl8192cu: trx: Demote clear abuse of kernel-doc format
>> > brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
>> > brcmfmac: pcie: Provide description for missing function parameter
>> > 'devinfo'
>> > iwlwifi: mvm: rs: Demote non-conformant function documentation headers
>> > wl1251: cmd: Rename 'len' to 'buf_len' in the documentation
>> > ath9k: ar9330_1p1_initvals: Remove unused const variable
>> > 'ar9331_common_tx_gain_offset1_1'
>> > ath9k: ar9340_initvals: Remove unused const variable
>> > 'ar9340Modes_ub124_tx_gain_table_1p0'
>> > ath9k: ar9485_initvals: Remove unused const variable
>> > 'ar9485_fast_clock_1_1_baseband_postamble'
>> > ath9k: ar9003_2p2_initvals: Remove unused const variables
>> > prism54: isl_ioctl: Fix one function header and demote another
>> > iwlwifi: iwl-eeprom-read: Demote one nonconformant function header
>> > iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's
>> > header
>> > intersil: hostap_hw: Prevent incompatible function type cast
>> > brcm80211: fweh: Add missing description for 'gfp'
>> > ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg'
>> > param
>> > ath9k: ar5008_phy: Demote half completed function headers
>> > ath: dfs_pattern_detector: Fix some function kernel-doc headers
>> > ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers
>> > iwlwifi: iwl-phy-db: Add missing struct member description for 'trans'
>> > wl3501_cs: Fix misspelling and provide missing documentation
>> > rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
>> > rtlwifi: phy: Remove set but unused variable 'bbvalue'
>> > rtlwifi: halbtc8821a1ant: Remove set but unused variable
>> > 'wifi_rssi_state'
>> > rtl8723be: phy: Remove set but unused variable 'lc_cal'
>> > rtl8188ee: phy: Remove set but unused variable 'reg_ea4'
>> > rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
>> > mwifiex: pcie: Remove a couple of unchecked 'ret's
>> > rtl8723be: trx: Remove set but unused variable 'cck_highpwr'
>> > rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
>> > rtl8821ae: phy: Place braces around empty if() body
>> > wlcore: spi: Demote a non-compliant function header, fix another
>> > rtw8822b: Return type is not const
>> > iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header
>> > realtek: rtw8822c: Remove unused variable 'corr_val'
>> > ath9k: dynack: Demote non-compliant function header
>> > iwlwifi: fw: acpi: Demote non-conformant function headers
>> > realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
>>
>> The cover letter was not CCed to linux-wireless, adding that. But the
>> patches itself look ok, I see all 41 of them in pathwork:
>>
>> https://patchwork.kernel.org/project/linux-wireless/list/?series=375401&order=date
>
> What's the plan for these Kalle?
>
> Are you able to take the ones that do not require a respin?
Been busy and I have 200+ patches to dive through. I (or my patchwork
script) will always let you know if I drop any patches.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 61+ messages in thread
* Re: [PATCH 00/41] [Set 4] Rid W=1 warnings in Wireless
2020-11-06 13:35 ` Kalle Valo
@ 2020-11-06 14:35 ` Lee Jones
0 siblings, 0 replies; 61+ messages in thread
From: Lee Jones @ 2020-11-06 14:35 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-kernel, linux-wireless
On Fri, 06 Nov 2020, Kalle Valo wrote:
> Lee Jones <lee.jones@linaro.org> writes:
>
> > On Mon, 02 Nov 2020, Kalle Valo wrote:
> >
> >> Lee Jones <lee.jones@linaro.org> writes:
> >>
> >> > [Last batch!]
> >> >
> >> > This set is part of a larger effort attempting to clean-up W=1
> >> > kernel builds, which are currently overwhelmingly riddled with
> >> > niggly little warnings.
> >> >
> >> > Lee Jones (41):
> >> > wil6210: wmi: Correct misnamed function parameter 'ptr_'
> >> > rsi_91x_usb: Fix some basic kernel-doc issues
> >> > rtl8192cu: mac: Fix some missing/ill-documented function parameters
> >> > rsi_91x_usb_ops: Source file headers are not good candidates for
> >> > kernel-doc
> >> > rtl8192cu: trx: Demote clear abuse of kernel-doc format
> >> > brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'
> >> > brcmfmac: pcie: Provide description for missing function parameter
> >> > 'devinfo'
> >> > iwlwifi: mvm: rs: Demote non-conformant function documentation headers
> >> > wl1251: cmd: Rename 'len' to 'buf_len' in the documentation
> >> > ath9k: ar9330_1p1_initvals: Remove unused const variable
> >> > 'ar9331_common_tx_gain_offset1_1'
> >> > ath9k: ar9340_initvals: Remove unused const variable
> >> > 'ar9340Modes_ub124_tx_gain_table_1p0'
> >> > ath9k: ar9485_initvals: Remove unused const variable
> >> > 'ar9485_fast_clock_1_1_baseband_postamble'
> >> > ath9k: ar9003_2p2_initvals: Remove unused const variables
> >> > prism54: isl_ioctl: Fix one function header and demote another
> >> > iwlwifi: iwl-eeprom-read: Demote one nonconformant function header
> >> > iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's
> >> > header
> >> > intersil: hostap_hw: Prevent incompatible function type cast
> >> > brcm80211: fweh: Add missing description for 'gfp'
> >> > ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg'
> >> > param
> >> > ath9k: ar5008_phy: Demote half completed function headers
> >> > ath: dfs_pattern_detector: Fix some function kernel-doc headers
> >> > ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers
> >> > iwlwifi: iwl-phy-db: Add missing struct member description for 'trans'
> >> > wl3501_cs: Fix misspelling and provide missing documentation
> >> > rtlwifi: halbtc8723b2ant: Remove a bunch of set but unused variables
> >> > rtlwifi: phy: Remove set but unused variable 'bbvalue'
> >> > rtlwifi: halbtc8821a1ant: Remove set but unused variable
> >> > 'wifi_rssi_state'
> >> > rtl8723be: phy: Remove set but unused variable 'lc_cal'
> >> > rtl8188ee: phy: Remove set but unused variable 'reg_ea4'
> >> > rtlwifi: halbtc8821a2ant: Remove a bunch of unused variables
> >> > mwifiex: pcie: Remove a couple of unchecked 'ret's
> >> > rtl8723be: trx: Remove set but unused variable 'cck_highpwr'
> >> > rtlwifi: rtl8821ae: phy: Remove a couple of unused variables
> >> > rtl8821ae: phy: Place braces around empty if() body
> >> > wlcore: spi: Demote a non-compliant function header, fix another
> >> > rtw8822b: Return type is not const
> >> > iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header
> >> > realtek: rtw8822c: Remove unused variable 'corr_val'
> >> > ath9k: dynack: Demote non-compliant function header
> >> > iwlwifi: fw: acpi: Demote non-conformant function headers
> >> > realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown
> >>
> >> The cover letter was not CCed to linux-wireless, adding that. But the
> >> patches itself look ok, I see all 41 of them in pathwork:
> >>
> >> https://patchwork.kernel.org/project/linux-wireless/list/?series=375401&order=date
> >
> > What's the plan for these Kalle?
> >
> > Are you able to take the ones that do not require a respin?
>
> Been busy and I have 200+ patches to dive through. I (or my patchwork
> script) will always let you know if I drop any patches.
Okay, so plan to pluck from that set.
That is ideal. Thanks for responding.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 61+ messages in thread