From: Kalle Valo <kvalo@codeaurora.org>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: <linux-wireless@vger.kernel.org>, Cathy Luo <cluo@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH 6/9] mwifiex: process rxba_sync event
Date: Mon, 18 Jul 2016 20:24:18 +0300 [thread overview]
Message-ID: <87mvlex3jx.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1468248832-21969-7-git-send-email-akarwar@marvell.com> (Amitkumar Karwar's message of "Mon, 11 Jul 2016 20:23:49 +0530")
Amitkumar Karwar <akarwar@marvell.com> writes:
> From: Xinming Hu <huxm@marvell.com>
>
> Firmware may filter and drop packets under certain condition, for
> example, ARP SA=DA packet. this event will be used to synchronize
> the Rx Block Acknowledgment (BA) window bitmap and to fill any holes
> in driver side.
>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
[...]
> --- a/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c
> +++ b/drivers/net/wireless/marvell/mwifiex/11n_rxreorder.c
> @@ -78,8 +78,15 @@ static int mwifiex_11n_dispatch_amsdu_pkt(struct mwifiex_private *priv,
> */
> static int mwifiex_11n_dispatch_pkt(struct mwifiex_private *priv, void *payload)
> {
> - int ret = mwifiex_11n_dispatch_amsdu_pkt(priv, payload);
>
> + int ret;
> +
> + if (payload == (void *)MWIFIEX_RX_PKT_DROPPED_IN_FW) {
> + mwifiex_dbg(priv->adapter, INFO, "info: fw drop data\n");
> + return 0;
> + }
[...]
> + mwifiex_dbg(priv->adapter, ERROR,
> + "drop packet,seq=%d\n",
> + seq_num);
> +
> + ret = mwifiex_11n_rx_reorder_pkt
> + (priv, seq_num, tlv_rxba->tid,
> + tlv_rxba->mac, 0,
> + (void *)MWIFIEX_RX_PKT_DROPPED_IN_FW);
[...]
> +/* Indicate packet has been dropped in FW */
> +#define MWIFIEX_RX_PKT_DROPPED_IN_FW 0xffffffff
That pointer magic is rather ugly, why not use a proper boolean?
--
Kalle Valo
next prev parent reply other threads:[~2016-07-18 17:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 14:53 [PATCH 0/9] mwifiex patches Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 1/9] mwifiex: Fixed endianness problem for big endian platform Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 2/9] mwifiex: add region code information in debugfs Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 3/9] mwifiex: fix failed to reconnect after interface disabled/enabled Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 4/9] mwifiex: support random MAC address for scanning Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler Amitkumar Karwar
2016-07-18 17:19 ` Kalle Valo
2016-07-21 9:18 ` Amitkumar Karwar
2016-07-21 15:51 ` Jouni Malinen
2016-07-22 15:59 ` Amitkumar Karwar
2016-07-22 16:55 ` Jouni Malinen
2016-07-25 9:33 ` Amitkumar Karwar
2016-07-26 15:12 ` Kalle Valo
2016-07-11 14:53 ` [PATCH 6/9] mwifiex: process rxba_sync event Amitkumar Karwar
2016-07-18 17:24 ` Kalle Valo [this message]
2016-07-21 9:48 ` Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 7/9] mwifiex: remove misleading disconnect message Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 8/9] mwifiex: add HT aggregation support for adhoc mode Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 9/9] mwifiex: fix radar detection issue Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvlex3jx.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=huxm@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).