From: Kalle Valo <kvalo@codeaurora.org>
To: Jouni Malinen <j@w1.fi>
Cc: Amitkumar Karwar <akarwar@marvell.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>, Cathy Luo <cluo@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler
Date: Tue, 26 Jul 2016 18:12:17 +0300 [thread overview]
Message-ID: <87r3agcu26.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160721155131.GA6292@w1.fi> (Jouni Malinen's message of "Thu, 21 Jul 2016 18:51:31 +0300")
Jouni Malinen <j@w1.fi> writes:
> On Thu, Jul 21, 2016 at 09:18:11AM +0000, Amitkumar Karwar wrote:
>> > From: Kalle Valo [mailto:kvalo@codeaurora.org]
>> > Is it correct to ignore the key index? I see that brcmfmac ignores it as
>> > well but I want to still confirm this.
>> >
>> > Does this mean that with this patcfh mwifiex properly supports MFP?
>>
>> Yes. We do pass MFP tests with this patch.
>
> Did you test IGTK rekeying? This patch looks exactly as broken as it did
> the last time it was proposed more than a year ago and after the same
> concern not receiving any reaction..
Indeed, I had already forgetten that this patch was submitted February
2015:
https://patchwork.kernel.org/patch/5819421/
Please don't do like this and repost patches without earlier comments
addressed (or at least document the history).
--
Kalle Valo
next prev parent reply other threads:[~2016-07-26 15:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 14:53 [PATCH 0/9] mwifiex patches Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 1/9] mwifiex: Fixed endianness problem for big endian platform Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 2/9] mwifiex: add region code information in debugfs Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 3/9] mwifiex: fix failed to reconnect after interface disabled/enabled Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 4/9] mwifiex: support random MAC address for scanning Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler Amitkumar Karwar
2016-07-18 17:19 ` Kalle Valo
2016-07-21 9:18 ` Amitkumar Karwar
2016-07-21 15:51 ` Jouni Malinen
2016-07-22 15:59 ` Amitkumar Karwar
2016-07-22 16:55 ` Jouni Malinen
2016-07-25 9:33 ` Amitkumar Karwar
2016-07-26 15:12 ` Kalle Valo [this message]
2016-07-11 14:53 ` [PATCH 6/9] mwifiex: process rxba_sync event Amitkumar Karwar
2016-07-18 17:24 ` Kalle Valo
2016-07-21 9:48 ` Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 7/9] mwifiex: remove misleading disconnect message Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 8/9] mwifiex: add HT aggregation support for adhoc mode Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 9/9] mwifiex: fix radar detection issue Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3agcu26.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).