From: Kalle Valo <kvalo@codeaurora.org>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: <linux-wireless@vger.kernel.org>, Cathy Luo <cluo@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>
Subject: Re: [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler
Date: Mon, 18 Jul 2016 20:19:01 +0300 [thread overview]
Message-ID: <87r3aqx3sq.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1468248832-21969-6-git-send-email-akarwar@marvell.com> (Amitkumar Karwar's message of "Mon, 11 Jul 2016 20:23:48 +0530")
Amitkumar Karwar <akarwar@marvell.com> writes:
> It is observed that hostapd fails to setup with management frame
> protection mode enabled when using mwifiex. This patch adds
> cfg80211_set_default_mgmt_key handler to resolve the problem.
>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> ---
> drivers/net/wireless/marvell/mwifiex/cfg80211.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> index 8955f8c..bf95cca 100644
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -484,6 +484,18 @@ mwifiex_cfg80211_add_key(struct wiphy *wiphy, struct net_device *netdev,
> }
>
> /*
> + * CFG802.11 operation handler to set default mgmt key.
> + */
> +static int
> +mwifiex_cfg80211_set_default_mgmt_key(struct wiphy *wiphy,
> + struct net_device *netdev,
> + u8 key_index)
> +{
> + wiphy_dbg(wiphy, "set default mgmt key, key index=%d\n", key_index);
> + return 0;
> +}
> +
> +/*
> * This function sends domain information to the firmware.
> *
> * The following information are passed to the firmware -
> @@ -4002,6 +4014,7 @@ static struct cfg80211_ops mwifiex_cfg80211_ops = {
> .leave_ibss = mwifiex_cfg80211_leave_ibss,
> .add_key = mwifiex_cfg80211_add_key,
> .del_key = mwifiex_cfg80211_del_key,
> + .set_default_mgmt_key = mwifiex_cfg80211_set_default_mgmt_key,
> .mgmt_tx = mwifiex_cfg80211_mgmt_tx,
> .mgmt_frame_register = mwifiex_cfg80211_mgmt_frame_register,
> .remain_on_channel = mwifiex_cfg80211_remain_on_channel,
Is it correct to ignore the key index? I see that brcmfmac ignores it as
well but I want to still confirm this.
Does this mean that with this patcfh mwifiex properly supports MFP?
--
Kalle Valo
next prev parent reply other threads:[~2016-07-18 17:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 14:53 [PATCH 0/9] mwifiex patches Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 1/9] mwifiex: Fixed endianness problem for big endian platform Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 2/9] mwifiex: add region code information in debugfs Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 3/9] mwifiex: fix failed to reconnect after interface disabled/enabled Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 4/9] mwifiex: support random MAC address for scanning Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 5/9] mwifiex: cfg80211 set_default_mgmt_key handler Amitkumar Karwar
2016-07-18 17:19 ` Kalle Valo [this message]
2016-07-21 9:18 ` Amitkumar Karwar
2016-07-21 15:51 ` Jouni Malinen
2016-07-22 15:59 ` Amitkumar Karwar
2016-07-22 16:55 ` Jouni Malinen
2016-07-25 9:33 ` Amitkumar Karwar
2016-07-26 15:12 ` Kalle Valo
2016-07-11 14:53 ` [PATCH 6/9] mwifiex: process rxba_sync event Amitkumar Karwar
2016-07-18 17:24 ` Kalle Valo
2016-07-21 9:48 ` Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 7/9] mwifiex: remove misleading disconnect message Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 8/9] mwifiex: add HT aggregation support for adhoc mode Amitkumar Karwar
2016-07-11 14:53 ` [PATCH 9/9] mwifiex: fix radar detection issue Amitkumar Karwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3aqx3sq.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=cluo@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).