Linux-Wireless Archive on lore.kernel.org
 help / color / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature
Date: Fri, 13 Sep 2019 14:14:27 -0700
Message-ID: <b43f737c06a392957e6f651d59282a3f36fd05e5.camel@gmail.com> (raw)
In-Reply-To: <47aaaccf7d8fb58587f0cfbe38acd18e1420dc9a.camel@sipsolutions.net>

On Fri, 2019-09-13 at 23:01 +0200, Johannes Berg wrote:
> On Fri, 2019-09-13 at 13:56 -0700, James Prestwood wrote:
> > Hi,
> > 
> > On Fri, 2019-09-13 at 22:48 +0200, Johannes Berg wrote:
> > > On Fri, 2019-09-13 at 12:59 -0700, James Prestwood wrote:
> > > > Add a new feature bit signifying that the wireless hardware
> > > > supports
> > > > changing the mac address while the underlying net_device is
> > > > UP.  Note
> > > > that this is slightly different from IFF_LIVE_ADDR_CHANGE as
> > > > additional
> > > > restrictions might be imposed by the hardware.  Typical
> > > > restrictions
> > > > are:
> > > > 	- No connection is active on this interface, e.g.
> > > > carrier is
> > > > off
> > > > 	- No scan is in progress
> > > > 	- No offchannel operation is in progress
> > > 
> > > Hmm, what do you need this patch for?
> > > 
> > > IFF_LIVE_ADDR_CHANGE should be sufficient to discover it?
> > 
> > Because userspace needs to know if this is supported?
> > IFF_LIVE_ADDR_CHANGE is a private flag... AFAIK userspace has no
> > way of
> > obtaining this.
> 
> Oh, annoying.
> 
> But that doesn't really mean that nl80211 is an appropriate place to
> advertise it, IMHO?

The intention of the flag was not soley related to
CMD_CONNECT/CMD_AUTHENTICATE. Its an indication that the
hardware/driver supports a live address change. If you don't want it
here could you suggest a better location for it?

> 
> And in nl80211 you'd need the flag for if you actually have the
> "change
> MAC address during connect" attribute.
> 
> johannes
> 


  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 19:59 James Prestwood
2019-09-13 19:59 ` [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature James Prestwood
2019-09-13 20:48 ` [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature Johannes Berg
2019-09-13 20:56   ` James Prestwood
2019-09-13 21:01     ` Johannes Berg
2019-09-13 21:14       ` James Prestwood [this message]
2019-09-17 20:09         ` James Prestwood

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b43f737c06a392957e6f651d59282a3f36fd05e5.camel@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Wireless Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-wireless/0 linux-wireless/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-wireless linux-wireless/ https://lore.kernel.org/linux-wireless \
		linux-wireless@vger.kernel.org linux-wireless@archiver.kernel.org
	public-inbox-index linux-wireless


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-wireless


AGPL code for this site: git clone https://public-inbox.org/ public-inbox