linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>,
	James Prestwood <prestwoj@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature
Date: Thu, 10 Oct 2019 17:18:02 +0200	[thread overview]
Message-ID: <bbe3369418b948de0d54aefa16e2bf77693351bd.camel@sipsolutions.net> (raw)
In-Reply-To: <cc2cee76-2a83-17ad-0e7a-ba71075e1497@gmail.com> (sfid-20191008_225601_596382_1D893268)

On Tue, 2019-10-08 at 15:55 -0500, Denis Kenzior wrote:

> Right, so you're talking in the context of this implementation which 
> performs a remove/add interface.  You're right about that.
> 
> But I was asking more in general terms.  If all we're doing is scanning, 
> can we just change the mac?  Anyway, not important.  Maybe I bring this 
> up once this set is accepted.

Maybe, but honestly, I'm not convinced the complexity would be worth it.
You'd have to push this all the way through to the driver, so it knows
to do it, or defer it until the scan is done, or something? Not
something you'd want to do on all hardware while a non-randomized scan
is running, for example (iwlwifi might actually be OK).

Or you could perhaps cache the MAC address change in mac80211 and apply
it at the next possible point in time - but then again you have to be
really careful to actually apply it and block all further operations,
even if a bunch of remain-on-channel's are active and you request a new
scan, that has to be blocked until the remain-on-channel is done *and*
the MAC address change is applied?

Seems rather complex for very little value.

johannes


  reply	other threads:[~2019-10-10 15:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 19:59 [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature James Prestwood
2019-09-13 19:59 ` [PATCH 2/2] mac80211: Support LIVE_ADDRESS_CHANGE feature James Prestwood
2019-10-04 11:56   ` Johannes Berg
2019-10-04 16:25     ` James Prestwood
2019-10-04 16:42       ` James Prestwood
2019-10-07 21:16         ` Johannes Berg
2019-10-08 15:37           ` Denis Kenzior
2019-10-08 15:52             ` Johannes Berg
2019-10-08 15:53               ` Denis Kenzior
2019-10-08 16:24                 ` Johannes Berg
2019-10-08 16:23                   ` Denis Kenzior
2019-10-08 17:08                     ` Johannes Berg
2019-10-08 18:50                       ` Denis Kenzior
2019-10-08 20:16                         ` Johannes Berg
2019-10-08 20:55                           ` Denis Kenzior
2019-10-10 15:18                             ` Johannes Berg [this message]
2019-10-07 21:11       ` Johannes Berg
2019-10-08 15:28         ` Denis Kenzior
2019-10-08 15:49           ` Johannes Berg
2019-09-13 20:48 ` [PATCH 1/2] nl80211: Add LIVE_ADDR_CHANGE feature Johannes Berg
2019-09-13 20:56   ` James Prestwood
2019-09-13 21:01     ` Johannes Berg
2019-09-13 21:14       ` James Prestwood
2019-09-17 20:09         ` James Prestwood
2019-10-01  9:14         ` Johannes Berg
2019-10-08 22:13           ` James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbe3369418b948de0d54aefa16e2bf77693351bd.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=denkenz@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).